Another minor case in which you would be allowed to battlecalculate something impossible is that you could have a battle in which there are marine units that are not using the marine bonus (cause you didn't check it) but are allowing ships to bombard. This could be addressed by excluding all marine units (like in the above example of non-sea-transportable units) from granting bombard ability, if the check is missing, but I think it would be strange if that check does that for marines, while nothing like that influences the other units (and most likely it would also confuse people, not expecting such a behaviour); so this goes basically back to the matter that you cannot define what units were offloaded and what not, that is maybe not sensible to address, as the user would rather set himself the battleships to the right number, by rules, than somewhat defining what is being offloaded (if it would be possible, in some ways).

Maybe going off topic, I want to underline that this issue, or rather the pointless ability of calculating for impossible bombard situations, is also present since the basic Classic (v1), as you can battlecalculate for battles with only air units and naval bombard, or, for custom maps, with non-transportable land units, instead. Really, all rulesets factually have a "Shore Bombard Per Ground Unit Restricted", except that, rather than Boolean, that should have been infinite for v1 and v2 (1 offloaded unit grants infinite shore bombards) and equal to 1 for v3 onwards (if this would have been done this way, you could have also had custom maps setting it to some other natural numbers).

For now I've fixed that logic so bombard units always use their bombard value and added a tooltip for "Battle Is Amphibious" to say "Determines if isMarine bonus is applied for all attacking land units". PR: https://github.com/triplea-game/triplea/pull/4917

But yes for maps that don't have marines, its completely meaningless and could now just be hidden. You could take it the other direction as well where is shows/hides potential bombarding units in the attacking unit list. I'll think about this a bit but at least the bug is fixed now.

ron-murhammer created this issue in triplea-game/triplea

closed Calc: Fix bombard value and handle limited bombard per land units #4917

Also, in the moment that thing should have one job, I would rename it to something like "Add marine bonus" or "Add sea borne modifiers to any units". I also really dislike the use of the term "amphibious", as that, biologically, would mean something that can fully live in and outside water. For example, a duck can swim in water and go on earth, but it is not an amphibious.

@Cernel @ubernaut So it appears "Battle is Amphibious" controls 2 things currently:

1. Whether isMarine bonus is applied to all attackers that have it set.
2. Whether any bombard units use their bombard value rather than attack value (this is why you only see a difference on maps like TWW where units have bombard values different from attack values). This really shouldn't be the case as if they are bombarding they should always use their bombard value.

@Cernel it allows for bombards calc adjustments in other games does it not?

"Also, it doesn't appear to be needed for adding up the naval bombard at all, so I'm not sure why you checked that box @ubernaut."

not quite sure what you are saying here.

You don't need to check it to add up any units for naval bombard. I never check it, when I play games without marines.

"Also, it doesn't appear to be needed for adding up the naval bombard at all, so I'm not sure why you checked that box @ubernaut."

not quite sure what you are saying here.

@zlefin looks like you are correct sir:

@redrum @LaFayette @RoiEX @ssoloff More generally, we would need a developer to delve into the code and check what the "Battle is Amphibious" check-box is for (full list). The only thing I'm aware of is adding the "marine" bonus to all marine units (in this regard, an incomplete feature, as you cannot calculate for cases of only part of the marine units being actually sea borne (say, in a map like Napoleonic Empires)), but I don't know what else that is for.

As there are no "marine" units in a game like "World War II v3 1941", I don't understand what that "Battle is Amphibious" check-box is for, and, if the answer is nothing, then I believe it should be either not present or at least having the function of not showing and setting to 0 all the naval bombard units when unchecked (personally not a strong preference for either solutions, in case).

Also, it doesn't appear to be needed for adding up the naval bombard at all, so I'm not sure why you checked that box @ubernaut.