@Frostion said in How Do Land Transports Work?:
If isInfantry is only used in regards to making a unit land transportable, why should it not be renamed to isLandTransportable? I think this would make sense taken the isAirTransportable name in mind.
That is one of the things I considered, but decided not to include, when I made my proposals before the 1.9 release, if you remember what I'm referring to, and would even more not do it now. Also, all my suggestions were agreed, but not all were made, due to various problems and reasons mostly I don't know, and, even so, there has been a bunch of problems of things not getting changed etc. (there has been a lot of map bugs related to the changes I suggested and we are still finding maps having "isImpassible" this month).
Naming and consistency has never been the strong point of TripleA, and, if we would go after each thing, we would have to rename a lot.
For example, on this line, also "artillery" should be renamed to "givesSupport" and "artillerySupportable" to "isSupportable", or something, or we should rename "attackAA" to "defensiveAttackAA", etc. etc.. Also, the opposite of "defense" would be "offense", not "attack", strictly speaking. Attack just means that you are making contact with the enemy, which you do in "defense" too, normally.
That is why I limited my suggestions only to really silly or duplicate or visible things (for example, "battleships" instead of "units" is visible to all users, since it is a "property", while "isInfantry" is only for mapmakers, as you can see it is already displayed to users as "can be Transported By Land", in the tooltips).
Let's say that "isInfantry" is definitely not a clear way to name the matter (and, yes, I confirm it just means it is land transportable), it obliges us to endlessly keep confirming to new mapmakers that it indeed just means land transportable, and can be taken as a small additional reason for doing something as per what I said at my point "2a" (but I would not do it just for changing the name itself).
Just to give some background why the strange difference in naming between the land and the air transportable units, and pointing out that my memory / knowledge may fail, in the past (and we are talking of something before 2013 here) the "isInfantry" used to make a unit both land and air transportable, but, at least at some point, there were also the "isParatroop" and "isMechanized", that I don't remember if they were required beside the "isInfantry" or were another step before or after that. Whatever the case, the "isInfantry" was split, and the land part kept being named as "isInfantry", while the air part was either named as "isAirTransportable" or "isParatroop", I don't know. Also, back then, when the "isMechanized" option worked (then, until shortly before the 1.9 release, was just kept doing nothing, to avoid games crashing (I don't actually agree that a game being silently bugged is preferable than crashing, but just my opinion)), there was not an option to define what was the land transport, but the land transport was assumed to be any units able to blitz (and maybe there were other requisites to define what was the land transport; I don't really know). Again, I'm not sure of any of these, and I might totally be saying nonsense, and it is really not important; this is just to give you some not necessarily correct background of why you are seeing "isAirTransportable" and "isInfantry", instead of a more sensible "isLandTransportable" ("isInfantry" was just both, as I said). Could also be that "isInfantry" did other things, at any points, I duno.