@Cernel , You probably would not believe how much time we spend trying not to break things or change things unexpectedly. In all seriousness, that activity alone of ensuring no regressions probably doubles or triples, or 5x's the time it takes to make any update. Hence why it's so favorable to remove things that need not be there or are barely worth this rather tremendous cost. Even then, we make mistakes as the code is crafted together like a well played game of jenga before the last round.
Navigate to repository: https://github.com/triplea-maps/new_world_order1915lebowski
Click fork button:
Noticate the URL is different and should have your name in it.
Navigate to the folder where you want to add files, click upload files:
Select the file to upload and select 'create a new branch':
Then if that's the only file, add a change summary and click create pull request:
IF there are more files, go back to your fork, and click "branches", eg:
Select the branch you just created:
Be careful as you navigate now that the URL continues to have your branch name in it, if not then go back and select your branch. Now browse to where you want to upload files and click upload files. Repeat this process until you have them all uploaded.
Once done, head back to the 'main repository': https://github.com/triplea-maps/new_world_order1915lebowski
There should be a some convenience buttons avialable to you to create pull requests from your branch, eg (notice the green buttons):
Once the pull request is made, map admins will review it and merge it, then it'll be part of the map.
We probably would want to show more info rather than less in this scenario. Line breaking once or twice before finally truncating would probably fit most use-cases. If the text is truncated, would be to show some ellipses to explicitly indicate it is cut-off.
Having ctrl+h toggle history mode on/off is actually not simple. There is a lot of coordination code to turn history on, turning it on/off rapidly easily produces errors. These are not trivial to sort through. I'm not sure which ctrl+letter combination we could use for 'highlight'. The menu options only take 'ctrl+letter' combination, the reason we can get rid of the highlight icon is if we can get the hotkey to be labeled somewhere, in menu being a good place.
I like the suggestion @Cernel . I'm no longer convinced this feature should have a hotkey for it. Is it really used that often by anyone? Just curious if we can find a person/example where someone really wants to toggle it on/off often enough to want a hotkey.
Having the setting 'stick' with maps seems like a very good idea though.
Following up on a few threads, want to create a dedicated/explicit one for unit highlight discussion and feedback.
Planning to:
@redrum I wonder if it was (presumably) not used much because it's not useful or nobody would have known it existed? We do have some work ahead for better discoverability of the many hotkeys and improving locality of controls (EG: battle settings being available in the battle window).
@redrum Not a bad idea, 'n' for 'notes' would collide with unit scroller 'n' for 'next unit'. The others offhand look okay.
(4) TBH I do not like. It takes a few seconds to re-render, it's pretty slow to go through each state compared to just selecting the desired option directly. We also gain the cost of a hotkey binding. I'm certainly leaning towards no hotkey at all on this one.
