@ubernaut Ok. I'll reply here once its merged and there is a new pre-release to test.

@ubernaut I was able to reproduce and fix the bug on G40 G1 related to the error "IllegalStateException - ConcurrentBattleCalculator.calculate: friendlyUnits should but does not contain all units from targetsToPickFrom". Here is the PR and once that is merged, you can download the new pre-release to avoid the error: https://github.com/triplea-game/triplea/pull/5933

Thanks again for testing and reporting the issue.

ron-murhammer created this issue in triplea-game/triplea

closed Fix Targets Including Dead Units Bug #5933

@ryguy25 Yeah, you can run it only on devices/computers that can run Java. So generally not iPads or Andriod tablets only windows based tablets like Microsoft Surface or actual laptops/PCs.

@ubernaut Alright. I'll take a look then today.

@ubernaut Oh really? On just a brand new G40 game? Does it happen pretty much every time?

@ubernaut Yeah, that's a bad error. I'm assuming its happening during the AI's turn? Do you have a save game that can reproduce it?

@ubernaut Are you the one that reported this error? https://github.com/triplea-game/triplea/issues/5929. If so can you describe when it occurred and are you able to reproduce it?

User Description
started game g40 2nd additiona with ai hard for axis

tripleabuilderbot created this issue in triplea-game/triplea

closed IllegalStateException - ConcurrentBattleCalculator.calculate: friendlyUnits should but does not contain all units from targetsToPickFrom #5929

@ubernaut Ok, I believe it should be aware of your range and if not that's a pretty big issue for the map as it would make it very easy to pick off their fleets since they wouldn't see the threat.

@ubernaut It didn't attack France at all? That would seem pretty strange. Does that happen frequently?

Yeah, I believe the AI will use the airfield and port move bonus but I don't think it actively tries to end in a sea zone with a port (I believe it does actively try to land where there are airfields).

@ubernaut Global is generally fine though the AI's diplomacy on the map is fairly limited and has a decent amount of randomness. It also doesn't understand NOs. Other than those 2 limitations it should play fairly well.

So if you turn off NOs and do war declarations for it then you'll probably have an even better game.