Non AA target groups names

[Trevan]

AA has the typeAA that is used to group AA units into firing sets. It is also used to name the firing set when shown in the Battle Display UI. With the addition of canNotTarget and canNotBeTargetedBy, non AA units now have custom firing sets and targeting sets. The Battle Display UI will not show the separate firing sets and will run the dice rolling, casualty selection, and removal of casualties all under the same label.

Here's an image of what I'm talking about with the Battle Display UI.

This is from Iron War. Notice how there is "Germany AA fire", "Germany dive bombing fire", "Britain AA fire", and "Britain dive bombing fire" with their related select/remove casualty lines. But for the canNotBeTargetedBy, there is only a generic "Air attack non subs" and "Air defend non subs".

I think it would be nice to also show "Germany Air Units attack" and "Germany Sea Units attack" (with their individual select/remove casualty lines) to indicate what is actually happening.

But what if canNotBeTargetedBy is custom? What if there is a unit that can not be targeted by some air units and some sea units. What would be the name for that group?

Should this require changes to the xml? Should there be a firingGroupName? What about creating a new xml element that defines firing groups. And then you attach the firing group to the units that are part of it.

So, for example:

<firingGroups>
  <firingGroup name="subs" display="Subs">
    <canNotTarget value="fighter:bomber" />
  </firingGroup>
  <firingGroup name="air" display="Air Unit">
    <canNotTarget value="submarine" unless="destroyer" />
  </firingGroup>
  <firingGroup name="divebombers" display="dive bombing">
    <canTarget value="cruiser:battleship:tank" />
  </firingGroup>
</firingGroups>

And then in the unit definition:

<attachment name="unitAttachment" attachTo="submarine"  javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
  ...
  <option name="firingGroup" value="subs" />
  ...
</attachment>

<attachment name="unitAttachment" attachTo="fighter"  javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
  ...
  <option name="firingGroup" value="air" />
  ...
</attachment>

<attachment name="unitAttachment" attachTo="divebomber"  javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
  ...
  <option name="typeAA" value="dive bombing" />
  <option name="firingGroupAA" value="divebombers" />
  ...
</attachment>

Thoughts?