Oztea 1939 Global

beelee

Thought I had one for this but I was wrong. Do now lol

At any rate, I have a trigger placement problem. When the below trigger activates, all of the triggers place whether their conditions are met or not. So if only one neutral Destroyer present, it will remove the DD correctly but then place all the other naval units as well instead of just the DD.

It's kind of involved but here is some of the xml

Here are the conditions:

Here's one of the above conditions:

Here's the entire xml:
Oztea_1939_Global xml 1.97.zip

Originally discussed here but thought I might as well give it it's own zone:

https://forums.triplea-game.org/topic/1697/trigger-question/13?_=1613495624437

Any help is appreciated.
Thanks

wc_sumpton

@beelee

The activateTrigger is not testing conditions. In the called trigger there is 'conditionAttachment_False' (always false condition), so adding any other conditions there will not make a different. The always false condition should be removed and the activateTrigger shoud be:'1:true:true:true:false' to test for the conditions.

Cheers...

beelee

@wc_sumpton right on thanks. I'll give it a go

beelee

@wc_sumpton Right on that worked. Sadly I'm still struggling. I have the trigger firing twice. I need to add another condition. A "switch" somehow to the trigger but just can't figure it out.

This will fire as well:

I need the first one not to fire. I've come close, but it's just beyond me for some reason. Here's what I currently have. German player changed only so far.

oztea 1939 1.962.zip

beelee

well I tried this:

and this:

with false and true being changed but still no joy. I'll take another break and try again. Pretty sure it's simple. Kinda like me lol

wc_sumpton

@beelee

To me it reads as if all the triggers are firing at the same time:

   <option name="when" value="before:germansPlace"/>

It may be better to split them up to insure the order in which the fire:

<attachment name="conditionAttachment_VichyFleetCanTurnSwitch" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
   <option name="switch" value="false"/>
</attachment>

Now use one trigger to change the switch

<attachment name="triggerAttachment_ChangeVichyFleetCanTurnSwitch" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
   <option name="conditions" value="conditionAttachment_AlwaysFalseCondition"/>
   <option name="playerAttachmentName" value="RulesAttachment" count="conditionAttachment_VichyFleetCanTurnSwitch"/>
   <option name="playerProperty" value="switch" count="false"/>
   <!-- To insure it only gets used once -->
   <option name="uses" value="1"/>
</attachment>

Then have each player call this switch if they pass their chance, but do it after their Noncombat Movement. With the switch set have the placement/remove triggers check this switch along with the rest of the conditions. These triggers can be fired before placement. Don't forget to reset the switch after its use.

Hopefully by splitting the actions it will be easier to understand what is happening and when.

Cheers...

wc_sumpton

Hay @beelee

Here another idea that may work. Combine the switch change and chance triggers into one trigger.
You will still need the switch and the always false conditions, but change the chance call like:

<attachment name="triggerAttachment_ChangeVichyFleetCanTurnSwitch" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
   <!-- Change the conditions -->
   <option name="conditions" value="conditionAttachment_Germany_Occupies_Southern_France:Vichy_active:conditionAttachment_Fleet_Can_Turn_Axis"/>
   <!-- Add the chance -->
   <option name="chance" value="3:6"/>
   <option name="playerAttachmentName" value="RulesAttachment" count="conditionAttachment_VichyFleetCanTurnSwitch"/>
   <option name="playerProperty" value="switch" count="true"/>
   <!-- Going to add all the players that can take the fleet -->
   <option name="players" value="Germans:Italians"/>
   <!-- When for each player -->
   <option name="when" value="after:germansNonCombatMove"/>
   <option name="when" value="after:italiansNonCombatMove"/>
   <!-- To insure it only gets used once -->
   <option name="uses" value="1"/>
</attachment>

Note no activateTrigger calls, the switch is use to enable the other triggers:

<attachment name="triggerAttachment_Germany_Occupies_Southern_France_Fleet_Germany_CA2Place" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
   <!-- Add switch to conditions -->
   <option name="conditions" value="conditionAttachment_Axis_Occupies_Southern_France:conditionAttachment_Fleet_Can_Turn_Free_Cruiser2:conditionAttachment_VichyFleetCanTurnSwitch"/>
   <option name="placement" value="93 Sea Zone:cruiser"/>
   <option name="when" value="before:germansPlace"/>
   <option name="uses" value="1"/>
   <option name="activateTrigger" value="triggerAttachment_Fleet_Can_Turn_Germany_Cruiser_Remove:1:true:true:false:false"/>
</attachment>

And then the trigger to reset the switch:

<attachment name="triggerAttachment_VichyFleetCanTurnSwitchBack" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
   <!-- Check to see if switch is true -->
   <option name="conditions" value="conditionAttachment_VichyFleetCanTurnSwitch"/>
   <option name="playerAttachmentName" value="RulesAttachment" count="conditionAttachment_VichyFleetCanTurnSwitch"/>
   <option name="playerProperty" value="switch" count="false"/>
   <!-- Player, when and uses -->
   <option name="players" value="Germans:Italians"/>
   <option name="when" value="after:germansPlace"/>
   <option name="when" value="after:italiansPlace"/>
   <option name="uses" value="1"/>
</attachment>

Cheers...

beelee

@wc_sumpton right on thanks again. I'll give it a go