How do I change the Australian Convoy to a British Convoy in the Original Pacific?

[kwaspek104]

This convoy center is incorrectly labeled as "Australian" in the Pacific module.


But in the actual game, it's the same as the one in Sea Zone 52 & 49, shown here.


Any tips on how to change it?

[kwaspek104]

for some reason the pics didn't work (but hey, at least it posted now!)

beelee1 responded here, I'll let you know if it works!

https://github.com/triplea-game/triplea/issues/12927

kwaspek104 created this issue in triplea-game/triplea

closed Convoy Center labelled incorrectly in the Original Pacific #12927

[beelee]

@kwaspek104

Right arm ! I'm seeing pictures. I think maybe you need 10 posts before you can post them, or something, I can't remember. I think upvotes for your posts help for when you're new also.

Anti spam thingy. Idk, maybe it changed or was never that way lol

[beelee]

@kwaspek104

hmm ... so you want "Austrailians" changed to "Solomon" ?

If so, I don't remember how to actually do that. We'll call in the Big Gun @wc_sumpton

[kwaspek104]

No, I already fixed it. It should just be British, like the other two Convoy Centers. In the board game you get to choose how much money goes to India and how much goes to Australia.

But 99% of the time you give it to India or else it will die lol. So that's how it was with the other two convoy centers. But for whatever reason Sea Zone 15 convoy was set to Australia, so it ALWAYS gave it to Australia, which was annoying because you had to go to edit mode to fix it.

Now I need to figure out how to upload my updated file onto Github lol...

[beelee]

@kwaspek104

heh heh right arm.

So i think @RogerCooper is in charge of "Pacific" idk. But he should chime in since we pinged him and let you know.

Edit
What you can do is, fork the repo and make a PR to it with your update and whoever's in charge can then add it

[kwaspek104]

yeah I think somebody needs to give me access lol

i would upload a picture, but TripleA is not allowing me again lol.

Github says

"Uploads are disabled.

File uploads require push access to this repository."

[beelee]

@kwaspek104

ok well I'd just wait for Roger to reply then. He's on here almost daily, so won't be long

[kwaspek104]

thank you for all the help

[beelee]

@beelee said in How do I change the Australian Convoy to a British Convoy in the Original Pacific?:

He's on her almost daily, so won't be long

Oh !!! That doesn't sound right

fixed

[kwaspek104]

That sounds like a lovely, healthy relationship!

[RogerCooper]

@kwaspek104 I will check this out over the weekend

[RogerCooper]

@rogercooper What is the exact github folder you want to change? You should be able to make the changes at https://github.com/triplea-maps and then I can approve them.

[VictoryFirst]

@rogercooper

Hi Roger Cooper. I have also made some improvements to several TripleA modules. Can I upload these to the TripleA GitHub too? Who do I need to ask permission for, and what should I do if those people aren't around anymore? Here is an overview:

Original Module: World War I 1914
Upgraded modules: World War I 1914 Improved, World War I 1914 Tournament, World War I 1914 Balanced

Original Module: Europe - Beta
Upgraded Module: Europe Improved

Original Module: D-Day 2
Upgraded Module: D-Day 2 Improved
(Note: this one isn't completely finished yet)

I added "Improved" to the modules so that the name is different from the original but perhaps it is possible that the improved modules replace the original ones?

Thanks in advance. I have no idea how to do this so I am jumping into this conversation here, lol

[beelee]

@victoryfirst

I forget the actual process, but go to the repo and fork it, and then add your change and it should allow you to then make a pull request to the original repo.

I would ping Roger when you do, so he'll be notified. He's in charge of a lot maps but some will have been abandoned. I think he can help with those too though.

[RogerCooper]

@victoryfirst Are your improvements minor error fixes or signficant changes. If you are making significant changes you should make a new XML or even new Github folder.

[VictoryFirst]

@rogercooper I think I would classify them as significant changes as in each module I have added a lot of stuff to make the majority of the game features automated, such as large numbers of conditions and triggers, user action phases, extra nations to manage stuff more easily, bunch of changes to the properties, etc.

[RogerCooper]

@victoryfirst I would suggest making a separate folder.

[kwaspek104]

@RogerCooper https://github.com/triplea-maps/pacific

[RogerCooper]

@kwaspek104 said in How do I change the Australian Convoy to a British Convoy in the Original Pacific?:

@RogerCooper https://github.com/triplea-maps/pacific

Is this the mod that you want to update?

- mapName: Pacific
  mapCategory: EXPERIMENTAL
  url: https://github.com/triplea-maps/pacific/archive/master.zip
  version: 4
  img: https://raw.githubusercontent.com/triplea-maps/pacific/master/preview.png
  description: |
    <br>
    <br>WW2 Pacific (WW2 Revised era)
    <br>
    <br>Created by Triplelk and ComradeKev
    <br>TripleA adaption of WW2 Pacific (from the WW2 Revised era). Alpha stage.
    <br>