endTurnNoPU discrepancy - Resolved -

Mahks

POS2 has the following:

If as stated elsewhere:
"It is very important that the "name" ends with the correct phrase, or else the game will not work properly."

Should this example not be:
<step name="chineseEndTurnNoPU" delegate="endTurnNoPU" player="Chinese">

Could a developer confirm that the name must be formatted as stated?
I wonder why that would be when you have the delegate attribute in the step.

EDIT:
Found another: The step name '...AirborneCombatMove' does not match the delegate name 'specialCombatMove'
This leads me to believe that the step name may not be used in the engine, the delegate name is the important attribute.

Mahks

Did some testing.

"It is very important that the "name" ends with the correct phrase, or else the game will not work properly."
Seems to be true, the prefix can be anything as long as each occurrence of that step type is unique (so empire names are a good option)

So the above discrepancies are not due to my theory.

General_Zod

@mahks

Safest way is to just add prefixes to POS2 step names, since we know some have hardcoded requirements for step names.

But custom step names will function if you know exactly what needs to be added/removed in form of step properties.

Also some of the xml coding and notes are simply inconsistent, thus why I mentioned previously, copying all POS2 data and adding new notes, rather than replacing POS2 notes, would both assure nothing important lost to rewrites and less work for you. Although it would be contrary to being concise.

Mahks

This step section is the worst part I have found so far.
I think it has been added to and bandaided many times.

I've been having a hard time untangling it.
It should be one of the simplest sections, just laying out the sequence of steps and options within.

<sequence>
   	<step delegate="initDelegate" maxRunCount="1"/>
   	<turn player="Russians">
   		<step number="1" delegate="tech"/>
   		<step number="2" delegate="purchase"/>
   		<step number="3" delegate="politics"/>
   		<step number="4" delegate="move" combatMove="true" nonCombatMove="false" skipPosting="true"/>
   		<step number="5" delegate="battle"/>
   		<step number="6" delegate="move" combatMove="false" nonCombatMove="true" display="Non Combat Move"/>
   		<step number="7" delegate="place"/>
   		<step number="8" delegate="tech_activation"/>
   		<step number="9" delegate="endTurn"/>
   	</turn>
   	<turn player="Germans">...</turn>
   	...
   	<step delegate="endRound"/>
</sequence>

1039