"Units Cannot Fight" prompt

[General_Zod]

I get this prompt pop up when I click done for combat move phase.

"Units cannot fight"

The units I am sending are replicating how my depth charges will function.

attack=0, defense=0, movement=1, first strike=3, isSuicide

I want them to attack with first strike instead of the normal value so I can set them to only attack submarines. The isSuicide is there because I want them to die automatically after 1 combat round.

The unit has an offensive capability, but this behavior is ignoring the first strike (aashot) ability.

It seems that this engine behavior is carried over from before first strikes (aahot) could be used offensively. I wanted to confirm here before I post a bug report in GitHub.

[redrum]

@general_zod You are probably right though I haven't personally seen this before. A save game would be helpful so I can easily reproduce and then test any fixes. Otherwise I gotta try hacking up a similar unit into a map.

[redrum]

@general_zod PR that should fix that behavior: https://github.com/triplea-game/triplea/pull/3402

[General_Zod]

@redrum

Here is a save ready to give the prompt by clicking done for the combat move phase.

The British.Cruisers are stand-ins for the depth charges in this xml. Note the xml in this save is just for testing so ignore any other strange stuff.

0_1524680092127_bw3_units.cannot.fight_04.25.2018.tsvg

Here is a link for the game if you don't already have the files.

https://www.sendspace.com/file/7hf2d2

Note this earlier functional version is not fully completed, and I never completed the tech model and tech balance. I am moving to a improved map with underwater sea zones and more territories for the version currently on drawing board.

[redrum]

@general_zod Cool, just tested before the change to see the prompt and then after the change I no longer see it. So once that PR is merged you should be able to test it with the latest pre-release.