@CrazyG
Just downloaded the latest here are some thoughts:
- Remove all the <stepProperty>'s from the combatMovement and noncombatMovement, leaving only the giveBonusMovement=true in noncombatMovement
- Change the conditionAttachmentAlways to switch=true
- Change the turns conditions into one condition with a rounds=1:3:5:etc
- Add a condition for 'Tech Development' and add this condition into the turns condition
<attachment name="conditionAttachmentTechDevelopment" attachTo="France" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="gameProperty" value="Tech Development"/>
</attachment>
<attachment name="conditionAttachmentAlways" attachTo="France" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="switch" value="true"/>
</attachment>
<attachment name="conditionAttachmentGiveTechTokens" attachTo="France" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
<option name="conditions" value="conditionAttachmentTechDevelopment"/>
<option name="rounds" value="1:3:5:7:9:11:13:15:17"/>
</attachment>
- Now the techTokens triggers can be reduced to 1 trigger:
<attachment name="triggerAttachmentGiveTechTokens" attachTo="France" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
<option name="conditions" value="conditionAttachmentGiveTechTokens"/>
<option name="when" value="before:FranceTech"/>
<option name="players" value="France:Habsburg_Monarchy:Ottoman_Empire:Poland-Lithuania:Russia:Denmark:Sweden"/>
<option name="resource" value="techTokens"/>
<option name="resourceCount" value="12"/>
</attachment>
- Remove the resource of 12 techTokens given during initialization.
Making this change will allow the player to turn off Tech by deselecting 'Tech Development' and not receive any techTokens.
- Change the Activate Bonus Movement triggers to 'when=before:xxxNonCombatMove' (I tend to 'when' my triggers to the step they effect.)
- Already talked about the restore movement trigger.
- I would also change the remove RecruitPikemen to a single trigger.
<attachment name="triggerAttachmentFranceRemoveRecruits" attachTo="France" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
<option name="conditions" value="conditionAttachmentAlways"/>
<option name="removeUnits" value="all:RecruitPikemen"/>
<option name="players" value="France:Habsburg_Monarchy:Ottoman_Empire:Poland-Lithuania:Russia:Denmark:Sweden"/>
<option name="when" value="after:FranceEndTurn"/>
<option name="when" value="after:Habsburg_MonarchyEndTurn"/>
<option name="when" value="after:Ottoman_EmpireEndTurn"/>
<option name="when" value="after:Italian_StatesEndTurn"/>
<option name="when" value="after:Poland-LithuaniaEndTurn"/>
<option name="when" value="after:RussiaEndTurn"/>
<option name="when" value="after:DenmarkEndTurn"/>
<option name="when" value="after:SwedenEndTurn"/>
</attachment>
- In the <property>'s I would only show Low Luck, Tech Development, and Unplaced units live when not placed. (And maybe think about adding a bid section)
Game play seems to be moving along real good. The bonus movement problem is solved and the other Techs seem to work as they should. The tool tips even update to reflect the added bonuses. Maybe @Hepps could design a simple overlay to display the bonuses when they are in effect.
These are just some food for thought. The only big fix would need to be the 'Bonus Movement Triggers', then the map seems very playable with your new Techs
Cheers...