European War
-
Thank you beelee. How close is the map to becoming downloadable? Also I have to delete the older european war fodder from Github. But I don't know how do I delete it.
-
@schulz there are a couple things I need to change. I'll give it another go
-
@Schulz ok man things are looking good. Our PR passed all it's checks, so unless I'm misunderstanding something, it just needs one of the "Big Guns" to load it up.
Made you an "Owner" so you can make changes in the future. Should be a little easier to get used to git that way
To delete a repo go to the repo you wanna delete and click on settings. It'll be top right. Scroll all the way down and you'll see the delete button. You can only delete stuff in your profile not the main map one.
-
Well it is downladable. Thank you so much. BTW there are 2 flaws which prevent to start the game. The folder's name and mapName from the xml should be european_war
-
@schulz yea looks as if I boned the name in the yaml. Pretty sure this will correct it and the name will still show up as "European War" when you DL it.
Go to the maps yamel:
click on the pencil icon. Top right next to History. Scroll to the bottom. This is a little hard. Scroll part way then sroll on the other bar part way untill you get there.
Add Schultz to the map name. So just click on the E in "European War" add "Schultz" and one space and you should be good. (Everything has to be just right or it won't work)
at the bottom in the big box type "correcting map name" or w/e. Below that click on "Proposed file change"
Then you'll see your change. Old in pink new in green. Click on "Create Pull Request" and add another comment explaining what you did if it asks for one.
Then you should be good to go. Go to the main git page:
link text and you can see if your PR showed up. Itll take a few minutes to do it's thing and then should say "checks passed" or w/e.
So the map should still show as "European War" At least that's what it does in local mode for me. The only difference is my zip has "Schultz" in it and the one I DL just has "European War"
Anyway if that doesn't work, post back and we'll try something else.
Just thought of something else. You'll probably need to change the version number to 2. I would just go ahead and do it. It's just a couple lines below map name. Doesn't have anything to do with your map version"0.6" or w/e it is. I think it just allows git to keep track of any changes to the yaml.
-
I have made the pull request.
I don't know does my mod have anything from version 0.6. I can change version to 2 from 0.6 by editing the xml. Is editing the xml enoght or need something more?
-
@Schulz, @beelee
Just downloaded.
I remember a while back that someone suggested that this map use the baseTiles from HoH, but with out the centers, place, and polygons files, this map becomes very hard to look at. I would think about updating those 3 files to smooth out those borders. It is very hard to look at.Cheers...
-
@schulz yea your map version"0.6" doesn't have anything to do with changing the yaml version to 2. So you don't need to change the xml. Every time you update the yaml you have to bump the version number.
Hmm... just checked your PR and it said one check didn't pass. Checked details and all I get is a pink unicorn saying to try again.
Anyway, sometimes it'll say something's wrong and it doesn't matter. When I can get back on I'll check your changes
-
@Schulz @wc_sumpton can you guys get on Git ?
-
@beelee ok back on. @Schulz you need to bump the version number to 2. It's still on 1. Go ahead and close this PR and try it again. We'll get it : )
-
@wc_sumpton said in European War:
@Schulz, @beelee
Just downloaded.
I remember a while back that someone suggested that this map use the baseTiles from HoH, but with out the centers, place, and polygons files, this map becomes very hard to look at. I would think about updating those 3 files to smooth out those borders. It is very hard to look at.Cheers...
Yes, graphics are bad because I was unaware Habsburg Empire map when I working on European war. But it is so easy to fix it. Just click view then click to show map blends. It will be seen significantly better.
-
@beelee
Ok. I have changed the version to 2. -
@schulz right on hey cool dan van atta says it looks good.
You can close your first PR don't close this one until it's mergedOH OH you forgot to add the "Schultz"
I know there's a way to adjust your PR just don't know how. Maybe tell Dan what happened over at git and try again. Third time's the charm -
@schulz go to version 3 just to be safe when you add Schultz
-
Should I change the map name to Schultz European War and the version to 3 at the same time. Or should I edit them separately?
-
@schulz no just change the map name in the yaml and the version don't change anything in the xml. I'll post a screen shot in a minute
-
@schulz just like this:
-
@schulz also when you get done and are waiting for the merge you can go into your down loaded maps folder in triplea and rename the european_war zip with schultz_ in front of it and it should work.
Looks good. Go ahead and delete your first two PRs
-
@Schulz Yea ! All checks have passed ! Should be dialed in now : )
-
@Schulz well it works but it DLs under Schultz European War and shows up as European War. This might be confusing. I'll set it up with no Schultz in the name and try it again. Unless you want to try it and I'll help you through it. I'm not real familiar with the whole process either, so it'll be a bit of struggle.
Let me know what you want to do.
Probably need a new image with the map blends on for the description. I'll let you do that one as it's pretty easy and will help you get more familiar with git.
