Victory Trigger Not Working

RogerCooper

I am trying to get victory to occur by surviving to a specific turn. (I set this to turn 1 for testing). Nothing is happening (other triggers are working). I attached the entire xml as well. Does anyone see what I did wrong?

    <attachment name="conditionAttachmentGermansSurvival" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
      <option name="rounds" value="1"/>
      <option name="alliedOwnershipTerritories" value="Caen:St. Lo:Cherbourg" count="1"/>
    </attachment>
    <attachment name="triggerAttachmentAxisVictory" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
      <option name="conditions" value="conditionAttachmentGermansSurvival"/>
      <option name="victory" value="German Survival Victory"/>
      <option name="players" value="Germans"/>
    	<option name="when" value="before:germanCombatMove"/>
    </attachment>
[D-Day_3.xml](/assets/uploads/files/1552779622824-d-day_3.xml) ```

redrum

@RogerCooper I don't think your attachment uploaded.

RogerCooper

@redrum D-Day_3.xml

redrum

@RogerCooper The victory value needs to be a key for the notifications.properties file not the actual string you want to display. Here is the POS2 XML:

victory	   values: the string message from notifications.properties to be displayed if the condition is true. victory can be used to play sounds as well. victory will use victory value + "_sounds" as the key in notifications.properties file, and then will use "defeat_" or "victory_" + the notifications.properties value as the new key to look for in the sounds.properties file.