costPU not working in politicalActionAttachment
-
When running any scenario with the option "costPU" used in politicalActionAttachment, I receive the error "Missing property definition". This happens for example in Pact of Steel 2.
-
@RogerCooper it was replaced with costResources.
-
@redrum Yeah, I was about answering that. The problem is that I believe no one so far made a full list of changes to upgrade from 1.9.0.0.3266 to 2.0 (or maybe better just consolidate in a single list from 1.8.0.9 to 2.0), that is not a problem at all normally, but it may be either for people like @RogerCooper or people that made an unfinished map time ago and may want to retake it in the future, or anyways whatever it is old and not in the TripleA repository.
https://github.com/triplea-game/triplea/wiki/Upgrade-Maps-Information@RogerCooper You need to search for all maps having "costPU" in their games files (usually xml) and make the following mass changes (old:new):
option name="costPU" value=":option name="costResources" value="PUs" count="option name="playerProperty" value="costPU" count="(.*?)":option name="playerProperty" value="costResources" count="$1:PUs"The second one uses regular expressions (you will need to search with an editor supporting that and having the function enabled), but it is actually needed only for games that change the "costPU" option with triggers; so there's a good chance you don't have any cases.
Reference:
https://github.com/triplea-game/triplea/issues/3475 -
Pact of Steel 2 in the repository needs to be updated.
-
@RogerCooper I believe it is already updated: https://github.com/triplea-maps/the_pact_of_steel/blob/master/map/games/pact_of_steel_2.xml#L4073
Did I miss something?
-
@redrum I deleted the file on my computer and downloaded it again. That fixed it.
-
@redrum This would rise the question, when something is added, maybe just a rewording, to pos (the map), for purely mapmaking purposes, should the download version updated, prompting all users to overwrite it, even if that is actually totally pointless for regular users, as the game or the map didn't change at all (just updating the mapmaking guide within it)? And should the pos2 game version be increased if the file change is merely on the mapmaking guide part?
-
Personally, my solution would be having the_pact_of_steel as the default and preinstalled TripleA game (practically going back to the times when having another map folder in the installation, but this time only for the_pact_of_steel, and likely the tutorial too). In this case, I would have TripleA defaulting to Pact of Steel (instead of to the first game in alphabetical order, as it works now).
-
@Cernel said in costPU not working in politicalActionAttachment:
@redrum This would rise the question, when something is added, maybe just a rewording, to pos (the map), for purely mapmaking purposes, should the download version updated, prompting all users to overwrite it, even if that is actually totally pointless for regular users, as the game or the map didn't change at all (just updating the mapmaking guide within it)? And should the pos2 game version be increased if the file change is merely on the mapmaking guide part?
The map did not work at all, it was not just incomplete documentation. But yes, changes in properties should result in updates in POS2 even if the scenario is not directly affected.
