Add new canal option to not allow movement through during combat move

[redrum]

Overview

• Add new canal option: canNotMoveThroughDuringCombatMove

Functional Changes

• New canal option allows canals to only be moved through during non-combat move which can be very useful for simulating these types of connections take more time to pass through. Here is an XML example:

        <attachment name="canalAttachmentPanama" attachTo="SZ1" javaClass="CanalAttachment" type="territory">
            <option name="canalName" value="Panama Canal"/>
            <option name="landTerritories" value="Panama"/>
            <option name="canNotMoveThroughDuringCombatMove" value="true"/>
        </attachment>
        <attachment name="canalAttachmentPanama" attachTo="SZ2" javaClass="CanalAttachment" type="territory">
            <option name="canalName" value="Panama Canal"/>
            <option name="landTerritories" value="Panama"/>
            <option name="canNotMoveThroughDuringCombatMove" value="true"/>
        </attachment>

[redrum]

PR: https://github.com/triplea-game/triplea/pull/4816

ron-murhammer created this issue in triplea-game/triplea

closed Add new canal option canNotMoveThroughDuringCombatMove #4816