[Fixed] Domination 1914 No Mans Land fails to start


  • Moderators


  • Moderators

    @redrum You have changed the map name from "domination_1914_no_mans_land" to "domination_1914_no_man's_land".

    Not sure if that is even intentional, but, beside the fact that now people can end up with both such maps' folders coexisting inside their downloadedMaps folder, I see that the current one has the old folder name inside the primary one, meaning the full path currently is:

    domination_1914_no_man's_land-master/domination_1914_no_mans_land-master/map/games/Domination_1914_No_Mans_Land.xml

    And inside that xml the referenced map/folder is "mapName" value="domination_1914_no_mans_land".

    So, this should cause the game to fail to be loaded, for new users, in the moment the current download is named "domination_1914_no_man's_land" primarily. I've tested it by removing all such maps, and downloading it, and it indeed fails.

    So better fixing this soon, otherwise the old players will just load the old original skin, while the new players will be unable to load any skins, and both will end up with this "domination_1914_no_man's_land" folder, that would, then, I guess need to be manually removed (and most users are not going to easily do that).

    p.s.: Generally speaking, I really don't understand why do we have this thing of the double master folder. Is it not possible having it only once, directly followed by just the "map" subfolder (plus the other items at that point), removing what appears to be a pointless and confusing container in between (that looks like can be even inconsistently named)?


  • Admin

    @Cernel It was unintentional. I didn't realize that the map name in the yaml file was then used for the folder name. I thought it was pulled from the actual map repo. I reverted it and tested that the new download works.


  • Moderators

    @redrum Ok, would it be possible to wholly change the system as having the single master folder (named as per the repository name) immediately followed by the map folder, avoiding this confusing double foldering? You see in the moment even you can get it wrong, this doesn't seem a very clear system, for an open project like this.

    On the map, the flag for Arabia is wrong. Beside the red triangle on the hoist side, from top down, it should be black, green, white, not the current black, white, green.
    https://en.wikipedia.org/wiki/Flag_of_the_Arab_Revolt

    By the way, I agree with this thing of using the actual country flags, instead of the roundels and such. I wish this would be the practice for WW2 too, but I know this is sadly not possible because the swastika is forbidden.


  • Admin

    @Cernel Probably possible but it would then most likely cause needing to redownload/duplicate maps so probably not worth it.

    Ah, I see. Well if someone wants to post corrected Arabia flag images then I'd be glad to replace them.


  • Moderators

    @redrum Well, as long as the primary folder is named the same way, the new ones would not possibly coexist on the same system. For a time, it will be necessary to support both path types, of course, but in the long run I think this practice of having double "master" folders looks really strange, and makes for some massive paths, down the the actual xml.

    Meaning what I would suggest is having:

    domination_1914_no_mans_land-master/map/games/Domination_1914_No_Mans_Land.xml

    instead of current:

    domination_1914_no_mans_land-master/domination_1914_no_mans_land-master/map/games/Domination_1914_No_Mans_Land.xml

    Since they are both "domination_1914_no_mans_land-master", there is certainly no risk of duplication, unless some had inconsistent naming between the two, and that is another problem of the current way, actually.


  • Admin

    @Cernel Right. Which I'm sure inconsistent naming exists. I agree that would seem better and I'm not sure why the double folder was done. Either way we are getting off topic and better to open a separate thread if you want to discuss it further.


  • Moderators

    @redrum said in Domination 1914 No Mans Land fails to start [FIXED]:

    @Cernel Right. Which I'm sure inconsistent naming exists. I agree that would seem better and I'm not sure why the double folder was done. Either way we are getting off topic and better to open a separate thread if you want to discuss it further.

    Moved this and all posts above, except the first one, in this new thread in Bug Reports, for this issue and follow up.


  • Moderators

    @redrum said in Domination 1914 No Mans Land fails to start [FIXED]:

    @Cernel Right. Which I'm sure inconsistent naming exists. I agree that would seem better and I'm not sure why the double folder was done. Either way we are getting off topic and better to open a separate thread if you want to discuss it further.

    Since we have verified that at least the file name in main folder must be the same as the "mapName" in the xml, that should be right for all old maps (otherwise they would not have started in the past) and also right for all or most new maps, as otherwise the mapmaker would have failed testing his own map before getting it to download list. So, I don't think there is anything to worry about this, as currently either a map has the same main folder name as the one spelled in the xml of the games themselves (they can be more than one per map), or it is already not working anyways.

    Inconsistent naming should really not exist, since in the first folder (from the download list naming) it would currently cause the map to fail to start and in the second folder it would have already done that when the mapmaker was testing it (likely in its simplest and unzipped format), before getting it to download list.

    So, I think it would be better at least picking one of download list and repository names (I'd definitely say the repository name), instead of, as I understand it, the current process of having first download list name, then repository name, then the actual "map" folder, that I don't think anybody is going to dream it's working this way, or at least this thing should be documented somewhere, that the mapmakers must be sure to have both equal to the xml "mapName", or issues like this one I'm pretty sure will keep happening overtime, and they are a bit problematic, especially since they would leave wrongly named maps inside users' folders, still adding games to that users' selection lists (either calling another folder or failing to find any, like it was the case here, depending whether you already downloaded this map in the past or not), that most users will fail to get around tracking and deleting manually, since they are not going to be overwritten by the correctly named ones (once available).


Log in to reply