Missing Image Trouble

Cernel

Ok I've put this:
https://github.com/beelee1/oztea_1939_global/archive/master.zip
into my downloadedMaps folder.

Just starting the game, the only missing image I get is:
MISSING IMAGE (this unit or image will be invisible): UnitType{name=American_infantry}

Taking a look at the xml, you have a series of entries, in "unitInitialize", where "American_infantry" is owned by "Russians", "Dutch" and "Mongolians", none of these players having the required image in their units subfolders. This is why you are getting those errors and not seeing those units.

At the developers, I suggest reworking the "Missing Image" error as also to tell the owner of the missing unit. I recall this warning was introduced by @LaFayette.

beelee

@Cernel Right on ! Thanks man ! Yea Idk what happened when I was adding the separate production Frontiers and the new units but the unitInialize was all whacked out and like doubled itself. I got all that sorted but never thought to look close enough at the owners.

Thanks again everyone

redrum

@Cernel Like this?

Cernel

@redrum Yeah, that seems ok. I would write it this way, though, also adding the zone, if this thing was meant to make the game somewhat playable anyways (before, the game just crashed, with any missing images):

MISSING UNIT IMAGE (this unit is not displayed): American_infantry (owner: Russians; zone: Rostov)

Mostly the question here is how it works. If it still takes a placement spot, but you see nothing, like if you would have a blank image, I would say "not visible". If it is not drawn at all on the board, I would say "not displayed".

Looking at the current warning, I guess it works also for missing images that are not units? I mean also something else than "UnitType"? If so, I guess those will need to be reworded, if we want to be specific here.

This would be the current format; not sure why it is worded this way:

MISSING IMAGE (this unit or image will be invisible): UnitType{name=American_infantry}

It makes me think there is a series of other instances of this warning that are not "UnitType". Is this so?

redrum

@Cernel Ah, good idea on location:

Cernel

@redrum If I recall correctly (not sure), correct English doesn't officially allow missing the subject; so it should be "it won't be displayed". If the rest is in that format, I would put the specific elements within quotation marks.

Meaning:

MISSING UNIT IMAGE (it won't be displayed): "American_infantry" owned by "Russians" in "Timguska".

Not sure if the whole thing should have a full stop at the end or just no terminal punctuation at all.

redrum

Good enough. Here is the PR: https://github.com/triplea-game/triplea/pull/4922

Cernel

Should this topic be moved to feature requests, at this point?

RoiEX

@Cernel nah, I think we should be fine

beelee

Well I can take consolation in the fact that my stupidity actually had a beneficial side effect this time :face_with_tears_of_joy: :face_with_tears_of_joy: :face_with_tears_of_joy: