Missing Image Trouble

redrum

@Cernel Like this?

Cernel

@redrum Yeah, that seems ok. I would write it this way, though, also adding the zone, if this thing was meant to make the game somewhat playable anyways (before, the game just crashed, with any missing images):

MISSING UNIT IMAGE (this unit is not displayed): American_infantry (owner: Russians; zone: Rostov)

Mostly the question here is how it works. If it still takes a placement spot, but you see nothing, like if you would have a blank image, I would say "not visible". If it is not drawn at all on the board, I would say "not displayed".

Looking at the current warning, I guess it works also for missing images that are not units? I mean also something else than "UnitType"? If so, I guess those will need to be reworded, if we want to be specific here.

This would be the current format; not sure why it is worded this way:

MISSING IMAGE (this unit or image will be invisible): UnitType{name=American_infantry}

It makes me think there is a series of other instances of this warning that are not "UnitType". Is this so?

redrum

@Cernel Ah, good idea on location:

Cernel

@redrum If I recall correctly (not sure), correct English doesn't officially allow missing the subject; so it should be "it won't be displayed". If the rest is in that format, I would put the specific elements within quotation marks.

Meaning:

MISSING UNIT IMAGE (it won't be displayed): "American_infantry" owned by "Russians" in "Timguska".

Not sure if the whole thing should have a full stop at the end or just no terminal punctuation at all.

redrum

Good enough. Here is the PR: https://github.com/triplea-game/triplea/pull/4922

ron-murhammer created this issue in triplea-game/triplea

closed Improve missing unit image message #4922

Cernel

Should this topic be moved to feature requests, at this point?

RoiEX

@Cernel nah, I think we should be fine

beelee

Well I can take consolation in the fact that my stupidity actually had a beneficial side effect this time