Fixed Game of Thrones Map Bug

wc_sumpton

@redrum thanks for the update. @Cernel, yes it has been quite some time since I looked at the xml. Am not quite sure how far I was able to get. If @Johnnyboy wants this map them I am quite happy to let him have it.

Cheers...

redrum

Alright, I just cleaned up @wc_sumpton updates and released a v2.0.

wc_sumpton

@redrum Thank you. Sorry for leaving such a mess.

Cheers...

redrum

@wc_sumpton All good. You did most of the work. I just fixed a few small errors and cleaned up the notes a bit more.

Cernel

@redrum Since the game is currently not balanced, or owned, or anything like that, could I just get a push merged to simply cut by half all territories productions, rounded up, to make it more playable? Asking here if that would be accepted or not, because there would be no playtesting, or commitment or anything regarding it, just simply what I said (tho I would probably try to play it with somebody, thereafter, but that's it).

@wc_sumpton Can you make a complete list of all the things that you wished to do on this map and didn't? Asking not much for myself, but for anyone who might want to take over this, and maybe finish your project.

I think I'll make a search in the two forums and GitHub for anything reported on this game, and see if the issue is still there in the current version.

redrum

@Cernel I'd prefer not to make drastic changes without considering how the map already plays. I also don't know that there are a ton of people that share your preference for lower production and unit counts.

It would be good to get a list of recommended changes or any remaining bugs. If they are minor, I don't mind making them.

Cernel

@redrum I don't recall I've ever seen anyone playing this game in the lobby or in forum since the last time I hosted it, several years ago.

redrum

@Cernel Agree. Besides a few random posts on the forums/github about issues with it, I haven't seen hardly anyone play it. What I meant was I assume whoever designed it thought some about territory values and unit costs and just cutting them in half to cut them in half isn't necessarily a good idea.

Cernel

@redrum Of course, cutting production by probably about 40% (as per rounding up) would be for reducing units accumulation overtime, especially assuming this would be played the Feudal Japan way (only other way would be finding 11 people to play with).

I also want to point out that this map suffers the v1 naval bombardment inconsistency issue. As otherwise the ruleset is currently Classic, the fact that naval bombardment behaves as Revised is likely to be unintended. I firstly reported this thing that I believe to be a bug (even tho I cannot affirm it, as I would need a reference that categorically states that the TripleA default is supposed to be Classic in all cases):
https://sourceforge.net/p/triplea/bugs/1082/

This may be one of those cases that need the fix in the xml, as per what Veqryn said:

I will change this on each xml that we find that needs it.
Unfortunately for backwards compatibility, and to avoid unintended side effects, I will not change the default behavior in the engine or rename the property.
Can you help me find all the maps that need changing, besides the ones in the Classic and Classic variations zips?

Cernel

@redrum said in Fixed Game of Thrones Map Bug:

@wc_sumpton All good. You did most of the work. I just fixed a few small errors and cleaned up the notes a bit more.

Then I guess his thread could be considered the current official one for this map?

https://forums.triplea-game.org/topic/950/game-of-thrones

redrum

@Cernel Yeah, can probably repurpose that thread to be the official one and should probably move the conversation there since this was really about fixing some of the bugs in the map.