Help: National Objectives are removed when editing name of map file

Cernel

@Jason-Green-Lowe As per
https://github.com/triplea-maps/1941balancedmod/blob/master/map/games/WW2v3-1941balmod.xml

"World War II v3 1941 Balanced Mod" is a game of the "world_war_ii_v3" map.

Therefore, the objectives to display are taken from that map, not from the "1941balancedmod" map, that is completely useless, skin wise.

If you want "World War II v3 1941 Balanced Mod" to be a game of the "1941balancedmod" map, you need to have this name as its "mapName" property value.

In my opinion, it would have been better for this game to have been part of the "ww2v3_variants" map (you just would have needed to have that as the "mapName" property value and add your objectives related coding to that map).

Jason Green-Lowe

All right. I appreciate that you have strong feelings about how this map should have been packaged, but I don't have any opinion about that, and I'm staying neutral on that topic.

What I would like to do is release my map to the public in a form that allows players to see the objectives in real-time. That's my goal. So, given my goal and the way everything is set up right now, what is the exact text string that I should use for mapName?

Should mapName be:

World_War_II_v3_1941_Balanced_Mod
1941balancedmod
something else?

Panther

@Jason-Green-Lowe

The mapName in your xml (Line 2195) at the moment is:

<property name="mapName" value="world_war_ii_v3" editable="false"/>

It should instead be

<property name="mapName" value="1941balancedmod" editable="false"/>

It must match the mapfolder-name.

Jason Green-Lowe

@Panther said in Help: National Objectives are removed when editing name of map file:

1941balancedmod

OK, that's not entirely the correct answer, because I changed the mapName to "1941balancedmod" and now the game won't load -- I get an error saying "Map missing: 1941balancedmod, could not join game. Would you like to download the map now?" And then if I try to download the map, it can't find it.

ff03k64

Don't you also need the map name on line 4 to be the same as well?

Panther

@ff03k64 No. Line 4 sets the name that appears in the "Select Map" list within TripleA, here it is

<info name="World War II v3 1941 Balanced Mod" version="1.0"/>

Panther

@Jason-Green-Lowe
Interesting. I was able to load your map after I had applied the change.
I did that locally, of course.

Panther

Jason Green-Lowe

Excellent! I'm glad it's working for you, at least.

I took your advice and edited github so that the string is "1941balancedmod" everywhere. So now that's the string I'm using for the info name, the mapName, and the repo folder name.

Unfortunately, it's still not working on my downloaded version. What was the exact change you made locally?

Panther

@Jason-Green-Lowe said in Help: National Objectives are removed when editing name of map file:

Excellent! That is exactly the intended effect. I took your advice and edited the name everywhere to be "1941balancedmod." So now that's the string I'm using for the info name, the mapName, and the repo folder name. It's a little ugly in that now it shows up as "1941balancedmod" on the select map screen, but at least it works.

Here it appears like this:

Jason Green-Lowe

Well, it appears as World War II v3 1941 Balanced Mod in the "Download Maps" dialog, but not in the "Select Maps" dialog.

Panther

Line 4 should be

<info name="World War II v3 1941 Balanced Mod" version="1.0"/>

(as it was)

and line 2195 should be

<property name="mapName" value="1941balancedmod" editable="false"/>

Panther

@Jason-Green-Lowe said in Help: National Objectives are removed when editing name of map file:

Well, it appears as World War II v3 1941 Balanced Mod in the "Download Maps" dialog, but not in the "Select Maps" dialog.

@Panther said in Help: National Objectives are removed when editing name of map file:

@Jason-Green-Lowe said in Help: National Objectives are removed when editing name of map file:

Excellent! That is exactly the intended effect. I took your advice and edited the name everywhere to be "1941balancedmod." So now that's the string I'm using for the info name, the mapName, and the repo folder name. It's a little ugly in that now it shows up as "1941balancedmod" on the select map screen, but at least it works.

Here it appears like this:

This is from my Select Map dialog.

Jason Green-Lowe

What string are you using in the objectives.properties file? My understanding is that objectives.properties has to match the info name from line 4.

Panther

@Jason-Green-Lowe I did not touch it at all.

What I did was:

I moved to your Github repo and downloaded the map-zip manually from there.
I edited line 2195 of the xml as noted above
I moved the complete zip-file into my downloadedMaps folder

That's all. Works perfectly fine.

Jason Green-Lowe

OK, that's great! I'm glad it's working. What I need to find out is whether your objectives.properties file is using "1941balancedmod" or "World_War_II_v3_1941_Balanced_Mod" as the prefix. I made that change in github just a few minutes ago, and I don't know which version you downloaded.

Panther

@Jason-Green-Lowe I downloaded the version before the changes you applied.
I assume you shouldn't have touched the objectives.properties file.

Jason Green-Lowe

OK, thanks. I'll revert the objectives.properties changes, and try it with:

Line 4 - World War II v3 1941 Balanced Mod
Line 2195 - 1941balancedmod
objectives.properties - World_War_II_v3_1941_Balanced_Mod

Panther

@Jason-Green-Lowe Yes. I think Line 2195 was the only change needed, nothing else.

Jason Green-Lowe

@Jason-Green-Lowe said in Help: National Objectives are removed when editing name of map file:

World_War_II_v3_1941_Balanced_Mod

Well, I have made exactly the changes you suggested on github, but I am still getting the "MapNotFoundException" error. For some reason, your local copy of TripleA is able to search for and find a map called "1941balancedmod" and mine is not. I do not understand what is going wrong, and I am feeling frustrated.