⭕ Lord of the Rings: War of the Ring - Official Thread

board 3659

@rogercooper yeah like the ents near Saruman were non-aligned until Saruman attacked

ff03k64

@thedog said in Lord of the Rings: War of the Ring - Official Thread:

I spent over 3 hours trying to upload a map to Github and failed. As time is precious Im happier being productive and coding/modding a new map "The Shogun" than trying and failing to upload again.
But you could try and upload the zip if you like?

If I can get this on Github, do you know how to update the file if you make any more changes?

TheDog

@ff03k64
If you can get it on Github that would be great, I will try/learn to update the files.

ff03k64

@thedog Did you change anything besides the xml?

TheDog

@ff03k64
Yes
Removed many units.
Changed PUs icon
Added Game_Notes.png
Changed all nations StandardFlag.png sizes
Maybe other things?

ff03k64

@thedog So it looks like you didn't make any new units? Just removed some? And it looks like you didn't change the map at all? Am I seeing that correctly?

So my thought is to try to add it to the download of middle earth that this is based off of, instead of it's own download.
So, first, do you care?
Second for others that are hopefully reading this, is that a good way to do this? I am not sure how the flag sizes would be affected by doing it this way. Would that make this not work?

TheDog

@ff03k64 said in Lord of the Rings: War of the Ring - Official Thread:

@thedog So it looks like you didn't make any new units? Just removed some? And it looks like you didn't change the map at all? Am I seeing that correctly?

Yes to all the above

So my thought is to try to add it to the download of middle earth that this is based off of, instead of it's own download.
So, first, do you care?

Short answer no, my thoughts are, that for a normal Modder like me, it takes too much time and effort to do a simple task, like upload and maintain a file set.

Second for others that are hopefully reading this, is that a good way to do this? I am not sure how the flag sizes would be affected by doing it this way. Would that make this not work?

The flag size will not affect the game, it will shrink the map main screen if you leave it as is. My NationFlag.png are 24x24px this is the optimum size for many reasons.

Other people please chime in with your thoughts for ff03k64.

ff03k64

@thedog I think if you download the files here it should run.?.?. https://github.com/CharlieAtlas/middle_earth/archive/master.zip

I can use that to make sure I did everything correctly before trying to put it in the official repo. It looks like there are a couple unit images missing. Do you use discord by chance?

edit: more info: did you add any units? or just remove some?

TheDog

@ff03k64
Im not sure where you got that file set from?
Here is the correct link from the first post.
https://drive.google.com/file/d/1x3tjGJsD7kt6_Cn3jei3i1UAepy6BOfi/view?usp=sharing

However Roger pointed out that the map.yml is wrong for the current version of 2.6. If you delete it thats fines as the v2.6 should generate a new and correct map.yml

Its late here in the UK, I can give you a new zip tomorrow.

Edit Im not on Discord.

ff03k64

@thedog That file is my merging of the original Middle Earth map, and your modification of it.

I asked about adding units because I think you added archers for Rohan? I don't think those are in the original, so I was wondering if you added any other units so I could add them without having to check every unit for every race.

If the zip you get from my link works, then I will merge that with the official version (once I add the missing units). That is when I will worry about the map.yml file.

edit: I think I found all the missing units now. archers for rohan, gondor, khand, and rohan, and noldor for the elves?

TheDog

@ff03k64
I now realize what your doing, thanks!

Yes, I get 4 archers and the noldor images were missing. (Your first rohan listed, I think you meant Dwarves)

So I took your zip file added the 5 images and ran both xmls without error.

RogerCooper

@thedog said in Lord of the Rings: War of the Ring - Official Thread:

However Roger pointed out that the map.yml is wrong for the current version of 2.6. If you delete it thats fines as the v2.6 should generate a new and correct map.yml

I would suggest creating the map.yml manually so you have more control. It is pretty simple. For example,

map_name: red_sun_over_china
games:
- game_name: Red Sun Over China
  file_name: Red_Sun_Over_China.xml
- game_name: Warlords FFA
  file_name: Warlords.xml
version: 0

As of now, 2.6 is still not working correctly, although some progress has been made it getting downloads to work. I am now working entirely in 2.5.

ff03k64

@rogercooper said in Lord of the Rings: War of the Ring - Official Thread:

I would suggest creating the map.yml manually so you have more control. It is pretty simple. For example,
map_name: red_sun_over_china
games:

game_name: Red Sun Over China
file_name: Red_Sun_Over_China.xml

game_name: Warlords FFA
file_name: Warlords.xml
version: 0

As of now, 2.6 is still not working correctly, although some progress has been made it getting downloads to work. I am now working entirely in 2.5.

Is this the correct format? It looks a slightly different than other maps I have glanced at.

RogerCooper

@ff03k64 They all look like that to me. You don't need to specify the path to the file name, but you should only have 1 file of that name.

ff03k64

@rogercooper They have brackets for me.

RogerCooper

@ff03k64 Interesting, none of mine have brackets.

ff03k64

@rogercooper
This is what they look like to me.

map_name: red_sun_over_china
games:
- {game_name: Warlords FFA, file_name: Warlords.xml}
- {game_name: Red Sun Over China, file_name: Red_Sun_Over_China.xml}

https://github.com/triplea-maps/red_sun_over_china/blob/master/map.yml

RogerCooper

@ff03k64 Both are valid yaml code Yaml format

TheDog

@rogercooper said in Lord of the Rings: War of the Ring - Official Thread:

@ff03k64 Interesting, none of mine have brackets.

I think that might be due to the version of 2.6, Im fairly certain that the format has changed/evolved over time.

As Roger knows when you download 2.6 for the first time and run it, it will unzip all of your maps and create a yml file if there is not one.

With 2.6 and a new map, the mapmaker will have to code their own yml file or zip it and then let 2.6 unzip it and it will create a yml file.

ff03k64

@rogercooper Would this be a change big enough to update the triplea_maps.yaml file? I assume that is still the right way to do it, even though we have the yml file now?

edit: mainly the second question