⭕ Lord of the Rings: War of the Ring - Official Thread

[ff03k64]

@thedog I think if you download the files here it should run.?.?. https://github.com/CharlieAtlas/middle_earth/archive/master.zip

I can use that to make sure I did everything correctly before trying to put it in the official repo. It looks like there are a couple unit images missing. Do you use discord by chance?

edit: more info: did you add any units? or just remove some?

[TheDog]

@ff03k64
Im not sure where you got that file set from?
Here is the correct link from the first post.
https://drive.google.com/file/d/1x3tjGJsD7kt6_Cn3jei3i1UAepy6BOfi/view?usp=sharing

However Roger pointed out that the map.yml is wrong for the current version of 2.6. If you delete it thats fines as the v2.6 should generate a new and correct map.yml

Its late here in the UK, I can give you a new zip tomorrow.

Edit Im not on Discord.

[ff03k64]

@thedog That file is my merging of the original Middle Earth map, and your modification of it.

I asked about adding units because I think you added archers for Rohan? I don't think those are in the original, so I was wondering if you added any other units so I could add them without having to check every unit for every race.

If the zip you get from my link works, then I will merge that with the official version (once I add the missing units). That is when I will worry about the map.yml file.

edit: I think I found all the missing units now. archers for rohan, gondor, khand, and rohan, and noldor for the elves?

[TheDog]

@ff03k64
I now realize what your doing, thanks!

Yes, I get 4 archers and the noldor images were missing. (Your first rohan listed, I think you meant Dwarves)

So I took your zip file added the 5 images and ran both xmls without error.

[RogerCooper]

@thedog said in Lord of the Rings: War of the Ring - Official Thread:

However Roger pointed out that the map.yml is wrong for the current version of 2.6. If you delete it thats fines as the v2.6 should generate a new and correct map.yml

I would suggest creating the map.yml manually so you have more control. It is pretty simple. For example,

map_name: red_sun_over_china
games:
- game_name: Red Sun Over China
  file_name: Red_Sun_Over_China.xml
- game_name: Warlords FFA
  file_name: Warlords.xml
version: 0

As of now, 2.6 is still not working correctly, although some progress has been made it getting downloads to work. I am now working entirely in 2.5.

[ff03k64]

@rogercooper said in Lord of the Rings: War of the Ring - Official Thread:

I would suggest creating the map.yml manually so you have more control. It is pretty simple. For example,
map_name: red_sun_over_china
games:

• game_name: Red Sun Over China
  file_name: Red_Sun_Over_China.xml
• game_name: Warlords FFA
  file_name: Warlords.xml
  version: 0

As of now, 2.6 is still not working correctly, although some progress has been made it getting downloads to work. I am now working entirely in 2.5.

Is this the correct format? It looks a slightly different than other maps I have glanced at.

[RogerCooper]

@ff03k64 They all look like that to me. You don't need to specify the path to the file name, but you should only have 1 file of that name.

[ff03k64]

@rogercooper They have brackets for me.

[RogerCooper]

@ff03k64 Interesting, none of mine have brackets.

[ff03k64]

@rogercooper
This is what they look like to me.

map_name: red_sun_over_china
games:
- {game_name: Warlords FFA, file_name: Warlords.xml}
- {game_name: Red Sun Over China, file_name: Red_Sun_Over_China.xml}

https://github.com/triplea-maps/red_sun_over_china/blob/master/map.yml

[RogerCooper]

@ff03k64 Both are valid yaml code Yaml format

[TheDog]

@rogercooper said in Lord of the Rings: War of the Ring - Official Thread:

@ff03k64 Interesting, none of mine have brackets.

I think that might be due to the version of 2.6, Im fairly certain that the format has changed/evolved over time.

As Roger knows when you download 2.6 for the first time and run it, it will unzip all of your maps and create a yml file if there is not one.

With 2.6 and a new map, the mapmaker will have to code their own yml file or zip it and then let 2.6 unzip it and it will create a yml file.

[ff03k64]

@rogercooper Would this be a change big enough to update the triplea_maps.yaml file? I assume that is still the right way to do it, even though we have the yml file now?

edit: mainly the second question

[RogerCooper]

@ff03k64 Both formats work. No need to change anything.

[ff03k64]

@rogercooper so we don't need to update the triplea_maps.yaml file anymore? I thought that was how the game knew to tell people that they have an old version of a map?

[RogerCooper]

@ff03k64 Increment the version number map.yml

[ff03k64]

@rogercooper i don't see a version number there.

[RogerCooper]

@ff03k64 Try the format I am using

map_name: large_middle_earth
games:
- game_name: Lord of the Rings: Middle Earth-Rebalanced
  file_name: Lord_of_the_Rings_War_of_the_Ring.xml
version: 1

[ff03k64]

@rogercooper would that need to be removed from triplea_maps.yaml? Or will this one over rule that one?

[RogerCooper]

@ff03k64 Don't confuse map.yml with triplea_maps.yaml.

map.yml designates how the individual scenarios will be displayed in the selection screen on your local computer.

triplea_maps.yaml is file maintained in github which designates how the scenario will displayed on the download screen

The version number should be changed in both.