I need help for to fix the error



  • Hi

    I have been working on a map. I've got an error message. Does anybody help me?

    This is the file's link

    https://files.fm/u/z4zkwvmv#_

    Thanks.


  • Admin

    @schulz

    I see a couple issues.

    1. You should change your folder structure to "european_war-master/map" and remove/rename the house_of_hapsburg folder.

    2. Your "Italy 12" needs a pu value.

    3. Something with cruisers is not right.

    Restricted transports cannot have attack or defense,    for: UnitAttachment attached to:UnitType{name=Cruiser} with name:unitAttachment
    

    Sorry no time to look further. But maybe related to a property at end of xml. Or it needs to be a combat transport.

    isCombatTransport    values: considers a unit to be a combat sea unit, even if it has transport capacity, for the purposes of convoys and restricted attack on transports
    

  • Admin

    @Schulz

    Ok just had a moment, confirmed, add following to cruiser unit attachment.

     <option name="isCombatTransport" value="true"/>
    

  • Moderators

    Hey, are you the Schulz of the lobby rite?

    @General_Zod is substantially correct. Anyways, let's recap all, regardless, to limit confusion.

    That one file you are making us download has this path:

    european_war-master/house_of_habsburg-master/map/games...

    one of the ways you can put it working is by having it as simply:

    european_war/games...

    Also, you have a description folder with the thumbnail image of @CrazyG "House of Habsburg" game. Probably, you want to delete that anyways.

    Once you have done this, you then need to assign a number to the value of "production" of "Italy 12".

    Then, if you want to have v3 transport rules and also have Cruiser as a combat unit that can also transport, you need to flag it as a "combat transport", by adding the option:
    <option name="isCombatTransport" value="true"/>

    If realism is your aim, transporting units makes much more sense for destroyers than cruisers, but both are so much more inefficient than regular transport ships that it may be better neither (but surely not cruisers).


  • Moderators

    Also, I think Serbia and Bulgaria deserve to be players, or at least minors, or, if really part of other players, I'd have Bulgaria as Germany, rather than Ottoman.
    The Ottomans spending their income producing units in Bulgaria is really not, you know.



  • Thanks for your interest guys.

    • I changed the file's name, I gived 4 pus value to Italy 12. And after editing. My cruiser's features are:

    <attachment name="unitAttachment" attachTo="Cruiser" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
    <option name="movement" value="2"/>
    <option name="isSea" value="true"/>
    <option name="attack" value="4"/>
    <option name="defense" value="4"/>
    <option name="isCombatTransport" value="true"/>
    <option name="canBombard" value="true"/>
    <option name="isCombatTransport" value="true"/>
    <option name="createsResourcesList" value="-1:PUs"/>
    </attachment>

    But still does not work. I think the main problem is the name of cruiser. So The fearues of the cruiser is pretty similar to battlecruiser's features. Probably I will have to change the name of cruiser as "battlecruiser"

    @Cernel

    Yes I am from the lobby. Bulgaria and Serbia could be separate countries or part of Germany and another country. I have not really decided yet.


  • Moderators

    @schulz Well, of course, if you remove the ability to transport from the Cruiser (as I suggested), then you don't have anymore to flag it as a combat transport, since it is not a transport, now. So remove the "isCombatTransport" too. I guess my bad not having specified it.



  • <attachment name="unitAttachment" attachTo="Cruiser" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
    <option name="movement" value="2"/>
    <option name="isSea" value="true"/>
    <option name="attack" value="4"/>
    <option name="defense" value="4"/>

      <option name="canBombard" value="true"/>
    

    <option name="createsResourcesList" value="-1:PUs"/>
    </attachment>

    Unfortunately. Still does not work. I want to change the name of crusier


  • Moderators

    @schulz I can only tell you that if something is not working now, it is not because of that unit attachment, which is now correctly coded.
    I guess you should re-upload the new version that now doesn't work for you.



  • https://files.fm/u/asn5jpz3#_

    Also I totally removed
    cruiser from the game for to see likely other errors.

    Does not work even without cruiser. Seems like there is an another mistake in the xml file


  • Moderators

    @schulz So, are you trying to use the same zip you have uploaded there?

    The path of that zip is:

    european_war-master/european_war/map/games

    that is not going to work.

    I told you, just have it simple as:

    european_war/games

    I did it and, at least, the game starts with no problems, both zipped and unzipped.

    You don't have to worry about the "master" plus "map" thing; that is just a thing that GitHub makes up when you download the repository.



  • I had already tried it before. I fear that I won't be able to rescue the map.


  • Admin

    @schulz You were just missing the "-master" from the folder inside the zip. Here is a working version: 0_1523044094353_european_war-master.zip

    PS. You should really consider using the updated House of Habsburg map as a base map since the graphics were massively improved.


  • Moderators

    @schulz @schulz What I'm telling you to do is simply that you have your downloadedMaps folder. Then, inside it, you have a folder called "european_war". And inside that folder you have "games" and all other things that, in the map you download from the repository, stay in the "map" folder.
    I did it and it worked; so it has to work for you too, unless you are on a case sensitive system (Linux, Mac) and are getting an error you would not get on Windows.

    Or you can do it the way @redrum is telling you, but, in that case, I believe it will work only zipped.



  • Thank you so much redrum. In now the zip does work and I would like to use no man's land's v3 rules in the map without any problem.

    Did Crazy German upload the new version of House of Habsburg map?


  • Moderators

    @schulz Yes. The new one is in the repository.


  • Admin

    @schulz Yeah, you can find his latest map here: https://github.com/triplea-maps/house_of_habsburg

    If you delete your local House of Habsburg zip from downloadedMaps, you can also re-download from in-game and should be the latest I believe with all the updated map tiles/images.



  • The new version of house of habsburg looks so cool, especially I liked the relief tiles.

    But I had started on the older version unfortunately.


  • Admin

    @schulz Yeah, vast improvement thanks to @Hepps. I would strongly consider adopting the new version as you can probably re-use at least most of the XML changes you've made for units, etc. Better to switch over sooner rather than later and sure you learned a lot through you initial work. Also, it would probably be good to start a separate map thread for your map now that this error is resolved and you have it working.



  • Btw, my trains do not work. I have this code for every country in my xml file like dom 1914 weltpolitic. Should I add something more?

    <attachment name="techAttachment" attachTo="Country" javaClass="games.strategy.triplea.attachments.TechAttachment" type="player">
    <option name="techCost" value="10"/>
    <option name="mechanizedInfantry" value="true"/>
    </attachment>