Civil War | Assign and hide utilitarian players
-
Assign and hide utilitarian players
https://github.com/triplea-maps/civil_war/pull/5
This pull request for "civil_war" (both games) is to hide all utilitarian players and assign the ones starting with AI to AI and the other ones to Does Nothing. Only factual change is to clean up the start game interface.
Probably all should have been given to "DoesNothing", but this keeps the intended functionality, where specified, and I believe it doesn't matter, factually.@redrum @LaFayette to merge.
-
Should have I upgraded the download version number? I'm oriented not to for not functional game changes.
-
@cernel Merged. Could go either way on upgrading the version number. It was minor enough that I probably wouldn't have but its fine that you did.
-
@redrum I was actually talking about the one that is in the yaml and tells people to update (I didn't push a change for). I would always change the xml version if I change anything anywhere noticeable on the user, but here I was actually wondering if I should have added a 4th digit, instead of increasing the 3rd one.
Anyway thanks for merging.
-
@cernel Ah, well yaml file updates just determine whether users that have the map downloaded get prompted to update it. Probably don't need to update it for a minor change like this. But not a big deal either way.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login