[Open] Multiple rockets can't attack the same territory in WW2 Global 40 2nd Edition

thephalanx1453

Map: WW2 Global 1940 2nd Edition with Combat Move First, version 4.0 (latest version)

To reproduce issue:

Start game:
Edit Mode to give Germany Rockets Advance, and an Airfield in Norway.

At the end of Combat Move phase, two prompts ask you to select target territory for both rockets. Select United Kingdom for both prompts.

1 prompt pops up to ask for bombing target in United Kingdom
Select factory_major
Game rolls once for one rocket attack.

That's it. Combat move over. There is no second rocket attack.

thephalanx1453

These are the relevant properties in the map's xml file.

<property name="All Rockets Attack" value="true" editable="false">
  <boolean/>
</property>
<property name="Rocket Attacks Per Factory Infinite" value="true" editable="false">
  <boolean/>
</property>

beelee

@thephalanx1453 I'm not 100% certain but I think you can only have 1 rocket attack per territory. You could ask @Panther. He should know

thephalanx1453

@beelee There is no such rule in Global 1940, unlike in Anniversary. Plus, the changelog for the map specifically mentions "Fixing rockets so that many rockets can target the same infrastructure per turn." under version 3.7

beelee

@thephalanx1453 well..guess it didn't get fixed

Panther

@beelee The issue is valid. Global Rulebook says: "... each of your operative air bases can make a single rocket attack against an enemy industrial complex, air base, or naval base within 4 spaces of it. "

Panther

@thephalanx1453 Thank you for bringing it up!
https://github.com/triplea-game/triplea/issues/3784

panther2 created this issue in triplea-game/triplea

closed TripleA does not roll multiple Rocket attacks in wwII_global1940 #3784

simon33

If you go into Download Maps and update Global, this should be fixed.

thephalanx1453

@simon33 I can't update since I think I was using the latest version. So I just uninstalled and reinstalled again. Problem is still there though. The map version is 4.0.

simon33

I'll have a look at that.

Panther

@simon33 Can't see it either... the last update of the Global map-repo at this moment appears to be "Resolve issue with US troops not being able to land on USSR immediate… " (17 days ago)...
I have reproduced the issue using exactly this version.

simon33

Right, I remember now. This can only be completely fixed with an incompatible version. The way it was a couple of years ago wasn't completely right in that you could see the result of one rocket before targeting another one. This was partly fixed but caused this problem. Bummer.

Panther

@simon33 But didn't Krieghund say : "There is no reason why you would need to declare all rocket targets before rolling for any rockets." ? Can there probably be an easier fix for the current issue (preventing from incompatibility) when following his clarification?

General_Zod

@panther

I think this needs to be added to xml. I recommend to make it editable, since rockets will be very powerful and might disturb balance.

<!-- if true allows infinite attacks against a factory by many rockets, if false,will only allow a max of 1 rocket to attack each factory -->

<property name="Rocket Attacks Per Factory Infinite" value="true" editable="true">
<boolean/>
</property>

Also should probably make the following custom code editable="false", since it is not functional. And will confuse players.

<property name="Strictly rule compliant rockets" value="false" editable="true">
<boolean/>
</property

Panther

@general_zod Thank you, but I think the first one is already part of the xml, the second one is not.

General_Zod

@panther Ok, I guess my version isn't updated then.

General_Zod

@panther I am looking at one of my mods (Bad-Ass 4 nation ffa) where this feature used to function and it no longer does with .11311 (or any v1.9 that I have). The behavior is as described above, I choose multiple rockets to attack the same target but only one fires, and ends.

This may have been broken way back when we changed to v1.9 since it works in for my v1.8.0.9 version. It allows me to pick same target, furthermore the order is as follows.

rocket 1 selects target and fires
rocket 2 selects target and fires
rocket 3 selects target and fires

All same target.

Panther

@general_zod There have been some rocket related engine code changes back in 2017. You could search the closed github pull requests with the keyword "rocket" if you are interested in details.

The way you describe it seems to be valid, indeed.

I don't know what broke this behaviour. Maybe @simon33 knows better, he had put a lot of effort in it.

Maybe something can be reverted to restore that functionality?

General_Zod

@panther
Maybe a global property can be added to determine the mode of target selection and firing for rockets.

Meaning one modes sequence is as follows:

rocket 1, player selects target and fires
rocket 2, player selects target and fires
rocket 3, player selects target and fires
All same target or separate targets depending on existing global properties.

And other modes sequence is as follows:

rocket 1 , player selects target
rocket 2 , player selects target
rocket 3 , player selects target
All rockets fire
All same target or separate targets depending on existing global properties.

The former will follow the official A&A rules and the latter will alleviate concerns of seeing damages before all target selections are completed.

But the either way there is currently an existing bug, preventing all rockets from hitting a single target if "Rocket Attacks Per Factory Infinite" =true.

Panther

@general_zod Yes, sounds good.