Change Unit Ownership? [Re-opened]

SlendyMcTendies

<variable name="Territory">			<!-- 227 territories -->

<element name="Western Germany"/>
<element name="Holland Belgium"/>
<element name="Poland"/>
<element name="Romania"/>
<element name="Slovakia Hungary"/>
<element name="Germany"/>
<element name="Austria"/>



</variable>

<attachment foreach="$Territory$" name="triggerAttachment_Germans_SurrenderTo_Russians" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="changeOwnership" value="@Territory@:Germans:Russians:true"/>
</attachment>

Full XML file at time of writing attached: ww2_risk_of_defeat.xml

wc_sumpton

@slendymctendies

@RogerCooper is right, "foreach" is very powerful. And in some cases can be very tricky to use. "changeOwnership" is one such example. Here there three list that might change "ConqueringPlayer", "ConqueredPlayer" and "SurrenderedTerritories". For example "Spain" is a "Neutral" country with "Madrid" as its capital, so when "Madrid" falls, all "Spain" territories held by "Neutral" surrendered.
"foreach"="@AllConqueringPlayers@" (Needs to be in "triggerAttachment" name and conditions)
"changeOwnership"="$AllConqueringPlayers$":"NeutralPlayer":"SurrenderedTerritory1" (Just 1 territory here not a list)
"changeOwnership"="$AllConqueringPlayers$":"NeutralPlayer":"SurrenderedTerritory2" (Another territory)

"Spain" surrenders territories when "Madrid" is captured from ConqueredPlayer.
"foreach"="@AllConqueringPlayers@^@AllConqueredPlayers@"
"changeOwnership"="$AllConqueringPlayers$":$AllConqueredPlayers$:"SurrenderedTerritory1" (Just 1 territory here not a list)
"changeOwnership"="$AllConqueringPlayers$":$AllConqueredPlayers$:"SurrenderedTerritory2" (Another territory)

Now the tricky part, ConqueredPlayer capital is conquered. Now SurrenderedTerritories becomes a list of all land territories and "foreach" cannot double nest: "@AllConqueringPlayers@^@AllConqueredPlayers@^@AllSurrenderedTerritories@". One list has to not change for "foreach" to work.
"foreach"="@AllConqueringPlayers@^@AllSurrenderedTerritories@" (ConqueredPlayer does not change)
"changeOwnership"="$AllConqueringPlayers$":ConqueredPlayer1:"$AllSurrenderedTerritories$"
Only do 1 ConqueredPlayer per attachment.

Cheers...

wc_sumpton

@slendymctendies

$Territory$ need to appear in the attachments name: "triggerAttachment_Germans_SurrenderTo_Russians_@Territroy@"

This is creating an attachment for each territory, so the attachment names have to be different.

Cheers...

SlendyMcTendies

@wc_sumpton PLEASE SEE BOTTOM OF THIS POST FOR NEW QUESTION

Ok, so I got this to almost work. The game log shows that the trigger fires and supposedly the German territories get converted to Russia's control, but in actuality they have not. The territory "team color" does not change, nor can the Russia player do anything with those territories (such as deploy units or non-combat move through them).

<attachment foreach="$Territory$" name="triggerAttachment_Germans_SurrenderTo_Russians_@Territory@_ChangeOwnership" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="before:germansEndTurn"/>
	<option name="changeOwnership" value="@Territory@:Germans:Russians:true"/>
</attachment>

EDIT: For some reason, the "Conquered" boolean at the end needed to be False. I don't really understand why, but that seems to have worked for territory conversion.

However, with just this, the German's units are still present on the territories that were surrendered.

NEW QUESTION:

Is there a way to convert ownership of units?

wc_sumpton

@slendymctendies said in changeOwnership Trigger - Filter by owned territories?:

EDIT: For some reason, the "Conquered" boolean at the end needed to be False. I don't really understand why, but that seems to have worked for territory conversion.

The difference between endTurn and now. "true" mean "battle" and change happens at the conquering players endTurn (Russian)

Cheers...

SlendyMcTendies

@wc_sumpton No, I'm talking about this line:

<option name="changeOwnership" value="@Territory@:Germans:Russians:true"/>

I had to switch from "true" to "false" at the end of this line. To quote the documentation:

<!-- changeOwnership must have 4 fields: 
territory:oldOwner:newOwner:booleanConquered -->

Whatever "BooleanConquered" does when set to "True" is not clear to me. It does not affect when the trigger fires

wc_sumpton

@slendymctendies

But it does effect when the ownership is changed. "false" means change now. "true" means this is a "battle" and is treated as if a battle happened, and ownership changes at the end of turn.

Cheers...

SlendyMcTendies

@wc_sumpton Ah, ok. Thank you for that clarification

wc_sumpton

@slendymctendies said in changeOwnership Trigger - Filter by owned territories?:

Is there a way to convert ownership of units?

"canBeGivenByTerritoryTo" and "changeUnitOwners" and "giveUnitControlInAllTerritories" with some trigger work.

Cheers...

SlendyMcTendies

@wc_sumpton I keep getting an error when trying to use any of those options in a trigger. This is my latest attempt:

<attachment name="triggerAttachment_Germans_SurrenderTo_Russians_UnitControl" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="players" value="Russians"/>
	<option name="giveUnitControlInAllTerritories" value="true"/>
</attachment>

None of the options seem to be valid TriggerAttachments though?

"canBeGivenByTerritoryTo" is a Unit Attachment
"changeUnitOwners" is a Territory Attachment
"giveUnitControlInAllTerritories" is a PlayerAttachment

How do I use these in a trigger?

wc_sumpton

@slendymctendies

Every unit attachment will need the following: "canBeGivenByTerritoryTo", and value need to equal one players, "Russians" at this point it doesn't matter what's here, it's just priming the pump. Some triggers do not work if there is no original entry to certain options.

Next add "giveUnitControlInAllTerritories" to the "playerAttachment" and set it to "false".

<!-- change military units canBeGivenByTerritoryTo-->
<attachment name="triggerAttachment_canBeGivenByTerritoryTo_GermansToRussians" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$AllUnits$"/>
	<option name="unitProperty" value="canBeGivenByTerritoryTo" count="Russians"/>
	<option name="when" value="before:germansEndTurn"/>
</attachment>

<!-- Give by territories Germans to Russians -->
<!-- Should not need to reset this because Germans are out of the Game -->
<attachment name="triggerAttachment_GiveByTerritory_GermansToRussians" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="playerAttachmentName" value="PlayerAttachment" count="playerAttachment"/>
	<option name="players" value="Germans"/>
	<option name="playerProperty" value="giveUnitControlInAllTerritories" count="true"/>
	<option name="when" value="before:germansEndTurn"/>
</attachment>

<!-- reset military units canBeGivenByTerritoryTo -->
<attachment name="triggerAttachment_Reset_canBeGivenByTerritoryTo" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_AlwaysTrue"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$AllUnits$"/>
	<option name="unitProperty" value="canBeGivenByTerritoryTo" count="-reset-"/>
	<option name="when" value="after:germansEndTurn"/>
</attachment>

SlendyMcTendies

@wc_sumpton This isn't working either. Did a lot of testing and for some reason can't get it to work.

Latest xml attached:

ww2_risk_of_defeat.xml

wc_sumpton

@slendymctendies

The following seems to work:

<!-- Remove Capital Requirement -->
<attachment foreach="$AllPlayers$" name="playerAttachment" attachTo="@AllPlayers@" javaClass="games.strategy.triplea.attachments.PlayerAttachment" type="player">
	<option name="retainCapitalNumber" value="0"/>
	<option name="retainCapitalProduceNumber" value="0"/>
	<option name="giveUnitControl" value="$AllPlayers$"/>
	<option name="giveUnitControlInAllTerritories" value="false"/>
</attachment>
<attachment foreach="$Territory$" name="triggerAttachment_Germans_SurrenderTo_Russians_@Territory@_ChangeOwnership" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="before:germansEndTurn"/>
	<option name="changeOwnership" value="@Territory@:Germans:Russians:false"/>
	<option name="uses" value="1"/>
</attachment>
<!--  change military units canBeGivenByTerritoryTo -->
<attachment name="triggerAttachment_canBeGivenByTerritoryTo_GermansToRussians" attachTo="Germans" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$AllUnits$"/>
	<option name="unitProperty" value="canBeGivenByTerritoryTo" count="-reset-Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="uses" value="1"/>
</attachment>
<!--  Give unit control Germans to Russians  -->
<attachment name="triggerAttachment_GiveUnitControl_GermansToRussians" attachTo="Germans" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="playerAttachmentName" value="PlayerAttachment" count="playerAttachment"/>
	<option name="playerProperty" value="giveUnitControl" count="-reset-Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="uses" value="1"/>
</attachment>
 <!--  Give give captured units Germans to Russians  -->
<attachment name="triggerAttachment_GiveUnitControlInAllTerritories_GermansToRussians" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="playerAttachmentName" value="PlayerAttachment" count="playerAttachment"/>
	<option name="playerProperty" value="giveUnitControlInAllTerritories" count="true"/>
	<option name="uses" value="1"/>
</attachment>

Cheers...

SlendyMcTendies

@wc_sumpton Ok, when I have a moment to try this myself I will let you know how it goes. Thank you for your help!

TheDog

In my experimenting/coding with playerAttachment I suspect the following maybe true;

* playerAttachment must be the last attachment in </attachmentList> EDIT: It does not need to be the last attachment.

Only One playerAttachment per Player is allowed

SlendyMcTendies

@wc_sumpton Perfect! Works beautifully! Thank you again!

Jason Green-Lowe

@thedog I had a problem with playerAttachment that was fixed by making sure that there was only one playerAttachment per Player. Thank you very much for the tip!

For whatever it's worth, I have other attachments after the playerAttachments in my attachmentList, and it does not currently seem to be causing me problems.

SlendyMcTendies

@wc_sumpton Does the value of PlayerAttachmentName need to be unique for each action? Because for some reason the unit control transfer stopped working when I added this code to the other 7 players (Russians, Japanese, Americans, etc)

wc_sumpton

@slendymctendies

Each player should have only one "playerAttachment", having more will cause problems. Thus 'PlayerAttachmentName' will not be unique. If problems persist, try adding 'players' <option>.

Cheers...

SlendyMcTendies

@wc_sumpton I'm confused about what you mean by players only being allowed "one" player attachment. You have two in your code example, yet it worked at the time.

@wc_sumpton said in Change Unit Ownership? [Resolved]:

@slendymctendies

The following seems to work:

<!-- Remove Capital Requirement -->
<attachment foreach="$AllPlayers$" name="playerAttachment" attachTo="@AllPlayers@" javaClass="games.strategy.triplea.attachments.PlayerAttachment" type="player">
	<option name="retainCapitalNumber" value="0"/>
	<option name="retainCapitalProduceNumber" value="0"/>
	<option name="giveUnitControl" value="$AllPlayers$"/>
	<option name="giveUnitControlInAllTerritories" value="false"/>
</attachment>
<attachment foreach="$Territory$" name="triggerAttachment_Germans_SurrenderTo_Russians_@Territory@_ChangeOwnership" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="before:germansEndTurn"/>
	<option name="changeOwnership" value="@Territory@:Germans:Russians:false"/>
	<option name="uses" value="1"/>
</attachment>
<!--  change military units canBeGivenByTerritoryTo -->
<attachment name="triggerAttachment_canBeGivenByTerritoryTo_GermansToRussians" attachTo="Germans" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$AllUnits$"/>
	<option name="unitProperty" value="canBeGivenByTerritoryTo" count="-reset-Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="uses" value="1"/>
</attachment>
<!--  Give unit control Germans to Russians  -->
<attachment name="triggerAttachment_GiveUnitControl_GermansToRussians" attachTo="Germans" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="playerAttachmentName" value="PlayerAttachment" count="playerAttachment"/>
	<option name="playerProperty" value="giveUnitControl" count="-reset-Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="uses" value="1"/>
</attachment>
 <!--  Give give captured units Germans to Russians  -->
<attachment name="triggerAttachment_GiveUnitControlInAllTerritories_GermansToRussians" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
	<option name="trigger" value="conditionAttachment_Germans_SurrenderTo_Russians"/>
	<option name="when" value="after:germansPolitics"/>
	<option name="playerAttachmentName" value="PlayerAttachment" count="playerAttachment"/>
	<option name="playerProperty" value="giveUnitControlInAllTerritories" count="true"/>
	<option name="uses" value="1"/>
</attachment>

Cheers...

So what do you mean by players only having one player attachment?