Bombing Bonus Not Working

[VictoryFirst]

Lol this looks cool xD

[beelee]

@VictoryFirst

heh heh Joe Pants image

I got it automated for the big targets. Up to 3 different bombs so after you fly the bomb in it'll auto change to the cloud in NCM lol

[VictoryFirst]

I just tried it myself and I got the bonus:

[VictoryFirst]

It looks like the bonus is only applied to the first roll.

[VictoryFirst]

Can you create a GitHub issue? It's an engine thingy that is not too hard to fix.

[beelee]

@VictoryFirst

[VictoryFirst]

Lol it looks like the first roll gets the bonus added up but the second roll gets it subtracted

dice rolls: [2, 2]
die 2
dice + bonus: [4, 0]
die 2
dice + bonus: [4, 0]
nextDieIndex: 1

[VictoryFirst]

Nope, it is that the die index does not update correctly so the first roll gets replaced with the second roll, and the second number always stays 0.

dice rolls: [3, 0]
dice + bonus: 5
dice array [0, 0]
die index 0
dice + bonus: 2
dice array [5, 0]
die index 0

Notice how die index stays 0. I didn't print this, but dice array would probably look like [2,0] which corresponds to a roll of 3 and 1 in-game. That corresponds with what the game shows.

[beelee]

@VictoryFirst

Maybe a little harder to fix then

Well i made an issue. Kinda forgot how to do it lol

[VictoryFirst]

Nah I already fixed it. Will create a PR soon.

[beelee]

@VictoryFirst

[beelee]

@VictoryFirst

So it's OK to do the update after it merges ? I think WC the only one with the button issue. Don't want any of the guys to get that

[VictoryFirst]

@beelee I thought you did not get the button issue, You aren't running on the latest version? I don't think you will get the button issue if you update, I am not getting it either on the latest.

[beelee]

@VictoryFirst no it's all good for me

on 15640

[VictoryFirst]

@beelee probably failed spotlessCheck lol

[beelee]

@VictoryFirst

heh heh exit code 1