TripleA Logo TripleA Forum
    • TripleA Website
    • Categories
    • Recent
    • Popular
    • Users
    • Groups
    • Tags
    • Register
    • Login

    Bombing Bonus Not Working

    Scheduled Pinned Locked Moved Map Making
    19 Posts 2 Posters 12 Views 2 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • VictoryFirstV Offline
      VictoryFirst
      last edited by

      Can you create a GitHub issue? It's an engine thingy that is not too hard to fix.

      B 1 Reply Last reply Reply Quote 1
      • B Online
        beelee @VictoryFirst
        last edited by

        @VictoryFirst

        rightarm.png

        1 Reply Last reply Reply Quote 1
        • VictoryFirstV Offline
          VictoryFirst
          last edited by VictoryFirst

          Lol it looks like the first roll gets the bonus added up but the second roll gets it subtracted

          dice rolls: [2, 2]
          die 2
          dice + bonus: [4, 0]
          die 2
          dice + bonus: [4, 0]
          nextDieIndex: 1
          
          1 Reply Last reply Reply Quote 0
          • VictoryFirstV Offline
            VictoryFirst
            last edited by

            Nope, it is that the die index does not update correctly so the first roll gets replaced with the second roll, and the second number always stays 0.

            dice rolls: [3, 0]
            dice + bonus: 5
            dice array [0, 0]
            die index 0
            dice + bonus: 2
            dice array [5, 0]
            die index 0
            

            Notice how die index stays 0. I didn't print this, but dice array would probably look like [2,0] which corresponds to a roll of 3 and 1 in-game. That corresponds with what the game shows.

            0182bc33-1fa2-4ff5-9353-1d8b941a1880-image.jpeg

            B 1 Reply Last reply Reply Quote 1
            • B Online
              beelee @VictoryFirst
              last edited by

              @VictoryFirst

              😯

              Maybe a little harder to fix then 😞

              Well i made an issue. Kinda forgot how to do it lol

              VictoryFirstV 1 Reply Last reply Reply Quote 0
              • VictoryFirstV Offline
                VictoryFirst @beelee
                last edited by

                Nah I already fixed it. Will create a PR soon.

                B 2 Replies Last reply Reply Quote 1
                • B Online
                  beelee @VictoryFirst
                  last edited by

                  @VictoryFirst rock-on.png

                  1 Reply Last reply Reply Quote 0
                  • B Online
                    beelee @VictoryFirst
                    last edited by

                    @VictoryFirst

                    So it's OK to do the update after it merges ? I think WC the only one with the button issue. Don't want any of the guys to get that 🙂

                    VictoryFirstV 1 Reply Last reply Reply Quote 0
                    • VictoryFirstV Offline
                      VictoryFirst @beelee
                      last edited by

                      @beelee I thought you did not get the button issue, You aren't running on the latest version? I don't think you will get the button issue if you update, I am not getting it either on the latest.

                      B 1 Reply Last reply Reply Quote 0
                      • B Online
                        beelee @VictoryFirst
                        last edited by beelee

                        @VictoryFirst no it's all good for me 👍

                        on 15640

                        354e080c-96c9-4a85-8031-36d66a4c94d1-image.jpeg

                        😢

                        VictoryFirstV 1 Reply Last reply Reply Quote 0
                        • VictoryFirstV Offline
                          VictoryFirst @beelee
                          last edited by

                          @beelee probably failed spotlessCheck lol

                          B 1 Reply Last reply Reply Quote 0
                          • B Online
                            beelee @VictoryFirst
                            last edited by

                            @VictoryFirst

                            heh heh exit code 1 🙂

                            1 Reply Last reply Reply Quote 0

                            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

                            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

                            With your input, this post could be even better 💗

                            Register Login
                            • 1 / 1
                            • First post
                              Last post
                            Powered by NodeBB Forums