Find province command
-
There is a pending PR for the first iteration of this feature: https://github.com/triplea-game/triplea/pull/4115
A question that has come up is where would most users expect to find the new Find Territory... command on the TripleA main menu. Typically, such "find" commands would appear on an application's Edit menu. As TripleA has no such menu, this leaves choosing an appropriate location for the new command a bit less straightforward.
As proposed in the above PR, it is at the bottom of the Game menu. Other proposed locations have included:
- Somewhere else on the Game menu (e.g. at the top).
- Somewhere on the View menu.
- Somewhere on the Help menu.
- As the sole item on a new Search menu (which could appear, for example, between the File and View menus).
Any other ideas beyond those proposed above are welcome, as well.
-
I wonder if, in addition to wherever else it is placed; there should be an instance of it in the "territory" tab on the right side of the screen, i.e. when you have the territory tab selected. (the place that also has notes, actions, players, etc)
-
@zlefin I failed to mention above that, as part of the aforementioned PR, the hotkey
Ctrl+Fwill also bring up this feature.If a sufficient number of users feel having an additional Find Territory button on the Territory tab, presumably under the Battle Calculator button, is beneficial, we can certainly add it. If such a button were added, my guess is whatever territory is currently selected in the Territory tab would be used to seed the Find Territory dialog. That, in and of itself, is probably useless since the user already knows where the selected Territory is because they selected it.
But another access point for the dialog couldn't hurt. -
I would think the View menu would make the mot sense.
-
-
The first iteration of this feature is now available in pre-release 12238 or later. In this version, one can only select the territory to "find" from a drop-down list. I will be submitting a new PR shortly that will also give the user the option of typing the territory name (with auto-complete).
EDIT: BTW, I did move the command to the View menu, as recommended above.
Ctrl+Fcontinues to work unchanged. -
Pre-release 12242 now allows users to type a territory name in the Find Territory dialog with auto-complete. No support yet for normalizing accented characters, however.
I'd really like to hear from players if the way auto-complete behaves meets your expectations. I thought it was a bit strange at first, but quickly got used to it. However, I'm biased.
-
Pre-release 12254 now briefly animates the territory border after the territory is centered on the map. This should make it easier to identify territories that may not have a name on the map (e.g. sea zones in Classic)
-
@ssoloff Smart
-
I like this feature. Very nice work!
But I think the access to the search could be improved. The current location of the “Find territory” feature is not very intuitive IMO. How about placing this feature in the territory tab. There is already a button there for battle calculator, so why not make a button for find territory? I’m my mind it would be very intuitive to look there for something concerning territories, and players would not be able to miss this button, so they will know where to find it if they need it.
Map maker of: Star Wars: Galactic War + Star Wars: Tatooine War + Caribbean Trade War + Dragon War + Age of Tribes + Star Trek: Dilithium War + Iron War + Iron War: Europe + Warcraft: War Heroes
-
Pre-release 12280 ignores accents and other so-called "combining characters" that may be present in a territory's name. For example, in Battle for Arda, you can now type
Lhuand it will matchLhûn. -
-
@ssoloff Personally, I don't think this feature is that important to deserve a place in the territory tab itself.
-
@cernel Noted. I'll wait a bit before adding the button to see if there are any other opinions.
-
Pre-release 12317 synchronizes the Find Territory dialog with the Territory tab (there's a screencast that demonstrates what that means here). As there hasn't been any further objections, it also adds a Find Territory button to the Territory tab, as requested (it makes a bit more sense, IMO, now that the dialog and tab are synchronized).
-
Pre-release 12330 highlights the territory selected in the combo-box in real time. This allows one to find multiple territories without having to close the dialog and re-open it.
I'm not sure if most users find this or the original behavior more intuitive. Please feel free to share your experience.
-
Well it'd be good to put in the territory tab if when the territory gets selected somehow that it showed the list of units in that territory just like if you were hovering over the territory with the tab open. This would be helpful in cases where people need to tally up units in multiple crowded territories to calc.
-
@erik542 said in Find province command:
Well it'd be good to put in the territory tab if when the territory gets selected somehow that it showed the list of units in that territory just like if you were hovering over the territory with the tab open. This would be helpful in cases where people need to tally up units in multiple crowded territories to calc.
Sorry, I don't understand or can't visualize the user case.
-
@ssoloff Actually, it's not about this button so much, really: I would just remove all buttons from the territory tab.
The Find Territory is really something that almost only we forum users are ever going to use, to go searching on this or that map where is what when someone names a territory here in forum, and, to let people know there is this function, it can just have its own "Search" main menu alone, since anyways doesn't really fit well anywhere else. People playing live, getting asked an edit, will just ask where to at their mates, if they don't know how to find it in the menu, already.
The Battle Calculator button is really nonsense, I believe, because in the moment you move the cursor around you change the territory in the tab. So how the hell are you going to click on what you want, unless maybe you push the board so that the territory you want touches the right side bar, to move there without going into a different one, which is silly and you can't do it anyways if the map doesn't wrap and the territory is too close to the left side of it. I don't think I ever click on that button, but just use Ctrl+B, and I suppose everyone else does the same. So, at the end, that button is just there as an advertisement that you can click on Ctrl+B, pretty much; so, if I'm right here, that would be better done as an info in "Help", probably renaming "Movement/Selection Help" to "Gamplay Help", and adding the info that Ctrl+B on the territory opens what I would call the "Battle Simulator".
Actually, I think that the Find Territory makes more sense than the Battle Calculator; so if I would be allowed to trash only 1 button I'd choose the Battle Calculator one. So, you see, it's just to say it's more of a general matter for me, about buttons in the tabs.
By the way, now that you get the list of territories (in alphabetical order, of course), I'd suggest mapmakers even more to have "001 Sea Zone" or "001 SZ" instead of "Sea Zone 1" or "SZ 1" (like we did for World At War, changing all from like "SZ 1" to like "1 Sea Zone" (tho I think "001 Sea Zone" would have been better, as said)), surely in the case your sea zones are all numbers, and even more so in the case they have actual names, instead, so that you don't just get a whole bunch of sea zones packed in between of the actual names starting with "S", that doesn't make sense. This is something that I always advised anyways, for listing reasons (we see here), and just I think this thing is making the concept clearer. So just pointing.
Also, I also see that the "Lock Map" one (maybe naming it better too, since I don't think "Lock Map" makes you understand so well what the button does), totally disables this new function from working? Maybe that should just avoid the map jumping around when you search, but all the rest still working. Is this a bug?
-
Also, I also see that the "Lock Map" one (maybe naming it better too, since I don't think "Lock Map" makes you understand so well what the button does), totally disables this new function from working? Maybe that should just avoid the map jumping around when you search, but all the rest still working. Is this a bug?
Good point. Not so much of a bug than an "unanticipated interaction between two features."
It would be simple to clear Lock Map while the Find Territory dialog is open so that the Find Territory feature behaves as expected. The question is would the user who enabled Lock Map complain that we were changing the map location even though they explicitly said not to?
It appears the Lock Map feature doesn't prevent any change of the map location (e.g. the user can still scroll with the mouse/keyboard), it just prevents those automatic changes most likely associated with centering on territories during a battle. If that's true, then the above proposal to temporarily clear Lock Map for the duration of the Find Territory operation should be acceptable.
Does anyone have any other thoughts on how Lock Map and Find Territory should or should not interact?
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login