Warcraft: War Heroes - Official Thread

Frostion

@TheDog yea the map still has some issues. Could you drag and drop the save you have into a post here? Then maybe a dev can take a look at what is causing the breakdown. That would be great!

EDIT: That error does look familiar. You could also try to download the latest prerelease and run the save again. Maybe a newer version of TripleA will actually run it without errors.
https://github.com/triplea-game/triplea/releases

Frostion

After playtesting this map a bit more, trying to figure out the next development step, I can again point out this map’s 3 biggest issues. As these are pretty much all AI related, does any dev with AI knowledge feel like taking a look at the save game and the error reports? ( @Alexei-Svitkine @redrum @LaFayette @RoiEX or other dev?)

The AI-players are lacking the ability to handle land territory canals that do only allow certain units. (In this map these are called airways and marked with blue arrows) The result is AI players stacking up around capitals and other places with airways. Like here, where the enemy army stacks up outside a capital that they cannot enter the way they want to. Only flying units can pass these canals:
26roundsWWH.tsvg
The AI-players lack ability to purchase factories during play. At some point during map development, the AI did purchase factories, but not at present time for some reason. This really hinders the AI from winning. I assume it is some kind of resource type issue, as there are plenty of 3+ PU territories.
The "Wrong owner" Issue. When AI controlled main players capture territories from AI minor players this error pops up. It does not happen when human controlled main players capture from AI minor players. I suspect the cause is that the AI minor player units killed spawn an infrastructure unit when killed, and this unit is overtaken by the attacker.
(Don’t blame me for duplicate error reports, as I did not upload more than one of these (I think)):
https://github.com/triplea-game/triplea/issues/6836
https://github.com/triplea-game/triplea/issues/6439
https://github.com/triplea-game/triplea/issues/6840

LaFayette

Do any of those error reports have a savegame attached that is just before the error occurs?

TheDog

@LaFayette sadly no, but now Im saving every turn.

Frostion

@LaFayette the "wrong owner" errors happen literally every single time an AI player attacks and wins over an minor AI player. So by running an all AI game, one can easily make the error occur during round 1.

LaFayette

@Frostion cool, though isolating it is still really helpful. Any code fixes need to have that set up and you can be sure we'll play through it a dozen times while isolating the problem and verifying any fix. So getting a save is a necessary step. Getting that ready just saves time, hence very helpful.

Trevan

@Frostion I've been able to duplicate the error. So I'm looking into it.

@LaFayette I'm getting stack overflows when I load the Warcraft War Heroes in my game launched from IntelliJ. But I don't get the stack overflows when I run the prerelease game. I'm assuming there is a setting I need to change but I don't know where it is yet.

Trevan

Oddly enough, if I open the save game in my local game launched from IntelliJ, I have no problems. It is just starting a brand new game with Warcraft War Heroes.

LaFayette

@Trevan VM option -Xss, needs to be at least 1250K

@Frostion to explain why a save game helps/saves time. To fix a problem the steps are roughly:

Know there is a problem
Reproduce the problem
Theorize about the cause
Confirm problem
Apply a fix and verify problem is fixed (repeat steps 3-5 until problem is fixed)
Verify fix is limited to the intended target and nothing else is broken by the fix
Clean everything up, run builds, submit PR
Go through review and get code merged

On steps 2 & 5, a save is really helpful, either that or we need to go through as lightly longer process and create the problem from scratch each time. We might run through steps 3 through 5 just a few times, sometimes it's a dozen.

So I don't want to sound callous, just that if a save is provided then it's helpful as it cuts out a potentially time consuming step.

avshar

Well I've been playing the game for 10 rounds and so far no major problems other than the A.I. doesn't seem to do anything with their hero's as far as the origin skills. This could just be a fog of war type thing though. I can't see anything in their origins box but i can see the items in their back packs so just not sure if i'm supposed to see it or not. Also when i look at their hero's they always show they are level 1. Like they don't know how to use the xp. Again just not sure if this is legit or a fog of war issue. The only other problem i found so far is the game crash when you try to use the Help menu to look at unit stats. I think you had mentioned that before though. Will keep playing it to look for other issues.

Frostion

@LaFayette I will be sure to list a save in the future whenever possible as for this one, I have now uploaded a save to Github.

Frostion

@avshar Sadly the AI does not buy factories and factory upgrades as well as origin story skills

I don't know how to motivate them to buy the origin story skills. Maybe giving the skills some attack/defense stats? Or maybe high PUs value?

avshar

I tracked their hero's a bit more and saw that they are just collecting XP but never using it. Also i never see them produce veteran or elite units with their chevrons. So pretty sure the A.I. Doesn't use that entire list.

I have been exiting the game here and there, then turning the A.I. player to human for one round to access those categories and use up their saved chevrons and XP. Then re-exiting the game and turning it back to A.I. control to get around the issue for now. Hope someone figures out a way to get the A.I. to do it itself.

But other than that i haven't come across an issue worth reporting. I also haven't played a lot in any one campaign. Furthest i got so far was my Horde campaign up to turn 16. So i haven't yet encountered a situation like someone above who had the A.I. gathering armies where they can't cross because they aren't fliers or anything. Will keep playing though.

TheDog

I have to be boring and repeat myself.
Frostion, WoW, just WoW !!!

I was doing so well and did not have a crash until now.
I dont know if it can be repeated.

IllegalStateException - Cannot have more hits than the number of die rolls.

This happened when the AI Undead was doing their turn. (sadly no screenie)

WoW-T27.tsvg
autosave_round_odd.tsvg
autosave_round_even.tsvg

Trevan

@TheDog That should already be fixed. I'm not sure if a release has the fix or if you have to use a prerelease.

TheDog

My
Engine version is 2.0.20306

Game version is 0.1.2

LaFayette

A 2.1 was just released that has the latest fixes for this map.

https://triplea-game.org/download/

TheDog

@Frostion
Playing Undead, I dont appear to be able to place Skeletons with Sevis?

TheDog

Turn 25
I was doing so well, with no errors till this one.
Noted the AI has not been defending their capitals with too many units, thanks Devs.

2.1.20365: CasualtySelector#selectCasualties:136 - IllegalStateException

Log Message

java.lang.IllegalStateException: sortedTargetsToPickFrom must have the same size as targetsToPickFrom list

TripleA Version

2.1.20365

Java Version

11.0.6

Operating System

Windows 10

Stack Trace

java.lang.IllegalStateException: java.lang.IllegalStateException: sortedTargetsToPickFrom must have the same size as targetsToPickFrom list
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:600)
	at java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:678)
	at java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:737)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateParallel(ReduceOps.java:919)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
	at games.strategy.triplea.odds.calculator.ConcurrentBattleCalculator.calculate(ConcurrentBattleCalculator.java:234)
	at games.strategy.triplea.ai.pro.util.ProOddsCalculator.callBattleCalc(ProOddsCalculator.java:224)
	at games.strategy.triplea.ai.pro.util.ProOddsCalculator.callBattleCalc(ProOddsCalculator.java:200)
	at games.strategy.triplea.ai.pro.util.ProOddsCalculator.calculateBattleResults(ProOddsCalculator.java:133)
	at games.strategy.triplea.ai.pro.util.ProOddsCalculator.calculateBattleResults(ProOddsCalculator.java:116)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.determineIfMoveTerritoriesCanBeHeld(ProNonCombatMoveAi.java:423)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.doNonCombatMove(ProNonCombatMoveAi.java:98)
	at games.strategy.triplea.ai.pro.AbstractProAi.move(AbstractProAi.java:135)
	at games.strategy.triplea.ai.AbstractAi.start(AbstractAi.java:514)
	at games.strategy.engine.framework.ServerGame.waitForPlayerToFinishStep(ServerGame.java:537)
	at games.strategy.engine.framework.ServerGame.runStep(ServerGame.java:407)
	at games.strategy.engine.framework.ServerGame.startGame(ServerGame.java:297)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.launchInternal(LocalLauncher.java:61)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.launchInternal(LocalLauncher.java:34)
	at games.strategy.engine.framework.startup.launcher.AbstractLauncher.lambda$launch$0(AbstractLauncher.java:16)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.IllegalStateException: sortedTargetsToPickFrom must have the same size as targetsToPickFrom list
	at games.strategy.triplea.delegate.battle.casualty.CasualtySelector.selectCasualties(CasualtySelector.java:136)
	at games.strategy.triplea.delegate.battle.Fire.selectCasualties(Fire.java:248)
	at games.strategy.triplea.delegate.battle.Fire.selectCasualties(Fire.java:238)
	at games.strategy.triplea.delegate.battle.Fire$2.execute(Fire.java:117)
	at games.strategy.triplea.delegate.ExecutionStack.execute(ExecutionStack.java:34)
	at games.strategy.triplea.delegate.battle.MustFightBattle.fight(MustFightBattle.java:722)
	at games.strategy.triplea.odds.calculator.BattleCalculator.calculate(BattleCalculator.java:114)
	at games.strategy.triplea.odds.calculator.ConcurrentBattleCalculator.lambda$calculate$4(ConcurrentBattleCalculator.java:222)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:952)
	at java.base/java.util.stream.ReduceOps$ReduceTask.doLeaf(ReduceOps.java:926)
	at java.base/java.util.stream.AbstractTask.compute(AbstractTask.java:327)
	at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

WoW-U25.tsvg
autosave_round_odd.tsvg
autosave_round_even.tsvg

Frostion

Wow! 25 runds! I made the map and have never reached that many rounds Are you playing both Undead and Trolls? Or only Undead?

Please give me a save of the last and final round you play so that I may study it. I would like to see how long it takes for you to level up and how the resources are balanced. To me it seems that you got too many special resources? More than you need? Are some in abundance and other s not?

Does the skeletons still not work? I think you have to build them at a factory where you hero is located. Either when he drops by or when he resurrects there.

PS: Hope the devs could evaluate this error. Have not seem that before.