Fixed Scenarios from the Repository
-
@ff03k64 said in Fixed Scenarios from the Repository:
Did these get fixed or put in the repo?
I am also having an issue with it and would like some feedback to know if it is me or something else.
https://github.com/triplea-maps/new_world_order1915lebowski/issues/4Yea i just tried it. Says can't find it. that usually means a naming issue.
Edit
so mapName needs to be the same as the one in "downloaded maps" I haven't checked the xml to see if it is.
You probably already know that though
-
-
@ff03k64 right on I just checked xml and it looks ok. Lebowski isn't around anymore and Idk if any nwo people are either. Not many old timers around these days.
-
@beelee So if i actually make that PR official, you think it will fix it?
-
@beelee wow that's a trip. the only thing I see different is a minus sign - instead of plus +
I've tried that before though and it didn't seem to matter.
-
@ff03k64 said in Fixed Scenarios from the Repository:
@beelee So if i actually make that PR official, you think it will fix it?
yea idk. Can you get it to run in local for you with the fix ?
-
@beelee said in Fixed Scenarios from the Repository:
@beelee wow that's a trip. the only thing I see different is a minus sign - instead of plus +
I've tried that before though and it didn't seem to matter.
huh?
-
@ff03k64 ahh I missed the underscore. I'll give it a try
-
@beelee said in Fixed Scenarios from the Repository:
@ff03k64 said in Fixed Scenarios from the Repository:
@beelee So if i actually make that PR official, you think it will fix it?
yea idk. Can you get it to run in local for you with the fix ?
YEah, i guess that should be easy to test. I was making other changes, so I did something else to get it to work that I can't do on Github (to my knowledge anyway), so i didn't even think of testing that change here, do'h
-
right on looks as if you got it on the run
Good job -
@ff03k64 said in Fixed Scenarios from the Repository:
@RogerCooper I see one cavalry image that was missing for Americans? Does that sound right?
That looks right. I fixed other missing images.
-
@RogerCooper I was looking through your zip. What other images were missing?
-
@ff03k64 I don't remember exactly. With the way TripleA runs now, it easy to find which images are missing.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login