Fixed Scenarios from the Repository
-
I have fixed missing image problems with New World Order1915 Lebowski and Pacific. How do I upload the corrected versions to the repository?
-
Navigate to repository: https://github.com/triplea-maps/new_world_order1915lebowski
Click fork button:
Noticate the URL is different and should have your name in it.
Navigate to the folder where you want to add files, click upload files:
Select the file to upload and select 'create a new branch':
Then if that's the only file, add a change summary and click create pull request:
IF there are more files, go back to your fork, and click "branches", eg:
Select the branch you just created:
Be careful as you navigate now that the URL continues to have your branch name in it, if not then go back and select your branch. Now browse to where you want to upload files and click upload files. Repeat this process until you have them all uploaded.
Once done, head back to the 'main repository': https://github.com/triplea-maps/new_world_order1915lebowski
There should be a some convenience buttons avialable to you to create pull requests from your branch, eg (notice the green buttons):
Once the pull request is made, map admins will review it and merge it, then it'll be part of the map.
-
1915 has 1 ottoman factory that belong to the enemy.
it also does not save unplaced units, and does not alert the player not to overbuild.
-
1915 cannot buy factories
only some nations can -
Did these get fixed or put in the repo?
I am also having an issue with it and would like some feedback to know if it is me or something else.
https://github.com/triplea-maps/new_world_order1915lebowski/issues/4open Map not playing for me #4
-
@RogerCooper I see one cavalry image that was missing for Americans? Does that sound right?
-
I had issues with this map running for me. I think it has a naming issue. Can anyone try to download it and see if they get any errors and post them here? I would like to know if it is just me, since when I am trying to fix it, I am having other issues with it that I am not having with any other maps. My hope is that that means it is just me.
-
@Lord-Bevan I am guessing that ottoman factory belonging to the enemy is intentional. I know that in WW2 maps anyway, that is usually a French territory, so my guess is that it is a French factory on purpose so that if they capture it, they can build units there. If we know it is supposed to be Ottoman, I can probably change it, but unless we know it, I am going to assume it is deliberate.
-
@ff03k64 said in Fixed Scenarios from the Repository:
Did these get fixed or put in the repo?
I am also having an issue with it and would like some feedback to know if it is me or something else.
https://github.com/triplea-maps/new_world_order1915lebowski/issues/4Yea i just tried it. Says can't find it. that usually means a naming issue.
Edit
so mapName needs to be the same as the one in "downloaded maps" I haven't checked the xml to see if it is.
You probably already know that though
-
-
@ff03k64 right on I just checked xml and it looks ok. Lebowski isn't around anymore and Idk if any nwo people are either. Not many old timers around these days.
-
@beelee So if i actually make that PR official, you think it will fix it?
-
@beelee wow that's a trip. the only thing I see different is a minus sign - instead of plus +
I've tried that before though and it didn't seem to matter.
-
@ff03k64 said in Fixed Scenarios from the Repository:
@beelee So if i actually make that PR official, you think it will fix it?
yea idk. Can you get it to run in local for you with the fix ?
-
@beelee said in Fixed Scenarios from the Repository:
@beelee wow that's a trip. the only thing I see different is a minus sign - instead of plus +
I've tried that before though and it didn't seem to matter.
huh?
-
@ff03k64 ahh I missed the underscore. I'll give it a try
-
@beelee said in Fixed Scenarios from the Repository:
@ff03k64 said in Fixed Scenarios from the Repository:
@beelee So if i actually make that PR official, you think it will fix it?
yea idk. Can you get it to run in local for you with the fix ?
YEah, i guess that should be easy to test. I was making other changes, so I did something else to get it to work that I can't do on Github (to my knowledge anyway), so i didn't even think of testing that change here, do'h
-
right on looks as if you got it on the run
Good job -
@ff03k64 said in Fixed Scenarios from the Repository:
@RogerCooper I see one cavalry image that was missing for Americans? Does that sound right?
That looks right. I fixed other missing images.
-
@RogerCooper I was looking through your zip. What other images were missing?
