Help: National Objectives are removed when editing name of map file

Jason Green-Lowe

Panther, Cernel, I appreciate your help, but your statements are not clear enough for me to take action based on those statements.

I am willing to make whatever changes are needed, but I need you to tell me very specifically what line to change in what document.

For example, how do I change the name of the folder that is created when someone downloads the map from tripleA?

Panther

@Jason-Green-Lowe

Again: The current map-zip file that you can download directly from your repo :

is working fine, when placed into your downloadedMaps folder.

Please try that out to reproduce that!

The new problem is somewhere else.

Cernel

@Jason-Green-Lowe A way it shoul work is all of this:

The name of the GitHub repository is "https://github.com/triplea-maps/1941balancedmod".
The info name within the WW2v3-1941balmod.xml game file is equal to World War II v3 1941 Balanced Mod.
The mapName property value within the WW2v3-1941balmod.xml game file is equal to 1941balancedmod.
Every line within the https://github.com/triplea-maps/1941balancedmod/blob/master/map/objectives.properties starts as World_War_II_v3_1941_Balanced_Mod.

As long as everything is as above (as it looks like it is), you should not be in need to make any changes, for the matter at hand, within your https://github.com/triplea-maps/1941balancedmod repository, and everyone downloading the map thorugh TripleA from that repository should be fine. If you are not, chances is that you have some other game file somewhere that you are currently selecting, so just clean (delete everything inside) your "downloadedMap" folder, then download your map through TripleA (like anyone else).

Panther

@Jason-Green-Lowe

Now the current problem is that when using the ingame downloader the folder

"1941balancedmod-master"

is zipped under

"\world_war_ii_v3_1941_balanced_mod-master.zip"

So there is an incorrect structure:

\downloadedMaps\world_war_ii_v3_1941_balanced_mod-master.zip\1941balancedmod-master\

I have currently no idea where this subordinate "world_war-ii_v3_1941_balanced_mod" derives from.

This is causing the problem. Your repo and XML seem to be fine now.

Jason Green-Lowe

I have currently no ides where this subordinate "world_war-ii_v3_1941_balanced_mod" dervives from.
This is causing the problem.

OK, well, I agree. Who would know the answer to that question?

Jason Green-Lowe

@Cernel

Thank you; that information is in the format I am looking for, but it was not successful. I uninstalled tripleA, deleted my entire downloadedMaps folder as well the folder above that with the options.cache, and reinstalled and downloaded everything from scratch and got the same error.

I believe the problem is as Panther said: the folder name is wrong in the zip, but I don't know what sets the folder name for the zip or how to change it.

Panther

@Jason-Green-Lowe

This is how it should look like:

\downloadedMaps\1941balancedmod-master.zip\1941balancedmod-master\

Jason Green-Lowe

OK, that's fine, but I don't know how to cause TripleA to rename that folder when a user downloads the map from TripleA. Who would know that?

Panther

@Jason-Green-Lowe

No idea at this moment, sorry. I have just checked the yaml and your repo - that looks all fine.
I have never seen this before.

Let's hope that a developer has an idea - or that one of us has an idea when thinking further about it...

Cernel

@Jason-Green-Lowe I'm not seeing anything by which that may be expected to happen. I suggest opening a problem report.
https://github.com/triplea-game/triplea/issues

I suggest you don't make any more changes until someone get back to you there. The only unusual thing I see is that you are using the image of another map repository for download list display.

Cernel

@Cernel said in Help: National Objectives are removed when editing name of map file:

The only unusual thing I see is that you are using the image of another map repository for download list display.

As I said, I believe it should not be related to any actual problem, but you should change the current 2174
img: https://raw.githubusercontent.com/triplea-maps/world_war_ii_v3/master/description/TripleA_ww2v3_1941_mini.png
line in
https://github.com/triplea-game/triplea/blob/master/triplea_maps.yaml
to
img: https://raw.githubusercontent.com/triplea-maps/1941balancedmod/master/description/TripleA_ww2v3_1941_mini.png.

Probably whoever merged your pull request overlooked it or it would have asked you the same.

Cernel

Thinking about it some more, I assume that the main folder name is generated from the "mapName" in the https://github.com/triplea-game/triplea/blob/master/triplea_maps.yaml, by making it all lowercase and substituting spaces with underscores.

So, in your case, if I'm guessing right, you should change line 2170 from:
- mapName: World War II v3 1941 Balanced Mod
to:
- mapName: 1941BalancedMod.

OR

Change your repository name and the "mapName" property value inside the game file to world_war_ii_v3_1941_balanced_mod.
Change line 2172 from:
url: https://github.com/triplea-maps/1941balancedmod/archive/master.zip
to:
url: https://github.com/triplea-maps/world_war_ii_v3_1941_balanced_mod/archive/master.zip.

Regardless, I believe the way you are going is at least unpolished. The map name that is shown to users in the moment they download should be fundamentally the same as the actual name of the map, as specified in the mapName property. Having one as "World War II v3 1941 Balanced Mod" and the other one as "1941balancedmod" seems inconsistent to me, regardless of any problems (just my opinion, as I don't actually know if there are rules about map naming documented anywhere and I guess what you proposed was considered good enough, since your changes have been merged, thus accepted).

Between the alternatives I'm suggesting, especially to clarify this map is derived from v3 (instead of v6 or something else), I advise for the second one.

LaFayette

The way the game engine finds Map XML from map name is a shit show. I'm sorry it's still the case and has not been updated to be something more reasonable.

@Jason-Green-Lowe the map should be working now, I did some testing and downloaded it. The missing piece is that the map-name option, the repository name, and the name in triplea-maps.yaml all need to line up. The triplea-maps.yaml name can have upper case letters and spaces instead of underscores, but otherwise it needs to match the repository name which then needs to match the XML 'mapName' property.

To get things working I renamed both the repository and the 'mapName' properties to "world_war_ii_v3_1941_balanced_mod"

Jason Green-Lowe

Wonderful! It works now on my end -- thank you so much for fixing the problem.