2.6 Testing (Report 2.6 problems here)

[Roybot]

Just downloaded/installed Pre Release version 2.6.805 (replacing 2.6.792) and the "ALL" button is now present. Thanks.

[beelee]

On 2.6.801 I used a save made on 2.5 and all the National Objectives are screwed up. Most didn't show up at all and some showed up incorrectly. Also I have "Rail" units that should place at start of CombatMove but don't.

Unfortunately i didn't make a separate save for 2.5, so i can't post the same game. This is the 2.6 one Game 20 EXP 7.643 2.6.801 Pre.tsvg
Japan and USA both didn't get any NO's or Rail units placed. Also, some Notifications didn't show up either.

Here's a quick 2.5 save that shows the rail units and Objectives showing up.
2.5 Example Save.tsvg

Edit
I was able to find a 2.5 in Auto Save. This should make for easier comparison. Run this in 2.5 2.5 Auto Save Test Recreate.tsvg

And this in 2.6 2.6auto Save Test Recreate.tsvg

Note the Ojectives panel differences and if you wanna bomb through Germany you'll see how the Rail units and Notifications don't show up.

[Myrd]

@beelee

Thanks, I am able to reproduce with your 2.5 save game - I can see that for example none of the American NOs are met in 2.6, but most of them are in 2.5. I'll take a look.

[Myrd]

@beelee This should be fixed now and should be available in the next prerelease (https://github.com/triplea-game/triplea/releases/tag/2.6.812 - once it's available).

Can you test again and confirm that the issues you've observed are all resolved? (Once the above prerelease is available.)

[beelee]

@myrd with 2.6.813 the objectives now work correctly. However, the "Rail" units and Notifications don't show up. Use this in 2.5 2.5 Auto Save Test Recreate B.tsvg and you'll notice at the start of Russia's combat move 2 Rail and 1 Europe Rail in Russia.

And at the end of Japan's turn this Notification.

[Myrd]

@beelee

Thanks, should be fixed too. https://github.com/triplea-game/triplea/releases/tag/2.6.814

[beelee]

@myrd Heh heh You're just kickin ass wherever you go lol
Works like a charm Rock on !

[beelee]

No problem just want to know if the no u-turn sign means no retreat ?

Thanks

[Myrd]

@beelee Yes, that's right.

[beelee]

USA took over an Italian Major Factory and it's supposed to turn into a Minor Factory and didn't. 2.5 Auto Save Test Recreate C.tsvg

[beelee]

Germany conquered Belarus and the Landmines owned by "Changer" who only has 1 turn at Game start. turned into white squares.

I hit undo and they turn red

Here they are before the attack

Changer is Allied to all Players so his units are not conquered and do not cause conflict with whoever owns the TTy there in, in case that helps at all

2.5 Auto Save Test Recreate D.tsvg

Edit
Yea, so it looks like what's happening is the Changer units are "changing" lol, to whoever conqueres them and since there aren't images for them they get a generic one.

Edit 2
@Myrd so i tracked back to 2.6.800 and the above problems still exist. 2.5 Auto Save Test Recreate E.tsvg
Start with last ANZAC turn and you'll see how the Green circle changes in Guam.
I wonder if this has anything to do with PR #10515 ? Where the missing unit icons were introduced ? or changed ?

Unfortunately i can't go back any further on prereleases. Should I open a git issue for this as well ? My guess is that the above are probably all related.

[Myrd]

@beelee I actually have a strong suspicion that it's the same bug that's causing the major factory to not be downgraded to minor. Basically, the game isn't processing destruction/capturing of units correctly.

If it's the same bug, the root cause is https://github.com/triplea-game/triplea/pull/9962, and the author of that PR is working on a fix. Let's wait for that to see if it resolves all these issues.

Thanks for all the bug reports!

[beelee]

Total Resources don't show up in 2.6.814

Here's 2.5

[Myrd]

@beelee The resource totals should be fixed.

For the unit issues, can you check whether they're all fixed on the following prerelease: https://github.com/triplea-game/triplea/releases/tag/2.6.836 ?

[beelee]

@myrd yea everything is working correctly now, except resource totals has some redundancy

Edit
2.6.838

[beelee]

@beelee it also does it under Players

Edit
It's also counting Italy when it shouldn't

[TheDog]

The Players tab is looking very crowded.

Would the tech table be better in its own panel, with a ctrl+T, a bit like the Politics Panel?

Then the normal Flag and Player faction name could be on the left and the Tech across the top. (This is in player order, just like the Players tab)

[Myrd]

Looks like it's indeed a 2.6 bug that 1-player alliances get shown. Being fixed here: https://github.com/triplea-game/triplea/pull/10571

[beelee]

Noticing an old problem. Sometimes scroll freezes and I have to click anywhere and it'll start working again. I don't remember the specifics, just that it used to happen. Couple years ago or so anyway

Edit
On Ubuntu 20.04 if it matters

[beelee]

2.6.838 is giving incorrect supportAttachment. Here is 2.5 working correctly
2.5 correct support .tsvg
The Waffen_Oberst_4 provides an extra roll to the Waffen_Panzer and the Panzer gives the Oberst an extra roll as well for a total of 6 rolls.

In 2.6, If I take a hit in the first rd of combat, the extra roll or rolls is negated depending on if it's 2 hits or 1.
2.6 Wrong Support.tsvg

If not, it works correctly. 6 dice are rolled.
2.6 Correct Wrong Support.tsvg