2.6 Testing (Report 2.6 problems here)

[beelee]

@myrd with 2.6.813 the objectives now work correctly. However, the "Rail" units and Notifications don't show up. Use this in 2.5 2.5 Auto Save Test Recreate B.tsvg and you'll notice at the start of Russia's combat move 2 Rail and 1 Europe Rail in Russia.

And at the end of Japan's turn this Notification.

[Myrd]

@beelee

Thanks, should be fixed too. https://github.com/triplea-game/triplea/releases/tag/2.6.814

[beelee]

@myrd Heh heh You're just kickin ass wherever you go lol
Works like a charm Rock on !

[beelee]

No problem just want to know if the no u-turn sign means no retreat ?

Thanks

[Myrd]

@beelee Yes, that's right.

[beelee]

USA took over an Italian Major Factory and it's supposed to turn into a Minor Factory and didn't. 2.5 Auto Save Test Recreate C.tsvg

[beelee]

Germany conquered Belarus and the Landmines owned by "Changer" who only has 1 turn at Game start. turned into white squares.

I hit undo and they turn red

Here they are before the attack

Changer is Allied to all Players so his units are not conquered and do not cause conflict with whoever owns the TTy there in, in case that helps at all

2.5 Auto Save Test Recreate D.tsvg

Edit
Yea, so it looks like what's happening is the Changer units are "changing" lol, to whoever conqueres them and since there aren't images for them they get a generic one.

Edit 2
@Myrd so i tracked back to 2.6.800 and the above problems still exist. 2.5 Auto Save Test Recreate E.tsvg
Start with last ANZAC turn and you'll see how the Green circle changes in Guam.
I wonder if this has anything to do with PR #10515 ? Where the missing unit icons were introduced ? or changed ?

Unfortunately i can't go back any further on prereleases. Should I open a git issue for this as well ? My guess is that the above are probably all related.

[Myrd]

@beelee I actually have a strong suspicion that it's the same bug that's causing the major factory to not be downgraded to minor. Basically, the game isn't processing destruction/capturing of units correctly.

If it's the same bug, the root cause is https://github.com/triplea-game/triplea/pull/9962, and the author of that PR is working on a fix. Let's wait for that to see if it resolves all these issues.

Thanks for all the bug reports!

[beelee]

Total Resources don't show up in 2.6.814

Here's 2.5

[Myrd]

@beelee The resource totals should be fixed.

For the unit issues, can you check whether they're all fixed on the following prerelease: https://github.com/triplea-game/triplea/releases/tag/2.6.836 ?

[beelee]

@myrd yea everything is working correctly now, except resource totals has some redundancy

Edit
2.6.838

[beelee]

@beelee it also does it under Players

Edit
It's also counting Italy when it shouldn't

[TheDog]

The Players tab is looking very crowded.

Would the tech table be better in its own panel, with a ctrl+T, a bit like the Politics Panel?

Then the normal Flag and Player faction name could be on the left and the Tech across the top. (This is in player order, just like the Players tab)

[Myrd]

Looks like it's indeed a 2.6 bug that 1-player alliances get shown. Being fixed here: https://github.com/triplea-game/triplea/pull/10571

[beelee]

Noticing an old problem. Sometimes scroll freezes and I have to click anywhere and it'll start working again. I don't remember the specifics, just that it used to happen. Couple years ago or so anyway

Edit
On Ubuntu 20.04 if it matters

[beelee]

2.6.838 is giving incorrect supportAttachment. Here is 2.5 working correctly
2.5 correct support .tsvg
The Waffen_Oberst_4 provides an extra roll to the Waffen_Panzer and the Panzer gives the Oberst an extra roll as well for a total of 6 rolls.

In 2.6, If I take a hit in the first rd of combat, the extra roll or rolls is negated depending on if it's 2 hits or 1.
2.6 Wrong Support.tsvg

If not, it works correctly. 6 dice are rolled.
2.6 Correct Wrong Support.tsvg

[Myrd]

@beelee said in 2.6 Testing (Report 2.6 problems here):

2.6.838 is giving incorrect supportAttachment. Here is 2.5 working correctly
2.5 correct support .tsvg
The Waffen_Oberst_4 provides an extra roll to the Waffen_Panzer and the Panzer gives the Oberst an extra roll as well for a total of 6 rolls.

In 2.6, If I take a hit in the first rd of combat, the extra roll or rolls is negated depending on if it's 2 hits or 1.
2.6 Wrong Support.tsvg

If not, it works correctly. 6 dice are rolled.
2.6 Correct Wrong Support.tsvg

In your "2.6 Wrong Support.tsvg" you're defending with "Germans defend with 1 Waffen_Arty, 1 Waffen_Oberst_3 and 2 waffen_infantrys"

There's no Panzer and the Arty doesn't give support to Oberst. Here's a save right before combat with panzer and oberst defending and I'm getting the same results on 2.5 and 2.6: 2.5-correct-support-test.tsvg

Let me know if I'm missing something.

[beelee]

@myrd here's one with the panzer. i saved before combat so you can run multiple battles. 2.6 Wrong Support A.tsvg

So if there are no German casualties they roll 6 dice. If there are German casualties, they only roll 5. There are multiple Oberst's that provide an extra roll depending on who there paired with. And the Oberst in turn receives an extra roll. So 2 extra rolls total. Take the Oberst as a casualty, so it won't give support 2nd rd of battle because you need all 4 units present to get the bonuses according to the rules.

Oberst 4 is for Panzer
Oberst 3 is for Arty, PnzrGrndr and Para
Oberst 2 is for Inf

All are Waffen units. They should be getting the extra rolls whether there are casualties in the first rd of battle or not.

Here's 2.5 before combat.2.5 Correct support A.tsvg
It gets 6 rolls regardless of 1st rd casualties.

[Myrd]

@beelee said in 2.6 Testing (Report 2.6 problems here):

@myrd here's one with the panzer. i saved before combat so you can run multiple battles. 2.6 Wrong Support A.tsvg

So if there are no German casualties they roll 6 dice. If there are German casualties, they only roll 5. There are multiple Oberst's that provide an extra roll depending on who there paired with. And the Oberst in turn receives an extra roll. So 2 extra rolls total. Take the Oberst as a casualty, so it won't give support 2nd rd of battle because you need all 4 units present to get the bonuses according to the rules.

Oberst 4 is for Panzer
Oberst 3 is for Arty, PnzrGrndr and Para
Oberst 2 is for Inf

All are Waffen units. They should be getting the extra rolls whether there are casualties in the first rd of battle or not.

Here's 2.5 before combat.2.5 Correct support A.tsvg
It gets 6 rolls regardless of 1st rd casualties.

Oh, I see what you mean - the number of rolls should be based on the units & supports prior to units being killed. Whereas in 2.6, there's a bug where it seems to consider supports for purposes of # of rolls based on the state after casualties. OK, agree that this regressed, I'll file a bug on GitHub and we can follow up from there.

[beelee]

2.6.838 doesn't have Game "Notes" in the upper right by "Actions" "Players" etc ... that 2.5 does.

2.6

2.5

@Myrd do you want me to make a Git issue ?