💥 1941 Global Command Decision - Official Thread

wc_sumpton

Now when placing any "Bid" purchase unit a production unit needs to be present. This is not only for sea unit, but also for land unit. When trying to place the Armor-Lgt unit Brest, a message pops up saying that placement has been cancelled because of missing production.

In 2.5 this does not happen as I am allowed to place in Brest.

This seem like a major change to how Bib placement was working. This requirement for production affects all maps. Tested on World War II Classic, and could only place Bid units at production locations, which is quite different the 2.5.

So I think that the check for production must be removed.

Cheers...

beelee

@wc_sumpton should this be ropened ? Myrd closed as fixed.

https://github.com/triplea-game/triplea/issues/12376

TheDog

@wc_sumpton
So I have been testing using 2.5 & WW2 v3 1941 and I have come to the same conclusion as you, that the check in 2.6 for factories/production should be removed.

Cernel says
https://forums.triplea-game.org/topic/785/bid-explanation-resolved/11

His points are

You can place infinite per territory or sea zone
You can place in any territory you own (no factory or anything required)
You can place in any friendly sea zone with ship of the same owner already in it

I will raise our findings on GitHub, thanks all!

@beelee Yes I will reopen it

TheDog

@beelee
I dont appear to be able to reopen it, could you do the honours please!

beelee

@thedog

Ok I will reference here.

Edit
Ahh I see you already referenced it

TheDog

Myrd/asvitkine has done another very fast turnaround fix, he has asked us to test it.

TripleA 2.6.14661current release
https://github.com/triplea-game/triplea/releases

Currently it does not place units in a territory with no 'factory' as it should, it errors with;

Screenshot 2024-03-03 081944.png

However it does allow the placement of a 'factory'.

Please test more and also confirm the above.
.

This is a modified list of what Bid & Bid Placement can/should do.

You can;

buy upto the maxBuiltPerPlayer limit
place infinite or stacking limit units per territory or sea zone
place in any territory you own (no 'factory' required)
place in any friendly sea zone with ship(s) of the same owner already in it

wc_sumpton

@thedog, @Myrd

FWIW, the problem seems to stem from "requiresUnits" and "Unit Placement Restrictions".

For land units, 2.5 seem to not use this restriction, but the other options, "unitPlacementRestrictions", "unitPlacementOnlyAllowedIn" and "canOnlyBePlacedInTerritoryValuedAtX" are enforced, while sea unit still seemed to be restricted by "requiresUnits".

It looks like 2.6 uses the same requirements for both bid and regular placement, "requiresUnits" was added to land units during bid placement, and this is causing all the problems.

"requiresUnits" should not interfere with unit bid placement, but "unitPlacementRestrictions", "unitPlacementOnlyAllowedIn" and "canOnlyBePlacedInTerritoryValuedAtX" enforced.

Noted: With GCD sea zones have ownership like land territories, so the requiring the presents of another unit should not mater unless the only units are non-allied unit, which should still block placement.

Cheers...

wc_sumpton

@thedog, @Myrd

I roll back to 2.6.14656. Removed "requiresUnits" and the game worked as intended. I was able to place land unit in any owned territory, I was able to place a bunker with it restrictions, and was able to place a sea unit with a sub.

Question: Should "requiresUnits" be ignored during bid placement or should it be up to the map makers to remove and reinstate restrictions?

Cheers...

TheDog

Interesting question.

As I dont play PvP and would not use Bids Im not the person to answer the question. I would say keep it the same as 2.5 so players know what they are getting,

I have raise the issue again on GitHub.
https://github.com/triplea-game/triplea/issues/12376

wc_sumpton

@thedog said in 1941 Global Command Decision - Official Thread:

As I dont play PvP and would not use Bids Im not the person to answer the question.

Understood, but as a very GOOD map maker, and this problem could be corrected within the xml, your say would be very valuable!

Cheers...

TheDog

An xml property would be good to choose between the two, but i'm conscious of Myrds time.

wc_sumpton

@thedog said in 1941 Global Command Decision - Official Thread:

An xml property would be good to choose between the two, but i'm conscious of Myrds time

You misunderstood. "requiresUnits" can be changed the same way "createsResourcesList" is done for upkeep.

Try this: Roll back TripleA to 2.6.14656, then add the following to you xml (after "Always_True" condition):

<!-- Remove requriements for sea units -->
<attachment name="triggerAttachment_Remove_requiresUnits_All_Seas" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Always_True"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$All-Sea$"/>
	<option name="unitProperty" value="requiresUnits" count="-reset-"/>
	<option name="when" value="before:GermanyTechActivation"/>
</attachment>

<!-- Add Industry-Hvy to all sea units -->
<attachment name="triggerAttachment_Restore_Industry-Hvy_All_Seas" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Always_True"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="$All-Sea$"/>
	<option name="unitProperty" value="requiresUnits" count="-reset-Industry-Hvy"/>
	<option name="uses" value="1"/>
	<option name="when" value="before:GermanyCombatMove"/>
</attachment>

<!-- Add Industry Med to Convoy and Destroyer -->
<attachment name="triggerAttachment_Restore_Industry-Med_2_Units" attachTo="Germany" javaClass="TriggerAttachment" type="player">
	<option name="conditions" value="conditionAttachment_Always_True"/>
	<option name="unitAttachmentName" value="UnitAttachment" count="unitAttachment"/>
	<option name="unitType" value="Convoy:Destroyer"/>
	<!-- Adding so don't use reset -->
	<option name="unitProperty" value="requiresUnits" count="Industry-Med"/>
	<option name="uses" value="1"/>
	<option name="when" value="after:GermanyCombatMove"/>
</attachment>

Don't change anything for air or land units. This works!!

Cheers...

TheDog

Thanks I will try this tomorrow.

TheDog

@wc_sumpton
Now that's clever!!! :smiling_face_with_halo:

Thanks for the code, as it was good to see it working.

More on Bid Placement here
https://github.com/triplea-game/triplea/issues/12376

wc_sumpton

@thedog and all;

Should "territoryEffect" option "unitsNotAllowed" affect placement / bid placement?

Using GCD if a Base-Camp were placed in Prypriat which has a "marsh" "territoryEffect" with "unitsNotAllowed" equals "Inf-Motorized", the "Inf-Motorized" can still be placed there.

Cheers...

TheDog

As always you make a very good point.

I too have tested "marsh" "territoryEffect" and I concur.

ezgaming

@wc_sumpton said in 1941 Global Command Decision - Official Thread:

@thedog, @Myrd

OK please forgive me - I had some surgery earlier today and am on some heavy meds.

I was hoping to identify a good long-term location and/or learn how to get the latest version of the TripleA game as well as the newest version of 1941 GCD

THANK YOU

TheDog

@ezgaming
Take it easy and recover, by playing TripleA

Latest TripleA is here (this does not change)
https://github.com/triplea-game/triplea/releases

Latest 1941GCD
Remove the old version and reinstall the new version by;
TripleA Downloads> Installed tab> Highlight 1941 Global Command Decision> Remove
Once removed on New Maps tab and reinstall 1941 Global Command Decision

The 1st post in this thread will always have what you need.
Link to 1st post that has the latest 1941GCD download link and to get the latest TripleA version
https://forums.triplea-game.org/topic/3326/1941-global-command-decision-official-thread

TheDog

@ezgaming (this post is a duplicate of the one in Development as ezgaming might not read it)

Myrd/asvitkine has been working this past week to fix TripleA 2.6 Bid & Bid Placement, you can now;

buy units upto the maxBuiltPerPlayer limit
place infinite or stacking/placementLimit units per territory or sea zone
place land units in any territory you own (no 'factory' required)
place ship units in any friendly sea zone with ship(s) of the same owner already in it
Construction/immobile units placed obeys upgrade rules and canOnlyBePlacedInTerritoryValuedAtX
Units can only be placed if territoryEffect unitsNotAllowed allows them

Note this is probably different to the way that 2.5 Bid & Bid Placement works and the 2.6 manual should reflect the above.

ezgaming

@thedog THANK YOU !