Reference the PU Value of a Territory in Triggers?

wc_sumpton

Try taking out the 'when' option in the condition statement, you may also consider removing 'players' since attachTo defines which player is affected by the condition.

Cheers...

Jason Green-Lowe

@wc_sumpton The stepProperty trick worked, thanks!

Jason Green-Lowe

@wc_sumpton Removing the players and when statements from the condition did not help. When I use:

    <attachment foreach="$TwoValueTerritories$^$Players$:$Phases$" name="conditionAttachmentMakeRailroad@Players@In@TwoValueTerritories@" attachTo="@Players@" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
      <option name="directPresenceTerritories" value="@TwoValueTerritories@" count="1"/>
      <option name="unitPresence" value="factory_minor:factory_major" count="1"/>
    </attachment>
    
    <attachment foreach="$TwoValueTerritories$^$Players$:$Phases$" name="triggerAttachmentMakeRailroad@Players@In@TwoValueTerritories@" attachTo="@Players@"
    javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
      <option name="conditions" value="conditionAttachmentMakeRailroad@Players@In@TwoValueTerritories@"/>
      <option name="when" value="after:@Phases@"/>
      <option name="players" value="@Players@"/>
      <option name="placement" value="@TwoValueTerritories@:railroad" count="2"/>
    </attachment>

I get this error message:

Could not parse:file:///C:/Users/jason/triplea/downloadedMaps/bbr5/games/bbr5.xml, Missing property definition for option 'directPresenceTerritories' in attachment 'conditionAttachmentMakeRailroadGermansInNormandy Bordeaux'  games.strategy.engine.data.gameparser.GameParseException: Missing property definition for option 'directPresenceTerritories' in attachment 'conditionAttachmentMakeRailroadGermansInNormandy Bordeaux'

I have tested the code with a one-word territory name, and the space in the name does not seem to be the problem; I get the same error message for, e.g., Denmark.

Jason Green-Lowe

@wc_sumpton Never mind, I see the problem -- I had my condition using "TriggerAttachment" instead of "RulesAttachment." No wonder it couldn't find "DirectPresenceTerritories."

Jason Green-Lowe

@wc_sumpton I think this is going to work! Thanks for all the help.

wc_sumpton

@jason-green-lowe

Good find on the 'RulesAttachment' and 'TriggerAttachment'. Happy to hear everything is working.

Cheers...

Jason Green-Lowe

@wc_sumpton All right, one last issue on this feature. I also want to remove all the railroads from the map at the end of each player's turn, but the code below does not seem to have any effect. It runs OK, but it does nothing. Any idea why?

    <attachment name="triggerAttachmentGermansDestroyRailroad" attachTo="Germans" javaClass="games.strategy.triplea.attachments.TriggerAttachment" type="player">
      <option name="when" value="after:germansNonCombatMove"/>
      <option name="removeUnits" value="all:railroad" count="20"/>
    </attachment>

wc_sumpton

@jason-green-lowe

May need a condition to activate. TripleA engine can sometimes be tricky about such things.

 <attachment name="conditionAttachment_AlwaysTrue" attachTo="Germans" javaClass="games.strategy.triplea.attachments.RulesAttachment" type="player">
   <option name="switch" value="true"/>
</attachment>

Nice thing about a switch is it can be referenced by all players.

Cheers...

Jason Green-Lowe

@wc_sumpton Amazing. That does it! Railroads are now appearing and disappearing on schedule. You've made the trains run on time...thank you.

wc_sumpton

@jason-green-lowe

Cheers...

beelee

@jason-green-lowe that's a cool lookin map. Is that the blood bath one ?

Jason Green-Lowe

@beelee Yup!

beelee

@jason-green-lowe sweet never seen it on triplea before. Nice job. Look forward to checkin it out