Alliances Broken?

[prastle]

I recall a topic about this somewhere but I cant find it. (GitHub?) Either way here is the save game upload of many multiple edits due to the alliances being now screwed up in 270 40% and I believe some other maps. The simple explanation is Parthia should be able to attack not move in and become a partner This also occurred elsewhere on the map with other countries. Just mentioning in case this is new.

0_1517980525917_screwed up alliances.tsvg

[General_Zod]

Is this from a bot game or a private host game?

I see the problem in xml. Question is did someone edit it or did the engine do it.

4 of the nations are listed in the roman alliance, and anti roman alliance.

[General_Zod]

I just checked the version of 270bc 40% in a bot. It is looks like that version has a bad xml.

All 3 versions of 270bc seem to have the same issue. Strange. Did someone update those recently?

[prastle]

@general_zod was in priv host
but @zlefin has also had same issue btw it is all 270 maps not just 40%

[Hepps]

To the best of my knowledge these are unchanged.

[prastle]

@hepps @General_Zod something changed somewhere since this issue was never there in past as you both well know.

[General_Zod]

Well , someone with the authority to update the depot maps should look into it. And at the very least replace the 270 bc maps with a repaired xml's.

       <alliance player="Carthage" alliance="AntiRomanAlliance"/>
       <alliance player="Numidia" alliance="AntiRomanAlliance"/>
       <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
       <alliance player="Syria" alliance="AntiRomanAlliance"/>

       <alliance player="RomanRepublic" alliance="RomanAlliance"/>
       <alliance player="Egypt" alliance="RomanAlliance"/>
       <alliance player="Parthia" alliance="RomanAlliance"/>
       <alliance player="GreekCityStates" alliance="RomanAlliance"/>
       

The section in question needs to look like this, with exception of Syria is Selucid, in some versions. Whoever does the changes needs to just use whatever names they already chose.

Hopefully there is not more errors.

[prastle]

@general_zod if you want to repair all three versions I will see about getting them uploaded. My curiosity is about how they got damaged?

[Panther]

I took a look into the map repositories @Github.

This is how it looks in the file 270BC.xml:

    <!--  RomanAlliance -->
    <alliance player="RomanRepublic" alliance="RomanAlliance"/>
    <alliance player="GreekCityStates" alliance="RomanAlliance"/>
    <alliance player="Parthia" alliance="RomanAlliance"/>
    <alliance player="Egypt" alliance="RomanAlliance"/>
    <!-- AntiRomanAlliance -->
    <alliance player="Carthage" alliance="AntiRomanAlliance"/>
    <alliance player="Seleucid" alliance="AntiRomanAlliance"/>
    <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
    <alliance player="Numidia" alliance="AntiRomanAlliance"/>

This is how it looks in the file 270BC_40%.xml:

                <!--  RomanAlliance -->
                <alliance player="RomanRepublic" alliance="RomanAlliance"/>
                <alliance player="GreekCityStates" alliance="RomanAlliance"/>
                <alliance player="Parthia" alliance="RomanAlliance"/>
                <alliance player="Egypt" alliance="RomanAlliance"/>

                <!-- AntiRomanAlliance -->
                <alliance player="Carthage" alliance="AntiRomanAlliance"/>
                <alliance player="Syria" alliance="AntiRomanAlliance"/>
                <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
                <alliance player="Numidia" alliance="AntiRomanAlliance"/>

And there is a file 270BC_Cernel.xml having it like this;

                <!--  RomanAlliance -->
                <alliance player="RomanRepublic" alliance="RomanAlliance"/>
                <alliance player="GreekCityStates" alliance="RomanAlliance"/>
                <alliance player="Parthia" alliance="RomanAlliance"/>
                <alliance player="Egypt" alliance="RomanAlliance"/>

                <!-- AntiRomanAlliance -->
                <alliance player="Carthage" alliance="AntiRomanAlliance"/>
                <alliance player="Syria" alliance="AntiRomanAlliance"/>
                <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
                <alliance player="Numidia" alliance="AntiRomanAlliance"/>

Are there other versions I probably missed?

[prastle]

@panther point is no one has touched these repos in months why are all three suddenly broken?

[Panther]

@prastle Maybe I don't understand what actually is broken. The xml-files in the games seem to have the alliances as @General_Zod said they have to be... So that part never has changed.

[Panther]

270BC even never has been touched for at least two years.

[prastle]

@panther load 270 40% or
270
and try to attack
all are now friendly
i have played this map for years
Thus my question is how has it suddenly become broken?

[prastle]

@panther correct they haven't been touched so what changed to break them

[Panther]

@prastle Got you now. Only the neutrals are attacked correctly. Interesting.

[prastle]

@panther i just 100 % confirmed iit iis the engine
works fine in 721
opps
7621
broken in 8304

[Panther]

Yes. So what makes these maps different from all the others where this issue does not occur and what engine change triggered this at least on these maps?

[prastle]

@panther nidea

[prastle]

@panther what engine changes touched politics lately?

[Panther]

@prastle I am checking the pull requests.