Large Middle Earth queries

Hepps · 8 Jun 2018, 18:38

@redrum Yes that is the only place it breaks maps.

But for the life of me I can't seem to change the file extension.

redrum · 8 Jun 2018, 18:40

@hepps Lol. Did you go to the link I posted? If not if you uploaded it here, I'll rename and then upload it back up Sometimes its just too much work to teach a man to fish...

PS. That should probably be a bug report and allow .jpg for smallMap images.

Hepps · 8 Jun 2018, 18:41

@redrum That's why I eat beef.

redrum · 8 Jun 2018, 18:41

@hepps Teach a man to slaughter cattle then...

Hepps · 8 Jun 2018, 18:45

@redrum Even when I open the file in Paint and choose JPEG... it still reverts the image back to a JPG.

God this is frustrating.

Hepps · 8 Jun 2018, 19:23

This is the image.

After some reading it appears JPEG is an old file extension. Why is the smallMap still using this exclusively?

Hepps · 8 Jun 2018, 19:51

I fugured it out. You can convert a JPG into a JPEG by saving over the original JPEG image.

But it was all for not since the intended outcome was far less than desirable.

Here is what I was hoping to do....

Here is what happens when you place an image with details in the smallMap....

Since the fill colour for territory owner ship has zero opacity... it simply over writes the image. Thereby making it impossible to dress up the small map.

redrum · 8 Jun 2018, 20:22

@hepps Sounds like someone wants a new feature request...

I don't think there is any reasoning behind only supporting .jpeg and not .jpg for smallMap. Should put a bug report in for that and it should be easy to fix.

Hepps · 8 Jun 2018, 20:29

@redrum said in Large Middle Earth queries:

@hepps Sounds like someone wants a new feature request...

I was just trying to explain what I was doing. I don't really thing the mini map is much of a priority. I was just testing whether or not I could dress it up.

I don't think there is any reasoning behind only supporting .jpeg and not .jpg for smallMap. Should put a bug report in for that and it should be easy to fix.

Sounds good. I think its warranted since it happens often.

Cernel · 8 Jun 2018, 20:29

@redrum Personally, I don't like the idea of supporting redundant extensions. I'd advice, when stuff is redundant, choosing and supporting only one, either JPG or JPEG only.
Of course, the best solution would be supporting only PNG and changing all minimap in the repository to PNG, but I guess not feasibly worthwhile.
I see that the problem is that some utilities oblige you to save in "jpg", not "jpeg". GIMP allows either.

Hepps · 8 Jun 2018, 20:31

@cernel I can open either with the software to maipulate the image. Problem is saving them.

Cernel · 8 Jun 2018, 20:34

So, to summarize my advice is:

1st best) Supporting only PNG and mass changing repository to PNG.

2nd best) Adding support for PNG, while keeping a deprecated support for JPEG (but not JPG).

In any case, I'm not a fan of supporting like both JPEG and JPG, in the moment no real difference.

redrum · 8 Jun 2018, 22:16

@hepps Here is the PR to allow .jpg and .png for small maps: https://github.com/triplea-game/triplea/pull/3452

Hepps · 8 Jun 2018, 22:33

@redrum GAM

redrum · 8 Jun 2018, 22:45

@hepps If you were going to define say a property in map.properties for the small map transparency what would you like that to look like? Like a decimal from 0.0 (transparent) to 1.0 (opaque)? Any other small map properties that would be of use?

0.3 alpha transparency

Regular (1.0)

Hepps · 8 Jun 2018, 22:43

@redrum Ummm... let me think.

Hepps · 8 Jun 2018, 22:45

@redrum Being able to set the window frame colour?

alkexr · 8 Jun 2018, 23:12

@Hepps gonna learn your secrets...

Hepps · 8 Jun 2018, 23:14

@alkexr Does this mean I don't have to do the map?

alkexr · 8 Jun 2018, 23:14

@hepps Nice try