Loading Unzipped Map From In-Game Download
-
@redrum Correct and, as I said, I would get over that, and just force it being exactly the same; let people convert their maps properly. Would @RogerCooper have issues with this? I cannot think about any other problem really.
Also that really sounds like something that may bury inconsistent mapNames in the future, perpetuating them. -
@redrum As long as @RogerCooper assured and is assuring his maps to have exactly the same folder name and mapName, whatever the way, I think there is really no reason to keep that autoconversion.
-
@redrum Also, in case you keep any autoconversion (I wouldn't), I'm wondering if turning upper case to lower case with a "_" before if any previous caracter is the only thing going on, or there are others (like turning spaces to a underscores and such).
-
@cernel Yeah, there is a bunch of stuff it tries around casing and spaces to try to get it to the github underscore format.
-
@redrum I guessed so; so my suggestion is to get over all that, and just say mapName=folder name; period.
If @RogerCooper can confirm that is not killing him, I really think there are no reasons to keep those conversions going on.
What does @LaFayette think? -
@cernel I don't really have a strong opinion and @LaFayette I believe is the one that originally created that. He may have more insight.
-
@redrum It was really just to have a second ditch defence in the moment of the mass conversion, I think. Going on, you are just going to accept or not accept new maps to the repo singularly, and just need to make sure to tell that the map name needs:
- no uppercase
- no spaces (underscores yes)
But it depends if @LaFayette already did the full conversion of all the mapName entries in all the XML (tho, in the meantime, a few new maps might have slipped in that are using the autoconversion).
-
Thanks all for the tips, discussion and especially an upcoming fix!
Cheers Zjelco
-
@redrum Are we supposed to do something to get @LaFayette read this? In GitHub he always does, when named, I think.
-
@cernel Not besides @ his username. Given that I already have the PR to address this posted, I'm sure he'll see it when he has some time.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login