Support for AA Attacks

[Frostion]

Would the answer to the question not be a matter of "the more options the merrier"? I think that I initially just thought about strength to the dice, but adding dice could of course also be wanted in some situations.

If a unit was to have more than one AA attachment, then of course it would also be necessary to specify what AA type should be boosted/nerfed.

[redrum]

@frostion Probably. Just wondering if map makers would want to change number of rolls for AA attacks but generally its probably a good option to have.

I'm planning to bundle the type of AA with the addition of multiple AA attack per unit with the other feature request. Figure no need to put it in prematurely.

[redrum]

Here is the PR: https://github.com/triplea-game/triplea/pull/4350

AT Support

    <attachment name="supportAttachmentATSupportgerman" attachTo="germanATSupport" javaClass="games.strategy.triplea.attachments.UnitSupportAttachment" type="unitType">
      <option name="unitType" value="germanAntiTankGun"/>
      <option name="faction" value="allied"/>
      <option name="side" value="defence"/>
      <option name="dice" value="AAstrength"/>
      <option name="bonus" value="2"/>
      <option name="number" value="3"/>
      <option name="bonusType" value="ATBonus"/>
      <option name="impArtTech" value="false"/>
      <option name="players" value="Germany"/>
    </attachment>

AT Counter Support

    <attachment name="supportAttachmentATCounterAmerican" attachTo="americanATCounter" javaClass="games.strategy.triplea.attachments.UnitSupportAttachment" type="unitType">
      <option name="unitType" value="germanAntiTankGun"/>
      <option name="faction" value="enemy"/>
      <option name="side" value="offence"/>
      <option name="dice" value="AAstrength"/>
      <option name="bonus" value="-10"/>
      <option name="number" value="3"/>
      <option name="bonusType" value="ATBonus"/>
      <option name="impArtTech" value="false"/>
      <option name="players" value="Usa"/>
    </attachment>

[Cernel]

If the other thing of allowing multiple AA attacks per unit can be done fast (I can help with the conversion of existing maps), wouldn't be better to keep this frozen until that is done first, so this can be tailored on that done?

[redrum]

@Cernel Shouldn't matter much since only a few advanced maps will consider using this so would be easy to update them if necessary. I also have no idea if or when I'll add multiple AA attacks per unit.

[Cernel]

@redrum Ok. Seemed to me that multiple was way more important than support, but I guess also the complexity is bigger.

[Frostion]

My new Warcraft map will make use of the AA support feature, and also the multiple AA if it becomes available But testing is a bit difficult right now as I am still building the map.

[redrum]

This is now merged into the latest pre-release and can be tested: https://github.com/triplea-game/triplea/releases/tag/1.10.0.0.13130

[redrum]

Added info and example to POS2: https://github.com/triplea-maps/the_pact_of_steel/pull/23/files

[beelee]

@redrum thank you