Invalid link in "Developer w/o Merge Rights" part

wc_sumpton

I'm very sorry that you are having these issues. This site is in need of volunteer developers. I really don't who you would talk to. Maybe @Panther or one of the other moderators.

Anyway, Welcome to the site and best of luck.

Cheers...

beelee

@Brazza Will ping @Myrd and @frigoref maybe they'll see this and can help. frigeroff was on git a couple days ago, so you might try pinging him on your thread there

Edit
I see you are already in touch with him

Brazza

Thanks for your response!

I have found a work to do which is solving issue ##13063, an issue of starting the game by email.

I changed the code and it seems to be working; the error report was removed. However, the functionality of that part didn't work on my computer, neither the orginal code nor the changed code.

I plan to submit a PR to allow some volunteers test it. Does that sound like a good idea？

Panther

@brazza said in Invalid link in "Developer w/o Merge Rights" part:

I plan to submit a PR to allow some volunteers test it. Does that sound like a good idea？

I don't know how you worked on it on Github, so just let me explain in brief, just in case you did it differently:
IIRC usually - when you work on the engine and the work exceeds a simple edit of the "triplea_maps.yaml" - you are asked to fork the project and apply the changes to your fork first. Then playtest from your fork. You can offer others builds from your fork, too, for the purpose of testing, Once you see your work is solid and ready to be applied to the main project, you will create a pull request from your fork to the project. Someone capable of understanding the changes and implications will (hopefully) react to the pull request by either merging or asking for changes or denying.

I vaguely remember a forum topic dealing with this more detailled.
Just have no time to search for it right now....

Brazza

@panther
Thanks for your tips!

I believed you have seen my PR. I made it a draft since I didn't check its functionality. The PR should make my fork accessible from branch tab of Github Desktop. Therefore, volunteers can copy the code from my branch and test the functionality.

If this behavior violates any norms or does not work as I expected, please tell me. I will fix it as soon as possible.

Panther

@brazza
Thank you. Indeed I saw (and reacted to) your PR on Github after having written the above posting.

I just wanted to raise attention and caution when merging something into the master-branch.
As many players use the latest pre-release for regular games, we usually would not want some 'breaking (rules, procedures, whatever) code' being merged.

The problem is that developers with merge rights usually are online quite rarely. So once maybe unwanted things are merged it might take some (long) time to redo.

I am sure your PR isn't problematic at all. But I wanted to inform you a bit about the background.

Brazza

@panther
I see. I changed my PR to the "ready for review" status. Now it should be merged when it got an approval.

Panther

@brazza Very good. Thank you.

Cernel

@brazza One thing not working since forever is the no neutral flyover (when the option "Neutral Flyover Allowed" is off).

You can test it in "World At War" (at default options).

Pick the fighter in Bohemia and send it to W.Romania: you cannot (and this is right).

However, if you pick the same fighter and move it first to Hungary and then move it to W.Romania, you can, and this is wrong.

If this gets fixed, the axterisc can then be removed from the point 2 of WAW notes.

Cernel

I've opened an issue for this problem.

https://github.com/triplea-game/triplea/issues/13244