GLOBAL WWII OIL & SNOW -Project

[beelee]

@ebbe Success ! Now your battle with git can continue It won't be too bad now. There's a couple things I noticed. There was a missing start image for China.

also in case you're unaware there's this issue at git https://github.com/triplea-game/triplea/issues/8979

I haven't looked at it but seems a fairly straight forward fix I'd think.

As I mentioned before I think you should make the font larger in Game Notes. At start of Game Notes is where you set it.

I tried it at 16 and seemed pretty good. Obviously you can set to w/e you want, I just found it too small.

Also some typos in Game Notes. So nothing too major. Good Job !

I'll post next with the git hub instructions on how to update

[beelee]

@ebbe so at git delete your repo
"merleyn /ww2_oil_and_snow_1st_edition "
you do that by clicking " settings" located upper right

then scroll to bottom of screen

and follow the prompts.

Next go to "triplea-maps" and click on "ww2_oil_and_snow_1st_edition " Then click "Fork" upper right

and follow the prompt. Now you have a copy of the repo that you can push changes too. Well...duty calls I'll be back in a bout an hour to finish this up.

Edit
Well If I haven't confused you already, I have confused myself lol.

[beelee]

@ebbe Well at least you know how to delete a repo and get a new one now
So by making the new repo "merleyn/ww2_oil_and_snow_1st_edition" you know you have the latest triplea one and it'll allow others to Fork it and add changes to it for you. That way you can check them out before you push them to the main triplea-maps one. At least I think lol

So lets say someone forks your merleyn repo, the one you Forked from triplea-maps, you can check out their fork by hitting "Code" and "Download Zip" of their Fork. Then you can put that zip in your triplea downloaded maps folder and try it out.

When you want to add something to "tripleamaps/ww2_oil_and_snow_1st_edition " you need to clone it. The green Code button again. This is where I better stop for now. I don't know how to do it with the pull and drag method. Only by terminal.

If you Fork the repo and then I can do the same you'll be able to DL the zip and checkout the changes. If you like them I can do a PR for you. But I don't really know how else to do it. I guess i could send files to you via sendspace or something, but seems as if we shouldn't have to do that.

Hmm...this might work. I'll make the changes to my Fork of oil and snow and you can DL the zip from there and if you like them I'll do the PR. You should do a map.yaml update as well but not necessary right away. Basically I try to test add enough stuff that they don't spam out. This is a new map so you'll have a few things to tune up but we'll talk about the yaml later.

Eventually you'll do it is the goal. I'm obviously not the best teacher lol

[beelee]

@ebbe The Chinese doc/image seems to be fixed. i get the music and the notification. Unfortunately I'm getting a missing unit image for Neutral_allies the infantry and Garrison. Those errors didn't show up before.

As mentioned above, i think it important to change xml version and document any change in a change log. Have you gotten the error for Chile ?

Yea so it looks as if it's missing "infantryChil" and "garrisonChil" for "Neutral_Allies". Weird it didn't throw before. Maybe the China start one overrode it somehow. At any rate, no biggie. Easy fix.

[beelee]

@beelee hmm... won't let me edit yea Neutral_Allies is missing "infantryChil" and "garrisonChil" . Wonder why it didn't throw before ? Maybe the China start one preempted it somehow. At any rate, no biggie. Easy fix.

I'm gonna roll through the rest of the round and then add some fixes for you to checkout at git

[beelee]

Right on see you fixed the missing images. i rolled through a full round and no errors. Gonna make some changes to the font and game notes, oh yea gotta check out that one error on line w/e was. At any rate i'll post it at git for you to checkout

[beelee]

@beelee hmm...not sure here. Does a unit name need a character/letter instead of all integers/numbers ? "1941" has a "unitName" and a "unitAttachment". It doesn't seem to affect the game. At least in round 1 anyway. I wasn't able to reproduce this error

https://github.com/triplea-game/triplea/issues/8979

[beelee]

Not sure what's up here. it didn't do it the last time.

seems to have some with the small map and Player color ? so maybe a pPlayer color is off ? Seems weird it'd show up now. At any rate, it'll need to be sorted.

[ebbe]

@beelee Seems solved now by removing no longer needed dummy players colours

[Schulz]

I've got an error message: "line: 1298, column: 25, error: Attribute value "1941" of type ID must be a name."

[beelee]

@schulz yea can't figure that one out. I didn't see it only went through round one. Can you play through it ?

I wonder if the name needs some characters not just numbers ? idk

[Schulz]

@beelee I can't even open the game unfortunately, but I am using version 2.2.

[beelee]

@schulz oh ? that's not good. This the error at git https://github.com/triplea-game/triplea/issues/8979

[ebbe]

@schulz Hej Schulz, thanks for reporting: that is a weird one indeed; I checked the files but so far found nothing extraordinary.... I cannot reproduce this bug myself, never saw it before from my side I try later today to solve it...

[beelee]

@schulz 2.2 for oil and snow ? There's only a 1.4 for now I believe . I sent ebbe an update to 1.5 at git. You can try it too
https://github.com/beelee1/ww2_oil_and_snow_1st_edition/tree/test
test branch hit green code button and downloadZip in case you didn't know

[Schulz]

I think it could be something to do with engine which doesn't allow units to have pure numbers. Maybe I could open the game by slighly changing the dates like 1941-winter.

[beelee]

@Schulz i just uninstalled and reinstalled and it worked for me. It should be WW2 Oil and Snow 1st Edition under experimental

[beelee]

@schulz yea thats what I thought. Hes got up to 1948 so have to do something a,b,c,d etc... are you on prerelease ?

[Schulz]

@beelee I am using outdated version because I m unable to open games beyond 2.2.

Edit: The engine didn't even allow combination of numbers and letters, i changed numbers with letters and it solved the issue.

After that the engine didn't allow some names like US territory. So I also changed them as US_territory

Then I got "Attribute value "garrisonMex" of type ID must be unique within the document error. Probably they are all related with the outdated version. I would like to check it if i will be able to open maps in 2.6.

[beelee]

@schulz yea that's what i suspected was all numbers being the problem. This is the 2.5 stable were using. I haven't actually encountered this. I just clicked through a round without doing anything tho just to see if it worked and check out the cool music and pop ups