2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6

[beelee]

I thought when you overbought max units, it wouldn't obliterate your entire buy ?

@TheDog did this change ?

[cameron]

@beelee
depends on game setting:

<property name="Unplaced units live when not placed" value="true" editable="false">
	<boolean/>
</property>

[TheDog]

@beelee

I thought when you overbought max units, it wouldn't obliterate your entire buy ?

Yes in latest 2.6 this is true.
Zlefin is asking about battle calcs, but I dont use that much.

[beelee]

@thedog

ok I had that happen so I'll grab a save next time and make a issue

[beelee]

Here's the save

Max Build Kills Entire Buy.tsvg

Game is here https://github.com/triplea-maps/global_40_expansion_uhd_boxes

Go ahead and move to wherever if needed. Saw we didn't have todo git reports anymore

[beelee]

Edit
14752

[beelee]

Idk if this matters but some units you are able to buy 3 of with 1 purchase

[TheDog]

@beelee
I have checked, 1941 GCD also has the same problem, that is all the purchases are wiped, when one of the purchases exceeds the maxBuiltPerPlayer, just like 2.5 used to do. Also 1941 GCD only has 1 for 1 purchases.

Shame 2.6 has regressed.

[wc_sumpton]

@thedog @beelee

Pre-Release 2.6.14441 was a fix for this problem... But, Pre-Release 2.6.14578/2.6.14624/2.6.14742 which delt with losing purchase during a saved game.

Cheers...

[Myrd]

@zlefin said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

Is there a setting to change the battle calcs default nation selection? I couldn't find anything in engine settings or in the battle calc screen itself

It used to be that it would default to the first hostile nation, but now it defaults to the nation who's current turn it is. That means that when I select one of my own provinces and open the battle calc it defaults to having my units as both the attacker and defender, which means I have to clear it in order to see what my units actual defenses are like (because a lot of units in the Arda map have modifiers that reduce hostile unit stats). I want to change the default so it's like it used to be, or at least defaults to something empty.

I think this was just an oversight, I guess the case of someone doing a battle calc on another player's turn wasn't considered... I can check if we can revert that part of the logic.

[Cernel]

@myrd said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

@zlefin said in 2.6 Release Getting Close - Need Volunteers to Help Beta Test 2.6:

Is there a setting to change the battle calcs default nation selection? I couldn't find anything in engine settings or in the battle calc screen itself

It used to be that it would default to the first hostile nation, but now it defaults to the nation who's current turn it is. That means that when I select one of my own provinces and open the battle calc it defaults to having my units as both the attacker and defender, which means I have to clear it in order to see what my units actual defenses are like (because a lot of units in the Arda map have modifiers that reduce hostile unit stats). I want to change the default so it's like it used to be, or at least defaults to something empty.

I think this was just an oversight, I guess the case of someone doing a battle calc on another player's turn wasn't considered... I can check if we can revert that part of the logic.

@Myrd Defaulting to "the first hostile nation" or whatever other deterministic way seems to me so simplistic that I would leave it empty.

If it has to default to something (and we are not using some sort of artificial intelligence somehow to calculate the most likely player against which it can be assumed one would want to calculate), I would have it being purely randomized but excluding the "Neutral" player and every player assigned as default to "Does Nothing".

For example, if, in "270BC Wars", I open the battle-calculator on "Carthage", the other side would be given as either "Rome", "FreeGreece", "Egypt" or "Parthia" with a chance of 25% for each of them (the random selection happening every time it is opened).

Alternatively, it would make sense to base it on simple statistical values, like opening on the enemy player having the highest current production amongst them all (the "biggest" one).

(The eligible players should be either them all or based on the alliances of playerList, not on the relationships (because there are and may be games in which you want to battle-calculate now against players having an allied relationship with you with which you may be at war in the future))

[TheDog]

@Myrd / asvitkine
Thanks for fixing the purchase panel persisting on max built error.

Here is the release that fixes it.
https://github.com/triplea-game/triplea/releases/tag/2.6.14766

[zlefin]

@myrd

I don't understand why you mention doing a battle calc on another player's turn not being considered, as my issue was occurring when i did battle calc on my own turn, which caused my own nation to be the attacker and defender

at any rate, ty for the work on fixing it, which ever path is chosen.

Personally I'd revert it to the behavior it used to have: which iirc is that of the first hostile nation in the list.

[LaFayette]

@zlefin The code for choosing attacker/defender is reasonably well commented: https://github.com/triplea-game/triplea/blob/master/game-app/game-core/src/main/java/games/strategy/triplea/odds/calculator/AttackerAndDefenderSelector.java

In your game, is the current player not at war with anyone? In this case, it looks like you could see the behavior of same attacker/defender. Namely due to this logic:

// Add the territory owner add the end of the priority list.  This way, when attacking an
// empty territory, the owner gets preferred even though they have no units in their land. In
// case the owner has units in the land, then they are already in the list but adding a second
// entry to the list doesn't impact the algorithm.

If there are no hostile nations, and you own the territory, and you are already the attacker, it looks like we could wind up with same attacker/defender.

[zlefin]

@lafayette

the nation in question was at war with some nations. It's a map with two fixed sides that are at war with each other from the start.

[Myrd]

@zlefin

I guess the "attacker == current player" logic was implemented and discussed here: https://github.com/triplea-game/triplea/pull/9602

I agree it doesn't make sense if the current player is clicking on their own territory, though.

[LaFayette]

Attacker == current player is consistent; predictable, usually desired since the current player is attacking and not defending.

When clicking own territory, it is essentially the same as selecting the attacking units first rather than using the territory that is to be attacked. This is common in multiplayer games. In multiplayer games you do not want to plop units into the territories you are thinking of attacking, it's shows exactly which battles you are considering.

The odd thing is that the defender should not be the same player, any of the opposing factions would be fine. Ideally it would be the next at-war faction based on the turn order of the game. For example, in Revised, as Russia, if you ctrl+b click your own territory, it should be setting up an attack (russia is on offense) and the next opposing faction is Germany. When Germany does similar, it would be UK on defense.

[zlefin]

I suppose that makes sense; personally when I'm attacking I just use the ctrl-a to add the relevant units.
When I open battle calc on my own territories its for checking the defensibility vs counterattacks or future turn hostile attacks.

As long as there's an easy way to do that as well I guess I can get used to the new system; since adding ssettings to let people choose how they want that behavior to be done would be too much work, at least given the numerous other work demands at present.

[LaFayette]

@zlefin Roger. Having options/variations might over-complicate things from both a code & user perspective. At the same time, it's not fun to constantly redo various clicks (which speaks to a poor UX).

Interestingly enough, it's surprisingly detailed how we expect the calc to work. The way I think it would ideally work (cc: @Myrd ) :

"ctrl+a" -> units owned by the current player from the given territory are selected as attackers. If no units are owned by the current player, then whomever owns the most units in the territory is chosen as the attacker. If the territory is empty, then the attacker is selected to be the territory owner (which could be "the neutral" player).

"ctrl+d" -> similar to 'ctrl+a' but operates with defense & ignores the current player (current player should be selected as the attacker)

"ctrl+b" -> same as "ctrl+a"

---

If the above sounds wrong/unreasonable - please speak up - but please add your comments here: https://github.com/triplea-game/triplea/issues/12688

[zlefin]

That sounds like you'd be changing the existing system so that ctrl-a and ctrl-d are opening battle calc windows of their own, rather than adding units to the existing battle calc window. I don't see how that would work with adding multiple locations worth of units together, which is one of the major purposes of those commands.

Since multiple calc windows can be open at once I don't think that would work at all.