Unit Option Can Submerge/Hide for Land Units (Partisan/Guerrilla/Spy/Diplomat/Munition)

[Hepps]

@redrum Ok I couldn't wait.

<attachment name="unitAttachment" attachTo="germanSpy" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
  <option name="movement" value="1"/>
  <option name="attack" value="0"/>
  <option name="defense" value="0"/>
  <option name="canHide" value="true"/>
  <option name="cancelsHide" value="Partisan:1:Spy:1"/>
  <option name="isAAforCombatOnly" value="true"/>
  <option name="isAAforBombingThisUnitOnly" value="false"/>
  <option name="isAAforFlyOverOnly" value="false"/>
  <option name="typeAA" value="Spyespionageattack"/>
  <option name="offensiveAttackAA" value="2"/>
  <option name="attackAA" value="3"/>  
  <option name="targetsAA" value="Diplomat:Spy:Patrisan"/>
  <option name="maxAAattacks" value="1"/>
  <option name="maxRoundsAA" value="-1"/>
  <option name="mayOverStackAA" value="true"/>  
  <option name="transportCost" value="1"/>
  <option name="isStrategicBomber" value="true"/>
  <option name="bombingMaxDieSides" value="4"/>
  <option name="bombingBonus" value="-2"/>
  <option name="bombingTargets" value="Truck:Material:Train:Rail:Factory:Aircraftplant:Barracks:Researchcenter:Airfield"/>
  <option name="isLandTransportable" value="true"/>
  <option name="isAirTransportable" value="true"/>
  <option name="requiresUnits" value="germanCity:germanBarracks"/>
  <option name="canInvadeOnlyFrom" value="none"/>
  <option name="canBeGivenByTerritoryTo" value="Germany"/>
  <option name="unitPlacementOnlyAllowedIn" value="Berlin:Hamburg:Stettin:Hannover:Bremen:Cologne:Breslau:Prague:Vienna:Munich:East Prussia"/>
</attachment>

[prastle]

@hepps @Redrum ( psycho's )

[prastle]

@Hepps @redrum If the spies become captured can we get tunneling options to escape the prison camp ? Sounds great I hope you guys pull it off!

[Hepps]

... Just taking a stroll through some over grown untended gardens...

[redrum]

@hepps Guess someone should tend to the gardens...

[Hepps]

@redrum Hopefully you know of a man with the shears enough to cut through the brambles.

[redrum]

@hepps Let's say I know a guy that definitely has the gardening skills... I hear he takes bribes...

[Hepps]

@redrum This sounds suspiciously like extortion.

[redrum]

@hepps More like a capitalistic way for him to appropriately prioritize which gardens to tend...

[Hepps]

@redrum Boy the gardener definitely let the vines grow thick in these gardens. The brambles have grown over everything.

[Hepps]

@hepps The only reason I followed up with a post in this thread was because I was reminded of it while revamping the sub/destroyer mechanics. Made me think it might be better to approach this idea with a broader scope in mind. As far as looking all the behaviors associated with this and how they are dealt with across all units (land/sea/air).

[redrum]

@hepps Open to discussion. I come back and think about this every so often. I'm waiting til we are working towards an incompatible release to address this as it'll probably break stuff. There are a bunch of issues with subs/destroyers and I think I'm going to break it into 3 parts:

1. Allowing the existing system to work for land/air units
2. Breaking isSub and isDestroyer into smaller attributes so more fine grained control can be achieved (canHide, firstStrike, canTarget, canBeTargetedBy, etc)
3. Rework some of the global XML sub properties so that they make more sense and for some be specified at the unit level: https://forums.triplea-game.org/topic/355/sub-xml-properties

[Hepps]

Cool. All basically what I was thinking of. Glad to see the gardener still looks in on the brabbles once in a while.

[RogerCooper]

Let's generalize it with the concept of a "stealth" property and "anti-stealth" property. Stealth units can retreat before a combat round unless an anti-stealth unit is present. "stealth" units can't be attacked unless an anti-stealth unit is present, but they can be fired on when the "stealth" unit is an attacker.

Possibly you would need "land-stealth" and "sea-stealth" properties. Your ASW aircraft would not help against guerillas.

[Hepps]

@rogercooper Yes the idea is to make a "stealth" type behavior attachable to units rather than as a all encompassing "Global Property".

The other half of the equation is also making the effects on a settable basis... ie. 1 destroyer does not affect the behavior of infinite subs.

[RogerCooper]

@hepps Limiting the effect of anti-stealth units can create problems. What if there is more than 1 type of sub?

[Hepps]

@rogercooper Well the concept I had initially proposed would allow the behavior to be settable like a support attachment. So you would have the ability to choose which units an ability can effect as well as the count.

[Cernel]

@hepps How about being also able to make them re-emerge, the same way, on any following combat rounds?

[redrum]

It begins... https://github.com/triplea-game/triplea/pull/4829

I'm focusing on first allowing the existing system to work for land/air units. You can now make land and air units have isSub and isDestroyer...

[prastle]

@redrum UG! Now he will get his Spies …. sigh wasn't it complex enough yet?