Flags for units not showing

TheDog

@victoryfirst
I do not know how the mini flags work...

But , below is a screen shot from 1941 GCD
All the non moving units do not have a mini flag;
Bunker
Oil-Field
Industry-Med

So is this your commonality too?

VictoryFirst

@thedog

You hit the nail on its head... the supply units indeed have 0 movement and therefore have no flag showing. Thank you, that makes sense and I did not know that!

Since supply in this game can only move when transported by a truck, what would be the best way to solve this? Is there a way to give the supply a movement value but not allow it to move? Or should I just add a flag to the unit image itself?

TheDog

Give 1-Supply a move 1 and give terrain effect to the territory of;
<option name="movementCostModifier" value="1-Supply" count="1"/>

But this is a lot of extra code as each territory will need the effect.

.
Yes, put the mini flag on the 1-Supply unit, as that might achieve the same effect?

beelee

@thedog said in Flags for units not showing:

Yes, put the mini flag on the 1-Supply unit, as that might achieve the same effect?

Yea that's probably the easiest. Of course it won't work with Large flags.
You might want to save as is also and throw it in misc or somewhere for those that don't use flags.
They can then switch it out.

wc_sumpton

@victoryfirst

This would be an easy fix, since it is the same problem as with the Active Units and Move Selection. A PR was submitted but... So, I doubt that a fix for this would be accepted.

Any who, have fun!

Cheers...

beelee

@wc_sumpton

Can you post your changes that haven't been accepted to a different git repo so that people can dl it and use it separately from triplea ?

It seems that testing is the hang up. I don't understand how java works but just playing the game seems like good testing to me

wc_sumpton

@beelee said in Flags for units not showing:

It seems that testing is the hang up.

LoL. These were not rule changes, they did not change the way the game was played. They updated how units were selected for display. How do you test for display changes?

Update for the Active Units Scroller would show units on transports that can be unloaded (which seems to me to be a no brainer). Would also show units which may receive movement/could be transported even if the movement were zero.

Cheers...

beelee

@wc_sumpton

heh heh

just to clarify, the testing hangups are from the github gods

wc_sumpton

@beelee said in Flags for units not showing:

just to clarify, the testing hangups are from the github gods

I know, that's why I pulled the PR. But even when testing is included, remember "hasResource", contained testing.

What I try to do is submit improvements, what I feel, IMHO, would either enhance gameplay, or map making. Something, I feel no other developer are concerned with.

Nuff' with the

Cheers...

beelee

@wc_sumpton

yea i get ya, even if you are Lions fan

Hopefully Victory First finishes his java class and jumps in