Fuel Enhancements

[redrum]

Couple of small adjustments and here is the PR: https://github.com/triplea-game/triplea/pull/3189

Before

After

[Frostion]

I would think it is best to have that movement canvas coloured in a clean grey color as in the first picture examples, not a creamy yellowish sandish coloring.

The reason for this is that any coloring of the canvas, might be in visual / stylish conflict with the specific map artwork or style. Also, I would say that grey might be the most neutral color that would go along with any engine UI. (Excluding black and white, as they are not as pleasant for the eyes.)

I think that the newest pictures look great, as the coloring is in line with the CW map. But we have to think of ALL maps.

[redrum]

@frostion I'm open to different canvas colors and will probably go with whatever the majority votes for. Here is a light gray version:

If anyone wants to suggest a specific color code, I'm glad to give it a try.

[General_Zod]

@redrum

Maybe try the first number back to yellow if using a grey again.

[redrum]

@general_zod Yellow ends up being way too light to show on a light gray background as well.

I made a few adjustments to colors and here is the latest:

[beelee]

@redrum That looks pretty good

[Frostion]

Let me just throw in new proposals:

I have used @Hepps mockup and redrums screenshots as basis for these.
I think the added arrow really help explain what info is being displayed, plus it is an eye catcher.
I removed the blue, as the dash number is in essence a part of the same number in front of it.
Lastly I removed the ( and ) as it seems redundant.

Thoughts?

[Hepps]

@frostion I do like the arrow since as you say it keeps things consisent as far as icons. Also really like the numbers for movement the same colour. The yellow version is with the darker background would have to be my favorite.

[redrum]

@frostion So for the initial iteration I'm going to leave as is but interesting suggestions. Thoughts:

1. I'm kind of neutral on parens vs no parens.
2. The red doesn't show up very well on the darker gray background but the yellow looks nice.
3. I'd probably make the green a bit darker but like how the light gray example looks. The challenge would be that if you have a move beyond max movement and it only shows the green number that would seem to contradict the red X you get as green tends to indicate "go"/"success".

[redrum]

The latest changes have been merged and can be tested in the following pre-release: https://github.com/triplea-game/triplea/releases/tag/1.9.0.0.9464

[redrum]

So on to fuel flat costs... Here is an example of what I'm proposing for the new XML parameter (fuelFlatCost):

	<attachment name="unitAttachment" attachTo="fighter" javaClass="games.strategy.triplea.attatchments.UnitAttachment" type="unitType">
		<option name="movement" value="4"/>
		<option name="carrierCost" value="1"/>
		<option name="isAir" value="true"/>
		<option name="attack" value="3"/>
		<option name="defense" value="4"/>
                <option name="fuelcost" value="oil" count="1"/>
		<option name="fuelFlatCost" value="oil" count="2"/>
                <option name="fuelFlatCost" value="pilots" count="1"/>	
	</attachment>

This would mean a fighter pays 2 oil & 1 pilot if it moves at all plus 1 oil per each move. So if it moved a total of 3 then it would pay 5 oil and 1 pilot. The goal is to have both the existing per move fuel cost (fuelCost) and the new fuel flat cost (fuelFlatCost) work for all unit types and be able to be used in any combination.

[prastle]

@redrum are oil reserves being added for future maps

[prastle]

@redrum storage tanks that can be bombed?
smells a Heppster in this scenario

[redrum]

@prastle I sure hope so. Otherwise I'm adding features just for the fun of it

Actually I believe you could probably do some kind of bombing where when a structure is destroyed, you trigger loss of resources.

[prastle]

@redrum your both evil bastards

[Hepps]

@redrum Looks great! Adding all these features just for the fun of it. What a champ!

[prastle]

@hepps @redrum you both realize I EXPECT POS2 @ UPDATES and this will make GD a very rough map
sigh

[prastle]

@hepps its almost like you want all to ignore unless Tylenol scripts

[redrum]

@prastle Did you just volunteer to update POS2 XML?

[prastle]

@redrum NOPE! but with all your additions I really hope you did