Alliances Broken?

[prastle]

@general_zod if you want to repair all three versions I will see about getting them uploaded. My curiosity is about how they got damaged?

[Panther]

I took a look into the map repositories @Github.

This is how it looks in the file 270BC.xml:

    <!--  RomanAlliance -->
    <alliance player="RomanRepublic" alliance="RomanAlliance"/>
    <alliance player="GreekCityStates" alliance="RomanAlliance"/>
    <alliance player="Parthia" alliance="RomanAlliance"/>
    <alliance player="Egypt" alliance="RomanAlliance"/>
    <!-- AntiRomanAlliance -->
    <alliance player="Carthage" alliance="AntiRomanAlliance"/>
    <alliance player="Seleucid" alliance="AntiRomanAlliance"/>
    <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
    <alliance player="Numidia" alliance="AntiRomanAlliance"/>

This is how it looks in the file 270BC_40%.xml:

                <!--  RomanAlliance -->
                <alliance player="RomanRepublic" alliance="RomanAlliance"/>
                <alliance player="GreekCityStates" alliance="RomanAlliance"/>
                <alliance player="Parthia" alliance="RomanAlliance"/>
                <alliance player="Egypt" alliance="RomanAlliance"/>

                <!-- AntiRomanAlliance -->
                <alliance player="Carthage" alliance="AntiRomanAlliance"/>
                <alliance player="Syria" alliance="AntiRomanAlliance"/>
                <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
                <alliance player="Numidia" alliance="AntiRomanAlliance"/>

And there is a file 270BC_Cernel.xml having it like this;

                <!--  RomanAlliance -->
                <alliance player="RomanRepublic" alliance="RomanAlliance"/>
                <alliance player="GreekCityStates" alliance="RomanAlliance"/>
                <alliance player="Parthia" alliance="RomanAlliance"/>
                <alliance player="Egypt" alliance="RomanAlliance"/>

                <!-- AntiRomanAlliance -->
                <alliance player="Carthage" alliance="AntiRomanAlliance"/>
                <alliance player="Syria" alliance="AntiRomanAlliance"/>
                <alliance player="Macedonia" alliance="AntiRomanAlliance"/>
                <alliance player="Numidia" alliance="AntiRomanAlliance"/>

Are there other versions I probably missed?

[prastle]

@panther point is no one has touched these repos in months why are all three suddenly broken?

[Panther]

@prastle Maybe I don't understand what actually is broken. The xml-files in the games seem to have the alliances as @General_Zod said they have to be... So that part never has changed.

[Panther]

270BC even never has been touched for at least two years.

[prastle]

@panther load 270 40% or
270
and try to attack
all are now friendly
i have played this map for years
Thus my question is how has it suddenly become broken?

[prastle]

@panther correct they haven't been touched so what changed to break them

[Panther]

@prastle Got you now. Only the neutrals are attacked correctly. Interesting.

[prastle]

@panther i just 100 % confirmed iit iis the engine
works fine in 721
opps
7621
broken in 8304

[Panther]

Yes. So what makes these maps different from all the others where this issue does not occur and what engine change triggered this at least on these maps?

[prastle]

@panther nidea

[prastle]

@panther what engine changes touched politics lately?

[Panther]

@prastle I am checking the pull requests.

[prastle]

@panther ty @redrum you probably need to read this thread as well please bro.

[prastle]

@ssoloff and @RoiEX could you guys please glance at this thread as well

[Panther]

@prastle Actually I can't remember any. But maybe it is a side effect of something I would not associate it with. On the other hand there is not much politics inside the 270 map. I mean the alliances are fix right from the beginning just as in other games where we don't see this issue... very strange...

[prastle]

@panther i guess we have to test a few at a time to narrow down where it broke and with what release

[Panther]

@prastle Indeed. I am still browsing the PRs to get an idea where to start.

[prastle]

@panther it is somewhere between 7634 and 7804 prs

[prastle]

@panther this one is the culprit
https://github.com/triplea-game/triplea/releases/download/1.9.0.0.7746/TripleA_1.9.0.0.7746_windows-64bit.exe
or
this one
https://github.com/triplea-game/triplea/releases/tag/1.9.0.0.7752