Large Middle Earth queries

[prastle]

@beelee it wasn't the bat attacking a bear part?

[alkexr]

@redrum Couldn't reproduce in 1.9.0.0.9347

[mattbarnes]

@hepps Thanks for your reply but the Game Notes say a Creature defends at -1 in a Settlement. In addition, as @alkexr says, it should also have a +1 for being "All". How do you get -2? Have you read that from the XML? Does the XML differ from the Game Notes?

Also, you say the 2 Hit Bears are working correctly and yet @alkexr has posted a bugged file. Why do he and I have the bug and you don't?

[Hepps]

@mattbarnes Yes... the XML differs from the notes.

I think the bug is related to the exact engine version you may have been playing with. I am on a different engine and the 2 hit issue appears to have been isolated to the engine version you were playing with.

[redrum]

@mattbarnes Yeah the hit points bug has been fixed and looks like @alkexr was able to confirm that using one of the pre-releases (1.9.0.0.9347).

[mattbarnes]

@hepps Is it possible to circulate a table of modifiers based on the XML please, to the extent that they differ from the Notes?

[Hepps]

@mattbarnes It is the responsibilty of the map maker to correct issues with the map.

[alkexr]

@mattbarnes Known issues affecting gameplay are:

• Incorrect tooltip for dwarven units
• Incorrect territory effect for bears in settlements
• No unit production after losing capital

[Hepps]

@alkexr I would add....

No nation flags (large and small) to make gameplay more user friendly.

[alkexr]

@hepps That didn't make it to this list since it does not directly affect gameplay. I didn't forget it, don't worry

[Hepps]

@alkexr Fine what about the questionable support mechanics? Were those already corrected?

[mattbarnes]

Can I just say again: it's a fantastic map? So intriguingly complex.

[mattbarnes]

Hey - one more game mechanic observation: after I foolishly lost Rivendell, my Eagles no longer repair at the end of my High Elf turn. Is that deliberate?

[alkexr]

@mattbarnes I think this is an engine thing, ask @redrum
In any case, at this point I'm sufficiently fed up with all the problems around capitals that I will simply not use capitals in the next version. It's not like you would want to give up your capital even if it was just a normal territory.

[mattbarnes]

No problem, I'll ask Redrum. However, I'm interested in your intent as creator: I'm playing PvP and find myself with non-repairing Eagles. Should we consider it a game error and Edit each round to correct this, or should we just accept the game as it is?

[redrum]

@mattbarnes Whether you control your capital I don't think influences whether your units repair to my knowledge. Do you have the save game?

[mattbarnes]

@redrum Yep, here it is.0_1527063152473_M&M1.tsvg

[redrum]

@mattbarnes I don't think that is the right save game as I see them repairing in the 4th round...

[mattbarnes]

Sorry. This one: 0_1527150174137_M&M2.tsvg

[redrum]

@mattbarnes @alkexr So the engine behavior is correct as this map is using this repair property:

				<property name="Two HitPoint Units Require Repair Facilities" value="true" editable="false">
					<boolean/>
				</property>

And eagle units are defined as repairing themselves:

					<attachment name="unitAttachment" attachTo="eagle" javaClass="games.strategy.triplea.attachments.UnitAttachment" type="unitType">
						<option name="isAir" value="true"/>
						<option name="movement" value="8"/>
						<option name="hitPoints" value="2"/>
						<option name="repairsUnits" value="1:eagle"/>						
                                                <option name="attack" value="4"/>
						<option name="attackRolls" value="2"/>
						<option name="defense" value="3"/>
						<option name="defenseRolls" value="2"/>
                    </attachment>

This means if the player that owns the eagles loses their capital then the eagles won't be repaired as for 'repair facilities' to function for units the unit owner must control at least one of their capitals. Whether that is what @alkexr intended is a different question and I'm guessing that the use of that property and units repaired themselves was done for some other reason and this is probably a side effect since it isn't mentioned in the notes.

Here is the code snippet and explanation for reference:

        // Damaged units can only be repaired by facilities if the unit owner controls their capital
        if (!TerritoryAttachment.doWeHaveEnoughCapitalsToProduce(damagedUnit.getOwner(), damagedUnit.getData())) {
          return false;
        }