Add Unit Count and Damage Display Outline

[alkexr]

I would suggest considering separate images for digits instead of numbers. While that complicates calculating display coordinates, it has the great advantage of requiring 10 images instead of infinitely many. Though then you couldn't have Roman numerals for 270 BC, which would be a shame, really.

[Hepps]

@alkexr I'm easy. I do not profess to know the best way to handle this from a technical standpoint. All I know is that after rendering a near infinite number of trees, hills, mountains and houses.... I can probably design as many numbers as we could possibly need.

[prastle]

@hepps we allllll know YOUR EASY! nice ideas

[Hepps]

@prastle You only know that because we've been on a date. If you hadn't been swept off your feet by my rugged good looks and charm... you'd have not idea.

[prastle]

@hepps ROFL!
yes dear

[redrum]

@Hepps So is the main point having a nice outline for the unit numbers? If so I'd probably want to consider doing it without images first before falling back to that option. But what you propose should be theoretically doable and I'd probably agree with @alkexr to draw each digit so less images are needed.

Also the benefit of figuring out how to do it programmatically is we keep the font size options. Though I guess in theory you could do something with image sizing.

[Hepps]

@redrum I am open to all kinds of options... fast and loose that's how I like to play it.

I guess just working on a couple different maps lately I started to really see how the monochrome pixilated numbers are a huge opportunity for maps. And while antialiasing alone would be an improvement, it by no means solve the issue of maps with a variety of unit and territory colours, shading, reliefs, unit colours.....

So while pondering it I thought the best would be a outline. the reason I suggested an image is really a by-product of two things...

First I thought an outlined number was not possible to render currently. (as a font)

Second I thought if they were images then it allows the creative juices to just flow, since you could do all kinds of wonderful things both with numbers as well as backgrounds.

[alkexr]

@redrum said in Inception: A dream within a dream (Unit stack numbers display):

figuring out how to do it programmatically

In C# what I would do is to draw the number (string) to a Bitmap first (don't know java equivalent). Then for each pixel P, you take the maximum of (alpha of pixel Q * strength - Euclidian distance(P, Q) * sharpness) over all pixels Q on the bitmap, this will be the alpha of the outline. Then you overlay the original bitmap over the outline. (Strength and sharpness are parameters.) If you only take the maximum over pixels Q within a radius of (255 * strength - sharpness), then you get the same result in O(n^2) relative to the height/width of the bitmap.

[Frostion]

Just outlining the current numbers would be a great improvement! The default white numbers can be hard to see and distinguish on bright territory backgrounds. (Yes, I know that I can change colors... But I don't want to )

[redrum]

So here a first go at it:

And with a large number of units:

Before:

[Hepps]

@redrum How is that possible? How was this able to be done so quickly?

[redrum]

@alkexr That's a bit more graphics kungfu then I'm doing at the moment. Initially, I'm just outlining the text by first drawing it at the 1 pixel over northwest, southwest, northeast, and southeast positions with the outline color and then drawing the text in the center with the text color. As well as enabling anti-aliasing.

[Hepps]

@redrum All good. I just thought this would be a much bigger undertaking...

"To the uninitiated everything appears to be made of magic"

[redrum]

@hepps Well, my pretty simple approach took about 5 minutes. Ask and thou shall receive

Open to trying some other ideas if folks want. Probably gonna at least add an option to set the outline color as well.

[Hepps]

@redrum That was my very next question.

I'm going to use inception more often. It appears to be highly effective as a title.

[redrum]

And did unit and bombing damage as well:

[redrum]

And the update font preferences:

Any thoughts on defaults? Unit color/outline as white/black seems good. But black numbers with white outline are a bit jarring. Maybe do a gray for default outline for hit and bombing damage? Also should the default font size be a bit bigger? 12 seems really small on most screens/maps.

Current defaults:
private static final int MAP_FONT_SIZE_DEFAULT = 12;
private static final Color TERRITORY_NAME_AND_PU_AND_COMMENT_COLOR_DEFAULT = Color.BLACK;
private static final Color UNIT_COUNT_COLOR_DEFAULT = Color.WHITE;
private static final Color UNIT_COUNT_OUTLINE_DEFAULT = Color.BLACK;
private static final Color UNIT_FACTORY_DAMAGE_COLOR_DEFAULT = Color.BLACK;
private static final Color UNIT_FACTORY_DAMAGE_OUTLINE_DEFAULT = Color.LIGHT_GRAY;
private static final Color UNIT_HIT_DAMAGE_COLOR_DEFAULT = Color.BLACK;
private static final Color UNIT_HIT_DAMAGE_OUTLINE_DEFAULT = Color.LIGHT_GRAY;

[redrum]

Last but not least the PR with the changes: https://github.com/triplea-game/triplea/pull/3488

[Frostion]

Personally I think 12 is nice. Especially since the unit pictures themselves are pretty small. If pictures were bigger, then the text should of course also be set to be bigger.

[prastle]

@frostion The colour blind bastd chimes in white is best but either are an improvement just my 2 cents