[Open] Global 1940 Balanced Mod3

ssoloff

It looks like there are legitimate errors in a few of the Global 1940 map variants. Within objective.properties, there are several entries that have an extra semi-colon between the property name and value. That is, instead of just = separating the property name and value, the erroneous lines use ;=.

Below are all such instances:

objectives.properties:395:World_War_II_Global_1940_Balanced_Mod.Russians;triggerAttachment_Russians_4_Increased_Lend_Lease_War_With_Japanese;=Additional <b>2 PUs</b> for each lend-lease route that is open if Japan has declared war on Russia.
objectives.properties:511:World_War_II_Global_1940_Balanced_Mod_with_Combat_Move_First.Russians;triggerAttachment_Russians_4_Increased_Lend_Lease_War_With_Japanese;=Additional <b>2 PUs</b> for each lend-lease route that is open if Japan has declared war on Russia.
objectives.properties:567:World_War_II_Global_1940_Balanced_Mod_with_Combat_Move_First.Russians;triggerAttachment_Russians_4_Increased_Lend_Lease_War_With_Japanese;=Additional <b>2 PUs</b> for each lend-lease route that is open if Japan has declared war on Russia.
objectives.properties:630:World_War_II_Global_1940_Balanced_Mod3.Russians;triggerAttachment_Russians_4_Increased_Lend_Lease_War_With_Japanese;=Additional <b>2 PUs</b> for each lend-lease route that is open beyond Round 2 if Japan has declared war on Russia.
objectives.properties:709:World_War_II_Global_1940_Balanced_Mod3_with_Combat_Move_First.Russians;triggerAttachment_Russians_4_Increased_Lend_Lease_War_With_Japanese;=Additional <b>2 PUs</b> for each lend-lease route that is open beyond Round 2 if Japan has declared war on Russia.

Panther

https://github.com/triplea-game/triplea/issues/3885

scousemart

@panther Super, I take it when it gets fixed, there'll be an announcement or will it automatically be added to the map downloads as an update?

Panther

@scousemart This will be fixed in the map repo, that you can follow here https://github.com/triplea-maps/world_war_ii_global , if interested. Once this issue will be fixed, there will be a corresponding map-version update that triggers a map-file update through the TripleA-software.

simon33

If you delete and download the package, you should get the fix.

scousemart

@simon33 Took me a while to figure out GitHub and download the file package from there, but I did it and it works great! Thanks.

simon33

But you shouldn't have had to do that! Just deleting the map from within Triple-A and then downloading it again should have worked for you.

scousemart

@simon33 Ok, now I see what you meant. I got a bit confused when you said delete package. Although I would have thought it would have shown up as an update to the map, or is that more difficult to implement?

simon33

That requires an additional step which I don't control.

scousemart

Just noticed that the map name in the zip file is ww2global40_balanced2_0, whereas the mod shown in the game as Balanced Mod3. I know it's not that important but I think the xml should have the same names.
I thought someone should know. :winking_face: