Misspelling in World War II Global maps.
-
@cernel Ok, so did it using the "Ural" name image. Here are the two options:
I don't intend to touch this map myself, but I'll explain what to do:
You need to change the territory name in all xml of all games.
You need to change the same entry in all txt having it (I suggest a mass change with a text editor having such functionality).
You need to add the image in "misc", and remove the current "Paulau_Island.png" in there.
You need to redefine the coordinate for such image in decorations.txt.
At this point I suggest you play a game, just to be sure.
You need to push the changes via GitHub, and probably ask somewhere else for an admin to review and merge it.
Of course, this will break compatibility with all current games, meaning that people will be unable to continue their saved games if they update or if they are bot users and the bots are updated.
Edit: Updated images to maybe keep the same settings as the original to delete, tho I'm not sure it did (doesn't really matter).
-
@scousemart said in Misspelling in World War II Global maps.:
Although as you said, the Japanese were only garrisoned on one island which sort of makes sense they used Island rather than Islands.
Actually, most islands were garrisoned. The most famous one is probably Peleliu.
-
@cernel Thanks. As you have provided some detailed instructions, I'll be happy to give it a go.
I'll let you know how it goes. :grinning_face_with_smiling_eyes:
Just out of curiosity, if I change this map and use it in a PBEM or PBF game, would my opponent need to have the same updated map? -
@scousemart Yes, it is breaking both backward and forward compatibility.
Also, this fix is basically a hack, as I've surged the "al" of "Ural" into the other one. Of course, nobody is going to notice anything, but just saying it is not as correct as if doing the image with the exact settings as the original maker would have used. So, maybe, I'm thinking it would make sense to keep the old "Paulau_Island.png" image in the folder.
The map admins will have to decide if it is worth breaking compatibility for this, as it is ultimately them that will have to respond for it to the community (as this map having no specific owner). I'm personally neutral on this matter.
-
@cernel I'm thinking especially if this map has other wrong entries, maybe better sticking to the intended naming (thus correcting the unintended misspelling only), even if not correct, so at least to be consistent in that direction. So, maybe forget about my remarks on "Islands" vs "Island"; probably pointless, I guess. Anyways, an image with "Palau Islands" can also be made (taking "Islands" from another one), if preferred.
-
@cernel This might sound a daft question but why couldn't one edit the original .png from Paulau Island to Palau Island? Is this not possible? To my unexperienced mind, I would have thought that if there were no other changes to the map, other than the actual .png, it wouldn't break the game.
-
@scousemart That way you would see the new image on the board, but everywhere else the reference would remain the same. I surely advise against that.
-
@cernel Sorry, I was being as bit over zealous. I meant if the original .png was edited and the references in the game were changed to reflect that, that wouldn't work because the .txt files and .xml files would be different to the original files and thus break the game?
-
@scousemart Yes, you need to change everything. Theorically you can keep backwards compatibility by keeping the old entries and the old images in all skin files, tho that is quite patchy (and implies having useless entries all around, that doesn't feel quite right).
-
Aaand you need to change that way all the mapskins, as well. On this matter, I see that in the "battlemap_skin" there is a "Pau", written in the relief themselves, and this means that cannot be cleanly changed, unless you can get (I guess from Veqryn) a version of the relief without the added writings.
So, considering the importance of the mapskins and to keep consistency with that, I think this matter (specifically changing to any names not starting exactly as "Pau") cannot be feasibly made. I suggest giving up or contact Veqryn to maybe have the original graphic, if possible. Of course, it would be possible to surge the relief as to change the "Pau" to "Pal", and nobody would notice anything strange, but that would be changing the graphic arbitrarily. -
@cernel Maybe I should take up your suggestion and give up. Not that I'm not willing to have a go but it sounds like a lot of hassle with no guarantee of success, either getting it out in the community or actually getting it to work.
-
@scousemart The changes could be made quite easily if there were no backwards compatibility concerns.
-
@hepps said in Misspelling in World War II Global maps.:
@scousemart The changes could be made quite easily if there were no backwards compatibility concerns.
Yes, but it seems that is the problem, backwards compatibility. :confused_face:
-
Moving to Maps & Mods.
-
@cernel said in Misspelling in World War II Global maps.:
Aaand you need to change that way all the mapskins, as well. On this matter, I see that in the "battlemap_skin" there is a "Pau", written in the relief themselves...
I'm rather curious about the "battlemap_skin" you refer to in your post. I can't seem to find it in the map folder.
-
@scousemart You can download mapskins like maps. This mapskin is available in the repository, under skins. Map skins are a view option, of course.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login